Future plans, possible contribution

[RubendeBruin]

Hi, I just stumbled upon this repository. Looks promising and well maintained!
I'm the author of MaFreDo (https://mafredo.readthedocs.io/en/latest/index.html) which has some of the same functionality in terms of RAO regridding but with only me as contributor. I made it just because I needed it at that time, but it may be open for merging it into this repository instead if you are open for it.

Would you be open to discuss merging the MaFreDo functionality into this repository? That would involve (in due time):

• adding a "heading" property to 1d spectra to indicate their direction
• adding Hs/Tp calculation from spectrum data (edit: already present)
• making an import function for wavespectra from the wavespectra package (for reading model or measurement data)
• rewriting the interpolate functions such that phase and amplitude are interpolated independantly
• adding some definitions about phase angle definitions (leading, lagging)
• a squash function to transform a 2d spectrum into a 1d (edit: already present)
• .... probably some more.

For myself I would use the repository for post-processing RAOs generated with DAVE (usedave.nl) to plot and visualize vessel responses.

[vegard-solum-4ss]

Hi, thanks for your feedback @RubendeBruin. And sorry for the late reply.

I’m glad that you find the package useful! Any suggestions and/or contributions are very welcome! Regarding your suggestions:

Adding a "heading" property to 1d spectra to indicate their direction:

• Where do you suggest to add such heading information?
• Currently, the package does not have a designated class to handle 1-D spectra (but we may implement it in the future). As it is now, 1-D spectra are simply handled as numpy arrays of frequency and spectrum values.
• However, the package has functionality for converting a 1-D spectrum into a 2-D spectrum, and it has functionality for squashing a 2-D spectrum into a 1-D spectrum (as you have pointed out). And when you construct a 2-D spectrum from 1-D, you must provide a peak direction (as well as a spreading function).

Adding Hs/Tp calculation from spectrum data (edit: already present):

• Yes, already present.

Making an import function for wavespectra from the wavespectra package (for reading model or measurement data):

• Can you elaborate a bit more on this?

Rewriting the interpolate functions such that phase and amplitude are interpolated independently:

• I believe this is already available. See the complex_convert flag given in the interpolate method – setting complex_convert=”polar” should yield independent interpolation of phase and amplitude.

Adding some definitions about phase angle definitions (leading, lagging):

• Yes, this is something we should do! I will put it on our backlog. You are also welcome to make a pull request if you like. (edit: I have now made a PR which addresses this)

A squash function to transform a 2d spectrum into a 1d (edit: already present):

• Yes, already present.

[RubendeBruin]

Importing from wavespectra

Making an import function for wavespectra from the wavespectra package (for reading model or measurement data):

Can you elaborate a bit more on this?

I've implemented this here:.

Phase interpolation

Closed here, continues in #60

Adding a "heading" property to 1d spectra to indicate their direction:

Where do you suggest to add such heading information?

Currently, the package does not have a designated class to handle 1-D spectra (but we may implement it in the future). As it is now, 1-D spectra are simply handled as numpy arrays of frequency and spectrum values.

However, the package has functionality for converting a 1-D spectrum into a 2-D spectrum, and it has functionality for squashing a 2-D spectrum into a 1-D spectrum (as you have pointed out). And when you construct a 2-D spectrum from 1-D, you must provide a peak direction (as well as a spreading function).

Maybee it is sufficient to have a 2D spectrum with only a single heading. Will test and get back to this.