Skip to content

feat: use uv for dependency installation in build script #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jxnl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: use uv for dependency installation in build script #1942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions build_mkdocs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
pip install -r requirements.txt
pip install -r requirements-doc.txt
pip install uv
uv pip install -r requirements.txt
uv pip install -r requirements-doc.txt
mkdocs build
Comment on lines +2 to 4
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge MkDocs runs outside uv-installed environment

When this script is invoked from a clean shell (no virtualenv active), uv pip install -r requirements*.txt on lines 2–3 creates a .venv and installs dependencies there by default, but mkdocs build on line 4 is executed with the system interpreter. In that context the MkDocs entrypoint and plugins stay inside the uv-managed venv, so the build fails with mkdocs: command not found or missing modules—something that did not happen with the previous system-level pip install. To keep the docs build working in CI/Cloudflare, the script needs to run MkDocs via the uv environment (e.g., uv run mkdocs build or --system).

Useful? React with 👍 / 👎.

Loading