From 975f75b1d50a0193508278b72aeb50f5d689b4e2 Mon Sep 17 00:00:00 2001 From: AbigailDeng Date: Sat, 17 May 2025 16:42:15 +0800 Subject: [PATCH 1/2] feat: fix load fatal: no private-key --- src/command/baseSubCommand.js | 15 +++++++++------ src/utils/constants.js | 2 +- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/command/baseSubCommand.js b/src/command/baseSubCommand.js index 9e0ef64..2353c28 100644 --- a/src/command/baseSubCommand.js +++ b/src/command/baseSubCommand.js @@ -197,7 +197,6 @@ class BaseSubCommand { ...rc, ...uniOptions }); - const globalPrompts = globalOptionsPrompts.filter( prompt => this.validatorDesc[prompt.name]?.required && !options[prompt.name] ); @@ -223,11 +222,15 @@ class BaseSubCommand { } const subOptionsLength = Object.keys(subCommandOptions).length; if (subOptionsLength < this.parameters.length) { - const response = BaseSubCommand.normalizeConfig(await inquirer.prompt(this.parameters.slice(subOptionsLength))); - subCommandOptions = { - ...subCommandOptions, - ...response - }; + try { + const response = BaseSubCommand.normalizeConfig(await inquirer.prompt(this.parameters.slice(subOptionsLength))); + subCommandOptions = { + ...subCommandOptions, + ...response + }; + } catch (e) { + console.error(e); + } } return { localOptions, diff --git a/src/utils/constants.js b/src/utils/constants.js index 8304b45..5c901d0 100644 --- a/src/utils/constants.js +++ b/src/utils/constants.js @@ -261,7 +261,7 @@ const loadCommandParameters = [ inactive: 'no', suffix: '?', when(answers) { - return answers['private-key'].trim().split(' ').length > 1; + return answers['private-key']?.trim().split(' ').length > 1; } }, { From c31507acc470250c8291c771ee8e12a5cdc9da84 Mon Sep 17 00:00:00 2001 From: AbigailDeng Date: Sat, 17 May 2025 16:46:26 +0800 Subject: [PATCH 2/2] feat: fix setup-node version --- .github/workflows/coverage.yml | 4 ++-- package.json | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index f1c2b57..0ed6fa1 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -14,9 +14,9 @@ jobs: uses: actions/checkout@v3 - name: Set up Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '18' + node-version: '20' - name: Install dependencies run: yarn install diff --git a/package.json b/package.json index 124d65c..7d48f17 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "aelf-command", - "version": "0.1.52", + "version": "0.1.53", "description": "A CLI tools for AElf", "main": "src/index.js", "type": "module", @@ -115,4 +115,4 @@ "path": "./node_modules/cz-conventional-changelog" } } -} +} \ No newline at end of file