Skip to content

Add "TableDataAccessRequiresPermissions" to ApplicationCop #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arthurvdv wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add "TableDataAccessRequiresPermissions" to ApplicationCop #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66bad3c
Add "Xml Documentation" to DocumentationCop
Arthurvdv Feb 1, 2026
878b50f
Add "TableDataAccessRequiresPermissions" to ApplicationCop
Arthurvdv Feb 2, 2026
6eb3909
Merge branch 'main' into TableDataAccessRequiresPermissions
Arthurvdv Feb 2, 2026
9779b58
Refactor TableDataAccessRequiresPermissions analyzer and add version …
Arthurvdv Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions ...licationCop.Test/Rules/TableDataAccessRequiresPermissions/HasDiagnostic/ProcedureCalls.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
codeunit 50000 MyCodeunit
{

trigger OnRun()
var
MyTable: Record MyTable;
begin
// read
[|MyTable.Find();|]
[|MyTable.FindFirst();|]
[|MyTable.FindLast();|]
[|MyTable.FindSet();|]
[|MyTable.Get(1);|]
[|if MyTable.IsEmpty() then;|]

// insert
[|MyTable.Insert();|]

// modify
[|MyTable.Modify();|]
[|MyTable.ModifyAll(MyField2, 2);|]
[|MyTable.Rename(1);|]

// delete
[|MyTable.Delete();|]
[|MyTable.DeleteAll();|]
end;
}

table 50000 MyTable
{
Caption = '', Locked = true;

fields
{
field(1; MyField; Integer)
{
Caption = '', Locked = true;
DataClassification = ToBeClassified;
}
field(2; MyField2; Integer)
{
Caption = '', Locked = true;
DataClassification = ToBeClassified;
}
}
}
33 changes: 33 additions & 0 deletions ...ops.ApplicationCop.Test/Rules/TableDataAccessRequiresPermissions/HasDiagnostic/Queries.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
query 50000 MyQuery
{

elements
{
[|dataitem(DataItemName; MyTable)|]
{
column(ColumnName; MyField)
{

}
}
}
}

table 50000 MyTable
{
Caption = '', Locked = true;

fields
{
field(1; MyField; Integer)
{
Caption = '', Locked = true;
DataClassification = ToBeClassified;
}
field(2; MyField2; Integer)
{
Caption = '', Locked = true;
DataClassification = ToBeClassified;
}
}
}
34 changes: 34 additions & 0 deletions ...ops.ApplicationCop.Test/Rules/TableDataAccessRequiresPermissions/HasDiagnostic/Reports.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
report 50000 MyReport
{
ProcessingOnly = true;

dataset
{
[|dataitem(DataItemName; MyTable)|]
{
column(ColumnName; MyField)
{

}
}
}
}

table 50000 MyTable
{
Caption = '', Locked = true;

fields
{
field(1; MyField; Integer)
{
Caption = '', Locked = true;
DataClassification = ToBeClassified;
}
field(2; MyField2; Integer)
{
Caption = '', Locked = true;
DataClassification = ToBeClassified;
}
}
}
93 changes: 93 additions & 0 deletions ...ps.ApplicationCop.Test/Rules/TableDataAccessRequiresPermissions/HasDiagnostic/XmlPorts.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
xmlport 50000 MyXmlport
{
Direction = Import;
Permissions = tabledata MyTable = r;

schema
{
textelement(NodeName1)
{
[|tableelement(NodeName2; MyTable)|]
{
fieldattribute(NodeName3; NodeName2.MyField2)
{

}
}
}
}
}
xmlport 50001 MyXmlport2
{
Direction = Export;
Permissions = tabledata MyTable = m;

schema
{
textelement(NodeName1)
{
[|tableelement(NodeName2; MyTable)|]
{
fieldattribute(NodeName3; NodeName2.MyField2)
{

}
}
}
}
}
xmlport 50002 MyXmlport3
{
Direction = Both;

schema
{
textelement(NodeName1)
{
[|tableelement(NodeName2; MyTable)|]
{
fieldattribute(NodeName3; NodeName2.MyField2)
{

}
}
}
}
}

xmlport 50003 MyXmlport4
{

schema
{
textelement(NodeName1)
{
[|tableelement(NodeName2; MyTable)|]
{
fieldattribute(NodeName3; NodeName2.MyField2)
{

}
}
}
}
}

table 50000 MyTable
{
Caption = '', Locked = true;

fields
{
field(1; MyField; Integer)
{
Caption = '', Locked = true;
DataClassification = ToBeClassified;
}
field(2; MyField2; Integer)
{
Caption = '', Locked = true;
DataClassification = ToBeClassified;
}
}
}
10 changes: 10 additions & 0 deletions ...ApplicationCop.Test/Rules/TableDataAccessRequiresPermissions/NoDiagnostic/IntegerTable.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
codeunit 50000 MyCodeunit
{
trigger OnRun()
var
Integer: Record Integer;
begin
[|Integer.FindFirst();|]
end;
}

31 changes: 31 additions & 0 deletions ...Rules/TableDataAccessRequiresPermissions/NoDiagnostic/MultiplePermissionsDifferentType.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
codeunit 50000 Test
{
Permissions =
tabledata MyTableOne = r,
tabledata MyTableTwo = i;

procedure Test()
var
MyTableOne: Record MyTableOne;
MyTableTwo: Record MyTableTwo;
begin
[|MyTableOne.FindFirst();|]
[|MyTableTwo.Insert();|]
end;
}

table 50000 MyTableOne
{
fields
{
field(1; MyField; Integer) { }
}
}

table 50001 MyTableTwo
{
fields
{
field(1; MyField; Integer) { }
}
}
25 changes: 25 additions & 0 deletions ...op.Test/Rules/TableDataAccessRequiresPermissions/NoDiagnostic/PageExtensionSourceTable.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
pageextension 50000 MyPageExtension extends MyPage
{
trigger OnOpenPage()
var
MyTable: Record MyTable;
begin
[|MyTable.FindFirst();|]
[|MyTable.Insert();|]
[|MyTable.Modify();|]
[|MyTable.Delete();|]
end;
}

page 50000 MyPage
{
SourceTable = MyTable;
}

table 50000 MyTable
{
fields
{
field(1; MyField; Integer) { }
}
}
52 changes: 52 additions & 0 deletions ...licationCop.Test/Rules/TableDataAccessRequiresPermissions/NoDiagnostic/PageSourceTable.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
page 50000 MyPage
{
PageType = Card;
ApplicationArea = All;
UsageCategory = Administration;
SourceTable = MyTable;

layout
{
area(Content)
{
group(GroupName)
{
field(Name; MyField)
{
ApplicationArea = All;

}
}
}
}

trigger OnOpenPage()
var
MyTable: Record MyTable;
begin
[|Rec.FindFirst();|]
[|MyTable.FindFirst();|]
[|MyTable.Insert();|]
[|MyTable.Modify();|]
[|MyTable.Delete();|]
end;
}

table 50000 MyTable
{
Caption = '', Locked = true;

fields
{
field(1; MyField; Integer)
{
Caption = '', Locked = true;
DataClassification = ToBeClassified;
}
field(2; MyField2; Integer)
{
Caption = '', Locked = true;
DataClassification = ToBeClassified;
}
}
}
32 changes: 32 additions & 0 deletions ...st/Rules/TableDataAccessRequiresPermissions/NoDiagnostic/PermissionPropertyWithComment.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
codeunit 50000 CommentTestCodeunit
{
Permissions =
tabledata MyTableOne = r,
// single line comment
tabledata MyTableTwo = r;

trigger OnRun()
var
MyTableOne: Record MyTableOne;
MyTableTwo: Record MyTableTwo;
begin
MyTableOne.FindFirst();
[|MyTableTwo.FindFirst();|]
end;
}

table 50000 MyTableOne
{
fields
{
field(1; MyField; Integer) { }
}
}

table 50001 MyTableTwo
{
fields
{
field(1; MyField; Integer) { }
}
}
Loading
Loading