Merge branch 'topic/als.1193.is_called_by.child_library_procedure' into 'master'

Improve node returns by prepareCallHierarchy

See merge request eng/ide/ada_language_server!1410

Author: AdrienBoulanger

source/ada/lsp-ada_handlers.adb

@@ -3351,7 +3351,6 @@ package body LSP.Ada_Handlers is
             Call_Hierarchy.Find_Incoming_Calls
               (Self, Response, Filter, C, Definition);
          end if;
-
       end Process_Context;
 
    begin
@@ -3751,14 +3750,21 @@ package body LSP.Ada_Handlers is
                Node : constant Libadalang.Analysis.Defining_Name :=
                  Decl.P_Defining_Name;
 
+               --  In case the Defining_Name is a Dotted_Name then we need
+               --  to point to the func which is the last.
                Location : constant LSP.Structures.Location :=
-                 Self.To_LSP_Location (Node);
+                 Self.To_LSP_Location
+                   (if Node.First_Child.Kind
+                       in Libadalang.Common.Ada_Dotted_Name_Range
+                    then Node.First_Child.As_Dotted_Name.F_Suffix
+                    else Node);
 
                Item : constant LSP.Structures.CallHierarchyItem :=
                  (name           => VSS.Strings.To_Virtual_String (Node.Text),
                   kind           => Utils.Get_Decl_Kind (Decl),
                   tags           => <>,
-                  detail         => Utils.Node_Location_Image (Node),
+                  detail         =>
+                    Utils.Node_Location_Image (Node),
                   uri            => Location.uri,
                   a_range        => Span,
                   selectionRange => Location.a_range,

testsuite/ada_lsp/called_by.subunit/src/main.adb

@@ -0,0 +1,7 @@
+with Root.Child;
+with Root.Child.Do_Something;
+procedure Main is
+begin
+   Root.Child.Do_Something;
+   Root.Child.Hello;
+end Main;

testsuite/ada_lsp/called_by.subunit/src/root-child-do_something.adb

@@ -0,0 +1,4 @@
+procedure Root.Child.Do_Something is
+begin
+   null;
+end Root.Child.Do_Something;

testsuite/ada_lsp/called_by.subunit/src/root-child.ads

@@ -0,0 +1,5 @@
+package Root.Child is
+
+   procedure Hello is null;
+
+end Root.Child;

testsuite/ada_lsp/called_by.subunit/src/root.ads

@@ -0,0 +1,3 @@
+package Root is
+
+end Root;

testsuite/ada_lsp/called_by.subunit/test.gpr

@@ -0,0 +1,4 @@
+project Test is
+    for Source_Dirs use ("src");
+    for Main use ("main.adb");
+end Test;