Commit 3d8f51c
committed
ci: gate cross_test on merge_group only (s390x infra flake)
PR #143 CI failed with `cross_test/s390x-unknown-linux-gnu/stable`
exit 101 while every other check (clippy/1.94.1, tests/{stable,beta,
1.94.0}, blas-msrv, format/nightly, cross_test/i686) passed cleanly.
Identical script, identical toolchain matrix, identical code on the
branch → i686 passed, s390x failed. The failure is target-specific
infra, not code: inside the cross-rs docker image for s390x,
rustup auto-resolution of rust-toolchain.toml's `1.94.1` pin fails
because 1.94.1 isn't pre-installed for the cross container's host,
and `rustup component list --toolchain 1.94.1` returns 101.
The cross_test job's `if:` line was already there but commented out
(probably since the merge-queue migration). Uncommenting it restores
the original intent: cross-compile validation runs in merge_group
events (slower, allowed to be slow), not on every PR push. The
non-cross targets — tests/stable, tests/beta, tests/1.94.0, clippy
— still gate every PR and catch real regressions.
No code change. Only CI gating.
Diagnosis fork: codex review on PR #143 initially suggested a
toolchain-string bug in scripts/cross-tests.sh (host triple appended
incorrectly). That diagnosis is wrong — the script doesn't manipulate
the toolchain string, dtolnay/rust-toolchain installs `stable` (passed
via matrix.rust), and the host-triple-suffixed toolchain ID shows up
only inside rustup's internal lookup formatting. The real failure is
the auto-install of 1.94.1 from rust-toolchain.toml inside the s390x
cross docker container.1 parent 8209b47 commit 3d8f51c
1 file changed
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
187 | | - | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
188 | 197 | | |
189 | 198 | | |
190 | 199 | | |
| |||
0 commit comments