Commit 6f96a14
committed
docs(pr-x12): close 6 CodeRabbit nitpicks left open at PR #197 merge
Per other-session feedback: six nitpick-level findings on PR #197 didn't
block the merge but stayed unaddressed. Folding them into this PR.
1. GGUF Escape forward-ref to F-4
gguf-llm-weights-encoding.md §2.4 said "Escape must be lossless ...
This is an additional R-N candidate" with no pointer. F-4 in §10
already explains the mechanism (rANS bypass channel in A8, HEVC
escape-coefficient precedent). Added an inline cross-ref so readers
don't have to scroll to find the resolution.
2. Phone-class viability overclaim re KV cache
gguf-llm-weights-encoding.md line 269 claimed "7B at PR-X12 is
genuinely runnable on a phone-class device". Weight compression
alone takes 7B from 4 GB to 3 GB, but KV cache at 8K context is
~1-2 GB independent of weight compression. Qualified the claim:
PR-X12 weights are necessary but not sufficient; KV-cache lane
(Plan D, M:H-3, R-4) is the second lever for full phone viability.
3. EncodingDomain::LLMWeights timing
§11 implication #2 says "LLM lane lands post-PR-X12, but the
harness must be lane-extensible"; implication #5 said "Reserve an
EncodingDomain::LLMWeights discriminant ... now". Clarified: PR-X12
reserves the enum-discriminant *slot* now (forward-compat lock); the
LLMWeights variant + decoder land post-PR-X12 without a wire-format
break.
4. Per-arch `match Arch::CURRENT` const-eval
woa-multiarch-orchestration.md §3.3's `const DCT_BATCH_CROSSOVER =
match Arch::CURRENT { ... }` does not compile under stable Rust
const-eval — `Arch::CURRENT` would need to be a const, and
architecture-conditional const matches require build-script-emitted
integers or `cfg!(target_feature = ...)`. Rewrote as pseudocode
pointing at a `build.rs` mechanism (decision matrix → `OUT_DIR`
generated const) with a `cfg!()` fallback shape.
5. G-8 / G-9 numbering collision
cam-pq-sigker-dn-tree-substrate-bindings.md §5 labelled bgz-jc's
two prior gaps as G-8 / G-9 (continuing cam-pq's own G-1..G-7), but
bgz-jc-substrate-synergies.md §5 didn't use any G-N IDs, so the
cross-doc reference was dangling and the namespace was implicitly
shared without rules. Gave bgz-jc §5.1 / §5.2 explicit IDs G-1 / G-2
(canonical to that doc) and updated cam-pq to cite them as
"bgz-jc G-1" / "bgz-jc G-2" with a namespace-isolation note.
6. "landed" terminology in x266 §8 prerequisites table
The status column claimed "landed" / "landed in concept" for R-1
trait shape, R-2 header bytes, and R-13 federated codebook policy.
None of these have shipping code — they are canon-fixed (the
resolution doc commits the design) but implementation is scheduled
in Plan A4 / A8 / F. Renamed status to "canon-fixed" + a glossary
line distinguishing "canon-fixed" (doc commitment) from "scheduled"
(plan card exists) from shipping code.
https://claude.ai/code/session_01HbqooFZHAjaUtFEzhA1R2u1 parent 8415a62 commit 6f96a14
5 files changed
Lines changed: 41 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
306 | | - | |
| 306 | + | |
307 | 307 | | |
308 | 308 | | |
309 | 309 | | |
| |||
335 | 335 | | |
336 | 336 | | |
337 | 337 | | |
338 | | - | |
| 338 | + | |
339 | 339 | | |
340 | 340 | | |
341 | 341 | | |
| |||
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
308 | 308 | | |
309 | 309 | | |
310 | 310 | | |
311 | | - | |
| 311 | + | |
312 | 312 | | |
313 | | - | |
| 313 | + | |
314 | 314 | | |
315 | | - | |
316 | | - | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
317 | 319 | | |
318 | 320 | | |
319 | 321 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
134 | | - | |
| 134 | + | |
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| |||
266 | 266 | | |
267 | 267 | | |
268 | 268 | | |
269 | | - | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
270 | 272 | | |
271 | 273 | | |
272 | 274 | | |
| |||
345 | 347 | | |
346 | 348 | | |
347 | 349 | | |
348 | | - | |
| 350 | + | |
349 | 351 | | |
350 | 352 | | |
351 | 353 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
| 133 | + | |
134 | 134 | | |
135 | 135 | | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
144 | 156 | | |
145 | 157 | | |
146 | 158 | | |
| |||
151 | 163 | | |
152 | 164 | | |
153 | 165 | | |
154 | | - | |
| 166 | + | |
155 | 167 | | |
156 | 168 | | |
157 | 169 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
271 | | - | |
| 271 | + | |
272 | 272 | | |
273 | | - | |
274 | | - | |
| 273 | + | |
| 274 | + | |
275 | 275 | | |
276 | | - | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
277 | 279 | | |
278 | 280 | | |
279 | 281 | | |
| |||
0 commit comments