Fixes tests to complete 100% code coverage for CommonUtiliriesCSharp.UnitTests

Author: AdmirableTable

CommonUtilitiesCSharp.UnitTests/Core/CommandTests.cs

@@ -18,8 +18,9 @@ public void Constructor_Throws_ForNullExecute()
         [Test]
         public void Constructor_Throws_ForNullCanExecute()
         {
-            static void execute(TCommandParameter? param) { }
+            static void execute(TCommandParameter? param) { throw new NotSupportedException(); }
 
+            Assert.Throws<NotSupportedException>(() => execute(default));
             Assert.Throws<ArgumentNullException>(() => CreateCommand(execute, null!));
         }
 
@@ -28,6 +29,7 @@ public void Constructor_Throws_ForNullExecuteWithPredicate()
         {
             static bool canExecute(TCommandParameter? param) { throw new NotSupportedException(); }
 
+            Assert.Throws<NotSupportedException>(() => canExecute(default));
             Assert.Throws<ArgumentNullException>(() => CreateCommand(null!, canExecute));
         }
         #endregion Constructor
@@ -160,6 +162,7 @@ public override void Execute_IsInvokedWithParameter_WhenParameterIsPassedAndPred
         #endregion Execute
 
         #region CanExecute
+        [Test]
         public override void CanExecute_ReturnsTrue_WhenThereIsNoPredicate()
         {
             var command = CreateCommand(parameter => { });
@@ -326,6 +329,7 @@ public override void Execute_IsInvokedWithParameter_WhenParameterIsPassedAndPred
         #endregion Execute
 
         #region CanExecute
+        [Test]
         public override void CanExecute_ReturnsTrue_WhenThereIsNoPredicate()
         {
             var command = CreateCommand(parameter => { });

CommonUtilitiesCSharp.UnitTests/Core/ObservableObjectTests.cs

@@ -51,8 +51,12 @@ public void OnPropertyChanged_CanBeOverriden()
             Assert.That(mockObject.HasPropertyChangedBeenCalled, Is.False);
 
             mockObject.Value = "test2";
-
-            Assert.That(mockObject.HasPropertyChangedBeenCalled, Is.True);
+            
+            Assert.Multiple(() =>
+            {
+                Assert.That(mockObject.Value, Is.EqualTo("test2"));
+                Assert.That(mockObject.HasPropertyChangedBeenCalled, Is.True);
+            });
         }
 
         [Test]
@@ -94,6 +98,7 @@ public void OnPropertyChanged_RaisesPropertyChangedEvent_WhenInvokedWithName()
 
             Assert.Multiple(() =>
             {
+                Assert.That(mockObject.IndirectValue, Is.EqualTo("test2"));
                 Assert.That(propertiesChanged, Has.Count.EqualTo(2));
                 Assert.That(propertiesChanged[0], Is.EqualTo(nameof(MockObservableObject.IndirectValue)));
                 Assert.That(propertiesChanged[1], Is.EqualTo(nameof(MockObservableObject.Value)));

CommonUtilitiesCSharp.UnitTests/Extensions/IEnumerableExtensionTests.cs

@@ -4,78 +4,56 @@ namespace CommonUtilitiesCSharp.UnitTests.Extensions
 {
     public class IEnumerableExtensionTests
     {
-        private class MockObject
-        {
-            public MockObject(string value)
-            {
-                Value = value;
-            }
-
-            public string? Value { get; set; }
-
-            public override bool Equals(object? obj)
-            {
-                return obj is MockObject @object && Equals(@object);
-            }
-
-            public bool Equals(MockObject? obj)
-            {
-                return obj != null &&
-                       Value == obj.Value;
-            }
-
-            public override int GetHashCode()
-            {
-                return nameof(MockObject).GetHashCode() * ((Value?.GetHashCode() ?? -1) + 7);
-            }
-        }
-
         #region ForEach
         [Test]
         public void ForEach_ExecutesActionOnAllItems_ForMultipleItems()
         {
-            var items = new MockObject[] { new("a"), new("b"), new("c") };
+            var items = new int[] { 1, 2, 3 };
+            var result = new List<int>();
 
-            items.ForEach(item => item.Value += ".");
+            items.ForEach(item => result.Add(item + 1));
 
-            Assert.That(items, Is.EquivalentTo(new MockObject[] { new("a."), new("b."), new("c.") }));
+            Assert.That(result, Is.EquivalentTo(new int[] { 2, 3, 4 }));
         }
 
         [Test]
         public void ForEach_ExecutesActionOnAllItems_ForSingleItem()
         {
-            var items = new MockObject[] { new("a") };
+            var items = new int[] { 1 };
+            var result = new List<int>();
 
-            items.ForEach(item => item.Value += ".");
+            items.ForEach(item => result.Add(item + 1));
 
-            Assert.That(items, Is.EquivalentTo(new MockObject[] { new("a.") }));
+            Assert.That(result, Is.EquivalentTo(new int[] { 2 }));
         }
 
         [Test]
         public void ForEach_ExecutesActionOnAllItems_ForZeroItems()
         {
-            var items = Array.Empty<MockObject>();
+            var items = Array.Empty<int>();
+            var result = new List<int>();
 
-            items.ForEach(item => item.Value += ".");
+            items.ForEach(item => result.Add(item + 1));
 
-            Assert.That(items, Is.EquivalentTo(Array.Empty<MockObject>()));
+            Assert.That(result, Is.EquivalentTo(Array.Empty<int>()));
         }
 
         [Test]
         public void ForEach_ThrowsArgumentNullException_ForNullEnumerable()
         {
-            IEnumerable<string> items = null!;
+            IEnumerable<int> items = null!;
+            var result = new List<int>();
 
-            Assert.Throws<ArgumentNullException>(() => items.ForEach(item => item += "."));
+            Assert.Throws<ArgumentNullException>(() => items.ForEach(item => result.Add(item + 1)));
         }
 
         [Test]
         public void ForEach_ThrowsArgumentNullException_ForNullAction()
         {
-            var items = new string[] { "a", "b", "c" };
+            var items = new int[] { 1, 2, 3 };
 
             Assert.Throws<ArgumentNullException>(() => items.ForEach(null!));
         }
         #endregion ForEach
     }
-}
+}