Skip to content

Commit f5e440b

Browse files
committed
GPU TPC: Fix typo in name, and clean up setting of inputGPU struct
1 parent 64077ed commit f5e440b

File tree

3 files changed

+4
-34
lines changed

3 files changed

+4
-34
lines changed

DataFormats/Detectors/TPC/include/DataFormatsTPC/CompressedClusters.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ struct CompressedClustersCounters {
2929
unsigned int nUnattachedClusters = 0;
3030
unsigned int nAttachedClustersReduced = 0;
3131
unsigned int nSliceRows = 36 * 152;
32-
unsigned char nComppressionModes = 0;
32+
unsigned char nComppressionModes = 0; // Don't fix this name due to ROOT dictionaries!
3333
float solenoidBz = -1e6f;
3434
int maxTimeBin = -1e6;
3535

GPU/GPUTracking/DataCompression/GPUTPCDecompression.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ void GPUTPCDecompression::SetPointersCompressedClusters(void*& mem, T& c, uint32
4343

4444
uint32_t nClAreduced = reducedClA ? nClA - nTr : nClA;
4545

46-
if (!(mRec->GetParam().rec.tpc.compressionTypeMask & GPUSettings::CompressionTrackModel)) {
46+
if (!(c.nComppressionModes & GPUSettings::CompressionTrackModel)) {
4747
return; // Track model disabled, do not allocate memory
4848
}
4949
computePointerWithAlignment(mem, c.qTotA, nClA);

GPU/GPUTracking/Global/GPUChainTrackingCompression.cxx

Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -254,40 +254,10 @@ int32_t GPUChainTracking::RunTPCDecompression()
254254

255255
int32_t inputStream = 0;
256256
int32_t unattachedStream = mRec->NStreams() - 1;
257-
inputGPU.nAttachedClusters = cmprClsHost.nAttachedClusters;
258-
inputGPU.nUnattachedClusters = cmprClsHost.nUnattachedClusters;
259-
inputGPU.nTracks = cmprClsHost.nTracks;
260-
inputGPU.nAttachedClustersReduced = inputGPU.nAttachedClusters - inputGPU.nTracks;
261-
inputGPU.nSliceRows = NSLICES * GPUCA_ROW_COUNT;
262-
inputGPU.nComppressionModes = param().rec.tpc.compressionTypeMask;
263-
inputGPU.solenoidBz = param().bzkG;
264-
inputGPU.maxTimeBin = param().continuousMaxTimeBin;
257+
inputGPU = cmprClsHost;
265258
SetupGPUProcessor(&Decompressor, true);
266259
WriteToConstantMemory(myStep, (char*)&processors()->tpcDecompressor - (char*)processors(), &DecompressorShadow, sizeof(DecompressorShadow), inputStream);
267-
268-
inputGPU.nTrackClusters = cmprClsHost.nTrackClusters;
269-
inputGPU.qTotU = cmprClsHost.qTotU;
270-
inputGPU.qMaxU = cmprClsHost.qMaxU;
271-
inputGPU.flagsU = cmprClsHost.flagsU;
272-
inputGPU.padDiffU = cmprClsHost.padDiffU;
273-
inputGPU.timeDiffU = cmprClsHost.timeDiffU;
274-
inputGPU.sigmaPadU = cmprClsHost.sigmaPadU;
275-
inputGPU.sigmaTimeU = cmprClsHost.sigmaTimeU;
276-
inputGPU.nSliceRowClusters = cmprClsHost.nSliceRowClusters;
277-
inputGPU.qTotA = cmprClsHost.qTotA;
278-
inputGPU.qMaxA = cmprClsHost.qMaxA;
279-
inputGPU.flagsA = cmprClsHost.flagsA;
280-
inputGPU.rowDiffA = cmprClsHost.rowDiffA;
281-
inputGPU.sliceLegDiffA = cmprClsHost.sliceLegDiffA;
282-
inputGPU.padResA = cmprClsHost.padResA;
283-
inputGPU.timeResA = cmprClsHost.timeResA;
284-
inputGPU.sigmaPadA = cmprClsHost.sigmaPadA;
285-
inputGPU.sigmaTimeA = cmprClsHost.sigmaTimeA;
286-
inputGPU.qPtA = cmprClsHost.qPtA;
287-
inputGPU.rowA = cmprClsHost.rowA;
288-
inputGPU.sliceA = cmprClsHost.sliceA;
289-
inputGPU.timeA = cmprClsHost.timeA;
290-
inputGPU.padA = cmprClsHost.padA;
260+
inputGPU = cmprClsHost;
291261

292262
bool toGPU = true;
293263
runKernel<GPUMemClean16>({GetGridAutoStep(inputStream, RecoStep::TPCDecompression), krnlRunRangeNone, &mEvents->init}, DecompressorShadow.mNativeClustersIndex, NSLICES * GPUCA_ROW_COUNT * sizeof(DecompressorShadow.mNativeClustersIndex[0]));

0 commit comments

Comments
 (0)