From 0f2f7b7e03571c36ff70132c2c53896761b03aab Mon Sep 17 00:00:00 2001 From: Isaac Hill <71404865+isaachilly@users.noreply.github.com> Date: Thu, 8 Jan 2026 10:52:40 +0100 Subject: [PATCH 1/2] [O2B-1521] Add pagination to QcFlagsForDataPass Integrated the paginationComponent into QcFlagsForDataPassOverviewPage and passed the pagination model to the view. WITHOUT tests. --- .../QcFlags/ForDataPass/QcFlagsForDataPassOverviewPage.js | 3 +++ lib/public/views/QcFlags/Overview/QcFlagsOverviewModel.js | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/public/views/QcFlags/ForDataPass/QcFlagsForDataPassOverviewPage.js b/lib/public/views/QcFlags/ForDataPass/QcFlagsForDataPassOverviewPage.js index 3a16b2cb41..1d2ae35850 100644 --- a/lib/public/views/QcFlags/ForDataPass/QcFlagsForDataPassOverviewPage.js +++ b/lib/public/views/QcFlags/ForDataPass/QcFlagsForDataPassOverviewPage.js @@ -24,6 +24,7 @@ import { qcFlagsBreadcrumbs } from '../../../components/qcFlags/qcFlagsBreadcrum import errorAlert from '../../../components/common/errorAlert.js'; import spinner from '../../../components/common/spinner.js'; import { remoteDplDetectorUserHasAccessTo } from '../../../services/detectors/remoteDplDetectorUserHasAccessTo.js'; +import { paginationComponent } from '../../../components/Pagination/paginationComponent.js'; const TABLEROW_HEIGHT = 35; // Estimate of the navbar and pagination elements height total; Needs to be updated in case of changes; @@ -45,6 +46,7 @@ export const QcFlagsForDataPassOverviewPage = ({ dplDetector: remoteDplDetector, items: remoteQcFlags, sortModel, + pagination: paginationModel, } = qcFlagsForDataPassOverviewModel; qcFlagsForDataPassOverviewModel.pagination.provideDefaultItemsPerPage(estimateDisplayableRowsCount( @@ -101,6 +103,7 @@ export const QcFlagsForDataPassOverviewPage = ({ null, { sort: sortModel }, ), + paginationComponent(paginationModel), ]), ], Loading: () => spinner(), diff --git a/lib/public/views/QcFlags/Overview/QcFlagsOverviewModel.js b/lib/public/views/QcFlags/Overview/QcFlagsOverviewModel.js index 0758d5fa9c..1e0d373e12 100644 --- a/lib/public/views/QcFlags/Overview/QcFlagsOverviewModel.js +++ b/lib/public/views/QcFlags/Overview/QcFlagsOverviewModel.js @@ -49,8 +49,8 @@ export class QcFlagsOverviewModel extends OverviewPageModel { /** * @inheritdoc */ - getLoadParameters() { - return {}; + async getLoadParameters() { + return await super.getLoadParameters(); } /** From 3b0a6597b705a77941cb4673c7d09467f14e2564 Mon Sep 17 00:00:00 2001 From: Isaac Hill <71404865+isaachilly@users.noreply.github.com> Date: Thu, 8 Jan 2026 12:34:24 +0100 Subject: [PATCH 2/2] [O2B-1521] Remove redundant getLoadParameters override Removed as only called the superclass implementation without modification. --- lib/public/views/QcFlags/Overview/QcFlagsOverviewModel.js | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/public/views/QcFlags/Overview/QcFlagsOverviewModel.js b/lib/public/views/QcFlags/Overview/QcFlagsOverviewModel.js index 1e0d373e12..5eaa5d58f0 100644 --- a/lib/public/views/QcFlags/Overview/QcFlagsOverviewModel.js +++ b/lib/public/views/QcFlags/Overview/QcFlagsOverviewModel.js @@ -46,13 +46,6 @@ export class QcFlagsOverviewModel extends OverviewPageModel { super.load(); } - /** - * @inheritdoc - */ - async getLoadParameters() { - return await super.getLoadParameters(); - } - /** * Fetch DPL detector which QC flags should be fetched * @return {void}