[core] Implement GetEnvironmentsShortData for all plugins

Author: teo

core/integration/bookkeeping/plugin.go

@@ -287,6 +287,10 @@ func (p *Plugin) GetEnvironmentsData(envIds []uid.ID) map[uid.ID]string {
 	return out
 }
 
+func (p *Plugin) GetEnvironmentsShortData(envIds []uid.ID) map[uid.ID]string {
+	return p.GetEnvironmentsData(envIds)
+}
+
 /*************************************/
 // Initialize the Bookkeeping client //
 /*************************************/

core/integration/ccdb/plugin.go

@@ -325,6 +325,10 @@ func (p *Plugin) GetEnvironmentsData(_ []uid.ID) map[uid.ID]string {
 	return nil
 }
 
+func (p *Plugin) GetEnvironmentsShortData(_ []uid.ID) map[uid.ID]string {
+	return nil
+}
+
 func (p *Plugin) Init(instanceId string) error {
 	return nil
 }

core/integration/dcs/plugin.go

@@ -129,6 +129,10 @@ func (p *Plugin) GetEnvironmentsData(environmentIds []uid.ID) map[uid.ID]string
 	return out
 }
 
+func (p *Plugin) GetEnvironmentsShortData(environmentIds []uid.ID) map[uid.ID]string {
+	return p.GetEnvironmentsData(environmentIds)
+}
+
 func (p *Plugin) partitionStatesForEnvs(envIds []uid.ID) map[uid.ID]string {
 	out := make(map[uid.ID]string)
 	for _, envId := range envIds {

core/integration/ddsched/plugin.go

@@ -150,6 +150,10 @@ func (p *Plugin) GetEnvironmentsData(envIds []uid.ID) map[uid.ID]string {
 	return partitionInfosOut
 }
 
+func (p *Plugin) GetEnvironmentsShortData(envIds []uid.ID) map[uid.ID]string {
+	return p.GetEnvironmentsData(envIds)
+}
+
 func (p *Plugin) partitionStatesForEnvs(envIds []uid.ID) map[uid.ID]map[string]string {
 	partitionStates := make(map[uid.ID]map[string]string)
 

core/integration/kafka/plugin.go

@@ -100,6 +100,10 @@ func (p *Plugin) GetEnvironmentsData(_ []uid.ID) map[uid.ID]string {
 	return nil
 }
 
+func (p *Plugin) GetEnvironmentsShortData(_ []uid.ID) map[uid.ID]string {
+	return nil
+}
+
 func (p *Plugin) FSMEnterStateTopic(state string) string {
 	return "aliecs.env_state." + state
 }

core/integration/odc/plugin.go

@@ -332,6 +332,37 @@ func (p *Plugin) GetEnvironmentsData(envIds []uid.ID) map[uid.ID]string {
 	return out
 }
 
+func (p *Plugin) GetEnvironmentsShortData(envIds []uid.ID) map[uid.ID]string {
+	if p == nil || p.odcClient == nil {
+		return nil
+	}
+
+	p.cachedStatusMu.RLock()
+	defer p.cachedStatusMu.RUnlock()
+
+	if p.cachedStatus == nil {
+		return nil
+	}
+
+	out := make(map[uid.ID]string)
+	for _, id := range envIds {
+		partitionInfo, ok := p.cachedStatus.Partitions[id]
+		if !ok {
+			continue
+		}
+
+		partitionInfo.Devices = nil // don't return the full devices payload
+
+		partitionInfoOut, err := json.Marshal(partitionInfo)
+		if err != nil {
+			continue
+		}
+		out[id] = string(partitionInfoOut[:])
+	}
+
+	return out
+}
+
 func getFlpIdList(varStack map[string]string) (flps []string, err error) {
 	payload, ok := varStack["hosts"]
 	if !ok {

core/integration/plugin.go

@@ -52,6 +52,7 @@ type Plugin interface {
 	GetConnectionState() string
 	GetData(argv []any) string
 	GetEnvironmentsData(envIds []uid.ID) map[uid.ID]string
+	GetEnvironmentsShortData(envIds []uid.ID) map[uid.ID]string
 
 	Init(instanceId string) error
 	CallStack(data interface{}) map[string]interface{}                                                // used in hook call context
@@ -161,6 +162,27 @@ func (p Plugins) GetEnvironmentsData(envIds []uid.ID) (data map[uid.ID]map[strin
 	return
 }
 
+func (p Plugins) GetEnvironmentsShortData(envIds []uid.ID) (data map[uid.ID]map[string]string) {
+	data = make(map[uid.ID]map[string]string)
+
+	// First we query each plugin for environment data of all envIds at once
+	pluginEnvData := make(map[ /*plugin*/ string]map[uid.ID]string)
+	for _, plugin := range p {
+		pluginEnvData[plugin.GetName()] = plugin.GetEnvironmentsShortData(envIds)
+	}
+
+	// Then we invert the nested map to get a map of envId -> plugin -> data
+	for _, plugin := range p {
+		for envId, pluginData := range pluginEnvData[plugin.GetName()] {
+			if _, ok := data[envId]; !ok {
+				data[envId] = make(map[string]string)
+			}
+			data[envId][plugin.GetName()] = pluginData
+		}
+	}
+	return
+}
+
 func PluginsInstance() Plugins {
 	once.Do(func() {
 		instance = Plugins{}

core/integration/testplugin/plugin.go

@@ -77,6 +77,10 @@ func (p *Plugin) GetEnvironmentsData(_ []uid.ID) map[uid.ID]string {
 	return nil
 }
 
+func (p *Plugin) GetEnvironmentsShortData(_ []uid.ID) map[uid.ID]string {
+	return nil
+}
+
 func (p *Plugin) Init(_ string) error {
 	log.Debug("Test plugin initialized")
 	return nil

core/integration/trg/plugin.go

@@ -236,6 +236,10 @@ func (p *Plugin) GetEnvironmentsData(envIds []uid.ID) map[uid.ID]string {
 	return out
 }
 
+func (p *Plugin) GetEnvironmentsShortData(envIds []uid.ID) map[uid.ID]string {
+	return p.GetEnvironmentsData(envIds)
+}
+
 func (p *Plugin) Init(instanceId string) error {
 	if p.trgClient == nil {
 		callTimeout := TRG_DIAL_TIMEOUT