Skip to content

Commit bcddd69

Browse files
committed
[core] Do not crash when receiving update on nonexistent task
1 parent 91548cb commit bcddd69

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

core/task/manager.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -686,13 +686,14 @@ func (m *Manager) configureTasks(envId uid.ID, tasks Tasks) error {
686686
}
687687

688688
taskDescription = fmt.Sprintf("task '%s' on %s (id %s, name %s) failed with error: %s", tciValue, task.GetHostname(), task.GetTaskId(), task.GetName(), v.Error())
689+
if task.GetTraits().Critical == true || task.parent.GetTaskTraits().Critical == true {
690+
taskCriticalErrors = append(taskCriticalErrors, taskDescription)
691+
} else {
692+
taskNonCriticalErrors = append(taskNonCriticalErrors, taskDescription)
693+
}
689694
} else {
690695
taskDescription = fmt.Sprintf("unknown task (id %s) failed with error: %s", k.TaskId.Value, v.Error())
691-
}
692-
if task.GetTraits().Critical == true || task.parent.GetTaskTraits().Critical == true {
693696
taskCriticalErrors = append(taskCriticalErrors, taskDescription)
694-
} else {
695-
taskNonCriticalErrors = append(taskNonCriticalErrors, taskDescription)
696697
}
697698
i++
698699
}

0 commit comments

Comments
 (0)