[core] Correct scope of local offer

Author: teo

core/task/scheduler.go

@@ -536,10 +536,12 @@ func (state *schedulerState) resourceOffers(fidStore store.Singleton) events.Han
 			var offerWaitGroup sync.WaitGroup
 			offerWaitGroup.Add(len(offers))
 
-			for offerIndex, offer := range offers {
-				go func(offerIndex int, offer *mesos.Offer) {
+			for offerIndex, _ := range offers {
+				go func(offerIndex int) {
 					defer offerWaitGroup.Done()
 
+					offer := offers[offerIndex]
+
 					timeSingleOffer := time.Now()
 					var (
 						remainingResourcesInOffer        = mesos.Resources(offer.Resources)
@@ -697,7 +699,7 @@ func (state *schedulerState) resourceOffers(fidStore store.Singleton) events.Han
 						state.taskman.AgentCache.Update(agentForCache) //thread safe
 						machinesUsed[offer.Hostname] = struct{}{}
 
-						taskPtr := state.taskman.newTaskForMesosOffer(offer, descriptor, bindMap, targetExecutorId)
+						taskPtr := state.taskman.newTaskForMesosOffer(&offer, descriptor, bindMap, targetExecutorId)
 						if taskPtr == nil {
 							log.WithPrefix("scheduler").
 								WithField("partition", envId.String()).
@@ -965,7 +967,7 @@ func (state *schedulerState) resourceOffers(fidStore store.Singleton) events.Han
 						WithField("offers", len(offers)).
 						WithField("offerHost", offer.Hostname))
 
-				}(offerIndex, &offer) // end for offer closure
+				}(offerIndex) // end for offer closure
 			} // end for _, offer := range offers
 			offerWaitGroup.Wait()