grpc: switch to milliseconds-since-epoch for TfBuilder update timestamps

Author: ironMann

src/TfBuilder/TfBuilderRpc.cxx

@@ -212,7 +212,7 @@ bool TfBuilderRpcImpl::sendTfBuilderUpdate()
 
   auto lRet = mTfSchedulerRpcClient.TfBuilderUpdate(lUpdate);
   if (!lRet) {
-    LOG(WARN) << "Sending TfBuilder update failed";
+    LOG(WARN) << "Sending TfBuilder status update failed.";
   }
   return lRet;
 }

src/TfScheduler/TfSchedulerTfBuilderInfo.cxx

@@ -34,8 +34,12 @@ void TfSchedulerTfBuilderInfo::updateTfBuilderInfo(const TfBuilderUpdateMessage
   using namespace std::chrono_literals;
   const auto lLocalTime = std::chrono::system_clock::now();
 
+  // recreate timepoint from the received millisecond time stamp
+  const std::chrono::milliseconds lUpdateDuration(pTfBuilderUpdate.info().last_update_t());
+  const std::chrono::time_point<std::chrono::system_clock> lUpdateTimepoint(lUpdateDuration);
+
   // check for system time drifts; account for gRPC latency
-  const auto lTimeDiff = lLocalTime - std::chrono::system_clock::from_time_t(pTfBuilderUpdate.info().last_update_t());
+  const auto lTimeDiff = lLocalTime - lUpdateTimepoint;
   if (lTimeDiff < 0s || lTimeDiff > 1s) {
     LOG(WARNING) << "Large system clock drift detected: "
                  << std::chrono::duration_cast<std::chrono::milliseconds>(lTimeDiff).count()

src/common/discovery/ConfigConsul.cxx

@@ -62,12 +62,21 @@ std::string to_string(const ProcessTypePB pType) {
   return std::string("UnknownType");
 }
 
-std::tuple<std::string, std::time_t> getCurrentTimeString() {
+// human readable and milliseconds since epoch
+std::tuple<std::string, std::uint64_t> getCurrentTimeString() {
   using namespace std::chrono;
   std::ostringstream ss;
-  const auto lTimet = std::chrono::system_clock::to_time_t(system_clock::now());
+  const auto lNow = system_clock::now();
+
+  // get human readable string
+  const auto lTimet = std::chrono::system_clock::to_time_t(lNow);
   ss << std::put_time(gmtime(&lTimet), "%FT%TZ");
-  return { ss.str(), lTimet };
+
+  // get milliseconds
+  const auto lSinceEpoch = lNow.time_since_epoch();
+  const auto lMillis = std::chrono::duration_cast<std::chrono::milliseconds>(lSinceEpoch).count();
+
+  return { ss.str(), lMillis };
 }
 
 template <>

src/common/include/discovery/ConfigConsul.h

@@ -39,7 +39,7 @@ namespace DataDistribution
 namespace ConsulImpl {
 
 std::string to_string(const ProcessTypePB pType);
-std::tuple<std::string, std::time_t> getCurrentTimeString();
+std::tuple<std::string, std::uint64_t> getCurrentTimeString();
 
 class BasicInfo;
 class PartitionInfo;