clang: fix compile warnings on macos

Author: ironMann

src/ReadoutEmulator/CruEmulator.cxx

@@ -33,7 +33,7 @@ void CruLinkEmulator::linkReadoutThread()
   const auto cSuperpageSize = mMemHandler->getSuperpageSize();
   const auto cHBFrameSize = (mLinkBitsPerS / cHBFrameFreq) >> 3;
   const auto cStfLinkSize = cHBFrameSize * cHBFrameFreq / cStfPerS;
-  const auto cNumDmaChunkPerSuperpage = std::min(size_t(256), cSuperpageSize / mDmaChunkSize);
+  const auto cNumDmaChunkPerSuperpage = std::min(size_t(256), size_t(cSuperpageSize / mDmaChunkSize));
   constexpr int64_t cStfTimeUs = std::chrono::microseconds(1000000 / cStfPerS).count();
 
   LOG(DEBUG) << "Superpage size: " << cSuperpageSize;

src/common/FilePathUtils.cxx

@@ -17,6 +17,7 @@
 #include <regex>
 
 #include <string>
+#include <sstream>
 #include <iomanip>
 #include <chrono>
 

src/common/include/SubTimeFrameDPL.h

@@ -38,6 +38,8 @@ class StfDplAdapter : public ISubTimeFrameVisitor
     mMessages.reserve(1024);
   }
 
+  virtual ~StfDplAdapter() = default;
+
   void sendToDpl(std::unique_ptr<SubTimeFrame>&& pStf);
 
  protected:

src/common/include/SubTimeFrameDataModel.h

@@ -262,7 +262,7 @@ class SubTimeFrame : public IDataModelObject
  public:
   SubTimeFrame(TimeFrameIdType pStfId);
   //SubTimeFrame() = default;
-  ~SubTimeFrame() = default;
+  virtual ~SubTimeFrame() = default;
   // no copy
   SubTimeFrame(const SubTimeFrame&) = delete;
   SubTimeFrame& operator=(const SubTimeFrame&) = delete;

src/common/include/SubTimeFrameFileWriter.h

@@ -40,7 +40,7 @@ class SubTimeFrameFileWriter : public ISubTimeFrameConstVisitor
  public:
   SubTimeFrameFileWriter() = delete;
   SubTimeFrameFileWriter(const boost::filesystem::path& pFileName, bool pWriteInfo = false);
-  ~SubTimeFrameFileWriter();
+  virtual ~SubTimeFrameFileWriter();
 
   ///
   /// Writes a (Sub)TimeFrame

src/common/include/SubTimeFrameVisitors.h

@@ -41,6 +41,8 @@ class InterleavedHdrDataSerializer : public ISubTimeFrameVisitor
     mMessages.reserve(1024);
   }
 
+  virtual ~InterleavedHdrDataSerializer() = default;
+
   void serialize(std::unique_ptr<SubTimeFrame>&& pStf);
 
  protected:
@@ -59,6 +61,7 @@ class InterleavedHdrDataDeserializer : public ISubTimeFrameVisitor
 {
  public:
   InterleavedHdrDataDeserializer() = default;
+  virtual ~InterleavedHdrDataDeserializer() = default;
 
   std::unique_ptr<SubTimeFrame> deserialize(FairMQChannel& pChan);
   std::unique_ptr<SubTimeFrame> deserialize(FairMQParts& pMsgs);