From b0f94eb49c41b5897c514e25af4f5208d5ddfcde Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 10 Mar 2026 03:18:11 +0000 Subject: [PATCH 1/2] Initial plan From 42f010907e4ee2a04ddfd24563c1a9684bc655a8 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 10 Mar 2026 03:20:24 +0000 Subject: [PATCH 2/2] Fix invalid CMake command with stray -D in Linux building instructions Co-authored-by: bkaradzic-microsoft <260535795+bkaradzic-microsoft@users.noreply.github.com> --- BUILDING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 7b518ca17..c8b494cac 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -295,7 +295,7 @@ sudo apt-get install libjavascriptcoregtk-4.1-dev Then, run cmake targetting a Ninja make file: ``` -cmake -G Ninja -D -D NAPI_JAVASCRIPT_ENGINE=JavaScriptCore +cmake -B build/linux -G Ninja -D NAPI_JAVASCRIPT_ENGINE=JavaScriptCore ``` ### V8 @@ -309,13 +309,13 @@ sudo apt-get install libv8-dev Then, run cmake targetting a Ninja make file: ``` -cmake -G Ninja -D NAPI_JAVASCRIPT_ENGINE=V8 +cmake -B build/linux -G Ninja -D NAPI_JAVASCRIPT_ENGINE=V8 ``` And finally, for any JavaScript engine, run a build: ``` -ninja +cmake --build build/linux ``` You can switch compiler between GCC and Clang by defining shell variables.