Fix --help hiding most CLI options in diff-cover/diff-quality#599
Merged
Conversation
The deprecated-flag pre-parser in handle_old_format() was created with the default add_help=True, so argparse intercepted --help there and printed help for the 4-option pre-parser instead of the real one. As a result, users saw only --html-report/--json-report/--markdown-report/ --format and assumed flags like --diff-file, --compare-branch, --exclude, etc. didn't exist. Setting add_help=False on the pre-parser lets --help fall through to parse_coverage_args (and the equivalent diff-quality parser), so the full set of options is displayed.
Owner
|
Thanks! I'll get this out this weekend! |
Owner
|
@duxiaocheng thanks! This is released https://pypi.org/project/diff-cover/10.2.1/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecated-flag pre-parser in handle_old_format() was created with the default add_help=True, so argparse intercepted --help there and printed help for the 4-option pre-parser instead of the real one. As a result, users saw only --html-report/--json-report/--markdown-report/ --format and assumed flags like --diff-file, --compare-branch, --exclude, etc. didn't exist.
Setting add_help=False on the pre-parser lets --help fall through to parse_coverage_args (and the equivalent diff-quality parser), so the full set of options is displayed.