-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathForbidEnumColumnRule.php
More file actions
70 lines (55 loc) · 1.71 KB
/
ForbidEnumColumnRule.php
File metadata and controls
70 lines (55 loc) · 1.71 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
<?php
declare(strict_types=1);
namespace PhpStanMigrationRules\Rules\Phinx;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Identifier;
use PhpParser\Node\Scalar\String_;
use PHPStan\Analyser\Scope;
use PHPStan\Rules\RuleErrorBuilder;
/**
* @extends PhinxRule<MethodCall>
*/
final class ForbidEnumColumnRule extends PhinxRule
{
private const string RULE_IDENTIFIER = 'phinx.schema.enumColumnForbidden';
private const string MESSAGE =
'Forbidden: enum column type. '
. 'Why: adding or removing enum values requires a full ALTER TABLE, which can cause long locks on large tables. '
. 'Fix: use a string column with application-level validation instead.';
public function getNodeType(): string
{
return MethodCall::class;
}
public function processNode(Node $node, Scope $scope): array
{
if (!$this->isPhinxMigration($scope)) {
return [];
}
if (!$this->isAddColumnCall($node)) {
return [];
}
if (!$this->hasEnumType($node)) {
return [];
}
return [
RuleErrorBuilder::message(self::MESSAGE)
->identifier(self::RULE_IDENTIFIER)
->build(),
];
}
private function isAddColumnCall(MethodCall $node): bool
{
return $node->name instanceof Identifier
&& $node->name->toString() === 'addColumn';
}
private function hasEnumType(MethodCall $node): bool
{
$args = $node->getArgs();
if (count($args) < 2) {
return false;
}
$typeArg = $args[1]->value;
return $typeArg instanceof String_ && $typeArg->value === 'enum';
}
}