Rule was seeing every table reference as a table creation

Author: Bellangelo

src/Rules/Phinx/ForbidMultipleTableCreationsRule.php

@@ -23,9 +23,9 @@ final class ForbidMultipleTableCreationsRule extends PhinxRule
         . 'Fix: split into one migration per table.';
 
     /**
-     * @var array<string, int>
+     * @var array<string, array<string, true>>
      */
-    private array $tableCallsPerClass = [];
+    private array $tableNamesPerClass = [];
 
     public function getNodeType(): string
     {
@@ -42,15 +42,20 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        $tableName = $this->extractTableName($node);
+        if ($tableName === null) {
+            return [];
+        }
+
         $classReflection = $scope->getClassReflection();
         if ($classReflection === null) {
             return [];
         }
 
         $className = $classReflection->getName();
-        $this->tableCallsPerClass[$className] = ($this->tableCallsPerClass[$className] ?? 0) + 1;
+        $this->tableNamesPerClass[$className][$tableName] = true;
 
-        if ($this->tableCallsPerClass[$className] > 1) {
+        if (count($this->tableNamesPerClass[$className]) > 1) {
             return [
                 RuleErrorBuilder::message(self::MESSAGE)
                     ->identifier(self::RULE_IDENTIFIER)
@@ -66,4 +71,22 @@ private function isTableCall(MethodCall $node): bool
         return $node->name instanceof Identifier
             && $node->name->toString() === 'table';
     }
+
+    private function extractTableName(MethodCall $node): ?string
+    {
+        if (count($node->args) === 0) {
+            return null;
+        }
+
+        $firstArg = $node->args[0];
+        if (!$firstArg instanceof Node\Arg) {
+            return null;
+        }
+
+        if ($firstArg->value instanceof Node\Scalar\String_) {
+            return $firstArg->value->value;
+        }
+
+        return null;
+    }
 }

tests/Rules/Phinx/ForbidMultipleTableCreationsRuleTest.php

@@ -39,6 +39,14 @@ public function testAllowsSingleTableCreateInMigration(): void
         );
     }
 
+    public function testAllowsSameTableReferencedMultipleTimes(): void
+    {
+        $this->analyse(
+            [__DIR__ . '/fixtures/SameTableMultipleReferences.php'],
+            []
+        );
+    }
+
     public function testDoesNotReportOutsidePhinxMigration(): void
     {
         $this->analyse(

tests/Rules/Phinx/fixtures/SameTableMultipleReferences.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PhpStanMigrationRules\Tests\Rules\Phinx\Fixtures;
+
+use Phinx\Migration\AbstractMigration;
+
+final class SameTableMultipleReferences extends AbstractMigration
+{
+    public function change(): void
+    {
+        if ($this->table('users')->hasColumn('nickname')) {
+            return;
+        }
+
+        $this->table('users')
+             ->addColumn('nickname', 'string', [
+                 'default' => '',
+                 'null' => false,
+             ])
+             ->update();
+    }
+}