fix(tss): require txParams with recipients for TSS tx signing#8462
Merged
mrdanish26 merged 1 commit intomasterfrom Apr 14, 2026
Merged
fix(tss): require txParams with recipients for TSS tx signing#8462mrdanish26 merged 1 commit intomasterfrom
mrdanish26 merged 1 commit intomasterfrom
Conversation
mrdanish26
force-pushed
the
WAL-375-mpcv2-sign-tx-require-txparams
branch
from
63ddf05 to
346f349
Compare
bitgo-ai-agent-dev
Bot
force-pushed
the
WAL-375-mpcv2-sign-tx-require-txparams
branch
from
346f349 to
b04cdf0
Compare
Contributor
pranavjain97
requested changes
Apr 10, 2026
mrdanish26
force-pushed
the
WAL-375-mpcv2-sign-tx-require-txparams
branch
2 times, most recently
from
2245b20 to
ab5753e
Compare
mrdanish26
force-pushed
the
WAL-375-mpcv2-sign-tx-require-txparams
branch
from
ab5753e to
2be89f5
Compare
pranavjain97
approved these changes
Apr 13, 2026
mrdanish26
added a commit
that referenced
this pull request
Apr 16, 2026
…uire-txparams" This reverts commit 1b9c75b, reversing changes made to 26a1c8e.
mrdanish26
added a commit
that referenced
this pull request
Apr 16, 2026
mrdanish26
added a commit
that referenced
this pull request
Apr 16, 2026
Revert "Merge pull request #8462 from BitGo/WAL-375-mpcv2-sign-tx-req
9 tasks
mmcshinsky-bitgo
added a commit
that referenced
this pull request
Apr 30, 2026
…uest Introduce TssTxRecipientSource and TssSignTxRequestParams union so callers can opt into compile-time enforcement of non-empty txParams.recipients via recipientSource: Explicit. Default (resolved) matches existing optional txParams behavior. ECDSA signing validates explicit mode at runtime for JS callers. ITssUtils.signTxRequest now references the stricter param type. Add MPCv2 unit test covering the explicit branch. Ticket: https://bitgoinc.atlassian.net/browse/WAL-375 Original PR: #8462
mmcshinsky-bitgo
added a commit
that referenced
this pull request
Apr 30, 2026
…uest Introduce TssTxRecipientSource and TssSignTxRequestParams union so callers can opt into compile-time enforcement of non-empty txParams.recipients via recipientSource: Explicit. Default (resolved) matches existing optional txParams behavior. ECDSA signing validates explicit mode at runtime for JS callers. ITssUtils.signTxRequest now references the stricter param type. Add MPCv2 unit test covering the explicit branch. Refs: WAL-375 #8462 https://bitgoinc.atlassian.net/browse/WAL-375 #8462
mmcshinsky-bitgo
added a commit
that referenced
this pull request
Apr 30, 2026
…uest Introduce TssTxRecipientSource and TssSignTxRequestParams union so callers can opt into compile-time enforcement of non-empty txParams.recipients via recipientSource: Explicit. Default (resolved) matches existing optional txParams behavior. ECDSA signing validates explicit mode at runtime for JS callers. ITssUtils.signTxRequest now references the stricter param type. Add MPCv2 unit test covering the explicit branch. Refs: WAL-375 #8462 Ticket: WAL-375 https://bitgoinc.atlassian.net/browse/WAL-375 #8462
mmcshinsky-bitgo
added a commit
that referenced
this pull request
Apr 30, 2026
…uest Introduce TssTxRecipientSource and TssSignTxRequestParams union so callers can opt into compile-time enforcement of non-empty txParams.recipients via recipientSource: Explicit. Default (resolved) matches existing optional txParams behavior. ECDSA signing validates explicit mode at runtime for JS callers. ITssUtils.signTxRequest now references the stricter param type. Add MPCv2 unit test covering the explicit branch. Refs: WAL-375 #8462 WAL-375
mmcshinsky-bitgo
added a commit
that referenced
this pull request
Apr 30, 2026
…uest Introduce TssTxRecipientSource and TssSignTxRequestParams so callers can opt into compile-time enforcement of non-empty txParams.recipients via recipientSource Explicit. Default resolved behavior matches existing optional txParams. ECDSA signing validates Explicit at runtime for non-TS callers. ITssUtils.signTxRequest uses the new param type. Add MPCv2 unit test for Explicit. BREAKING CHANGE: ITssUtils.signTxRequest is now typed as TssSignTxRequestParamsWithPrv instead of a minimal inline shape. TypeScript consumers that implement or narrow this interface may need signature updates; runtime behavior for existing callers is unchanged. Refs: WAL-375 #8462 WAL-375
mmcshinsky-bitgo
added a commit
that referenced
this pull request
Apr 30, 2026
Introduce TssTxRecipientSource and TssSignTxRequestParams so callers can opt into compile-time enforcement of non-empty txParams.recipients via recipientSource Explicit. Default resolved behavior matches existing optional txParams. ECDSA signing validates Explicit at runtime for non-TS callers. ITssUtils.signTxRequest uses the new param type. Add MPCv2 unit test for Explicit. BREAKING CHANGE: ITssUtils.signTxRequest is now typed as TssSignTxRequestParamsWithPrv instead of a minimal inline shape. TypeScript consumers that implement or narrow this interface may need signature updates; runtime behavior for existing callers is unchanged. Refs: WAL-375 #8462 WAL-375
mmcshinsky-bitgo
added a commit
that referenced
this pull request
May 5, 2026
Introduce TssTxRecipientSource and TssSignTxRequestParams so callers can opt into compile-time enforcement of non-empty txParams.recipients via recipientSource Explicit. Default resolved behavior matches existing optional txParams. ECDSA signing validates Explicit at runtime for non-TS callers. ITssUtils.signTxRequest uses the new param type. Add MPCv2 unit test for Explicit. BREAKING CHANGE: ITssUtils.signTxRequest is now typed as TssSignTxRequestParamsWithPrv instead of a minimal inline shape. TypeScript consumers that implement or narrow this interface may need signature updates; runtime behavior for existing callers is unchanged. Refs: WAL-375 #8462 WAL-375
mmcshinsky-bitgo
added a commit
that referenced
this pull request
May 6, 2026
Introduce TssTxRecipientSource and TssSignTxRequestParams so callers can opt into compile-time enforcement of non-empty txParams.recipients via recipientSource Explicit. Default resolved behavior matches existing optional txParams. ECDSA, MPCv2, and EDDSA signing all validate Explicit at runtime for non-TS callers. ITssUtils.signTxRequest uses the new param type. Add MPCv2 positive and negative unit tests for Explicit. BREAKING CHANGE: ITssUtils.signTxRequest is now typed as TssSignTxRequestParamsWithPrv instead of a minimal inline shape. TypeScript consumers that implement or narrow this interface may need signature updates; runtime behavior for existing callers is unchanged. Refs: WAL-375 #8462 WAL-375
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signTxRequest()silently defaultedtxParamsto{ recipients: [] }when the caller omitted it, allowing a compromised BitGo API to swapsignableHexto redirect funds without client detectionsignRequestBase()that throws whentxParams.recipientsis absent or empty forRequestType.tx, ensuringverifyTransaction()always receives explicit caller-supplied paramstxParamsthroughrecreateTxRequest()so the pending-approval re-sign path keeps working; extracts recipients frompendingApproval.info.transactionRequestTest plan
signTxRequestinecdsaMPCv2/signTxRequest.tsandecdsa.tsupdated to passtxParamswith recipientstxParamsis missingtxParams.recipientsis an empty arrayyarn unit-testinmodules/bitgo