Skip to content

Commit c0d97db

Browse files
WIP
1 parent e6c4dd7 commit c0d97db

File tree

6 files changed

+19
-21
lines changed

6 files changed

+19
-21
lines changed

.storybook/main.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ const config: StorybookConfig = {
2626
return mergeConfig(config, {
2727
define: {
2828
global: 'globalThis',
29-
BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION: JSON.stringify(''),
29+
BLOCKETHER_FOUNDATION_ASSETS_PATH: JSON.stringify(''),
3030
},
3131
optimizeDeps: {
32-
include: ['react', 'react-dom'],
32+
include: ['react', 'react-dom']
3333
},
3434
})
3535
}

examples/standalone/vite.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export default defineConfig({
3737
'process.env': JSON.stringify({
3838
NODE_ENV: 'production'
3939
}),
40-
BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION: JSON.stringify('/assets/')
40+
BLOCKETHER_FOUNDATION_ASSETS_PATH: JSON.stringify('/assets/')
4141
},
4242
build: {
4343
// Lib mode for proper ES module exports

src/components/cockpit/sql/editor.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,14 @@ export function SQLEditor({
9393

9494
// Initialize Monaco Editor
9595
useEffect(() => {
96+
loader.config({ monaco })
97+
9698
self.MonacoEnvironment = {
97-
getWorker: async (_, __) => {
98-
return new (await import('monaco-editor/esm/vs/editor/editor.worker?worker')).default()
99-
},
99+
getWorkerUrl(workerId: string, label: string) {
100+
return import.meta.resolve('/node_modules/monaco-editor/esm/vs/editor/editor.worker.js');
101+
}
100102
}
101103

102-
loader.config({ monaco })
103104

104105
// Initialize Monaco and mark as loaded
105106
loader
@@ -113,6 +114,7 @@ export function SQLEditor({
113114
.catch(error => {
114115
logger.error('Failed to initialize Monaco Editor:', error)
115116
})
117+
116118
}, [logger])
117119

118120
// Configure editor options

src/lib/duckdb/init.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -62,18 +62,18 @@ const duckdbBundles = async () => {
6262
}
6363
}
6464

65-
const MVP_MODULE = (BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION !== '' && BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION + 'duckdb-mvp.wasm') || 'unknown';
66-
const MVP_WORKER = (BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION !== '' && BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION + 'duckdb-browser-mvp.worker.js') || 'unknown';
67-
const EH_MODULE = (BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION !== '' && BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION + 'duckdb-eh.wasm') || 'unknown';
68-
const EH_WORKER = (BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION !== '' && BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION + 'duckdb-browser-eh.worker.js') || 'unknown';
65+
const MVP_MODULE = (BLOCKETHER_FOUNDATION_ASSETS_PATH !== '' && BLOCKETHER_FOUNDATION_ASSETS_PATH + 'duckdb-mvp.wasm') || 'unknown';
66+
const MVP_WORKER = (BLOCKETHER_FOUNDATION_ASSETS_PATH !== '' && BLOCKETHER_FOUNDATION_ASSETS_PATH + 'duckdb-browser-mvp.worker.js') || 'unknown';
67+
const EH_MODULE = (BLOCKETHER_FOUNDATION_ASSETS_PATH !== '' && BLOCKETHER_FOUNDATION_ASSETS_PATH + 'duckdb-eh.wasm') || 'unknown';
68+
const EH_WORKER = (BLOCKETHER_FOUNDATION_ASSETS_PATH !== '' && BLOCKETHER_FOUNDATION_ASSETS_PATH + 'duckdb-browser-eh.worker.js') || 'unknown';
6969

70-
const bundleResolver = BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION !== '' ?
70+
const bundleResolver = BLOCKETHER_FOUNDATION_ASSETS_PATH !== '' ?
7171
(
7272
async () => {
7373
const logger = getGlobalLogger()
7474
try {
7575
logger.info('Standalone DuckDB paths:', {
76-
BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION,
76+
BLOCKETHER_FOUNDATION_ASSETS_PATH,
7777
MVP_MODULE,
7878
MVP_WORKER,
7979
EH_MODULE,
@@ -104,9 +104,9 @@ const bundleResolver = BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION !== '' ?
104104
}
105105

106106
// Validate that all files use the same base location
107-
const baseUrl = BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION
107+
const baseUrl = BLOCKETHER_FOUNDATION_ASSETS_PATH
108108
if (!MVP_MODULE.startsWith(baseUrl) || !MVP_WORKER.startsWith(baseUrl) ||
109-
!EH_MODULE.startsWith(baseUrl) || !EH_WORKER.startsWith(baseUrl)) {
109+
!EH_MODULE.startsWith(baseUrl) || !EH_WORKER.startsWith(baseUrl)) {
110110
throw new Error(`Path inconsistency: All DuckDB files must be served from the same base location: ${baseUrl}`)
111111
}
112112

types/env.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* - Custom path ('./assets/') in standalone: loads from assets folder
99
*/
1010
declare global {
11-
const BLOCKETHER_FOUNDATION_DUCK_DB_LOCATION: string
11+
const BLOCKETHER_FOUNDATION_ASSETS_PATH: string
1212
}
1313

14-
export {}
14+
export { }

vite.config.mts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,5 @@ export default defineConfig({
8989
minify: 'esbuild',
9090
sourcemap: false,
9191
emptyOutDir: true,
92-
},
93-
// Configure Monaco Editor worker handling
94-
optimizeDeps: {
95-
exclude: ['@monaco-editor/react', 'monaco-editor', '@duckdb/duckdb-wasm', 'sql-formatter', 'apache-arrow'],
9692
}
9793
})

0 commit comments

Comments
 (0)