Skip to content

Security: defense-in-depth audit findings (12 items) #19

@somethingwithproof

Description

@somethingwithproof

Defense-in-Depth Audit

An automated security audit identified 12 defense-in-depth opportunities in plugin_apcupsd.

Breakdown

CMD(1), Path(10), CSRF(1)

Recommended fixes

  • SQLi: Convert string-concatenated SQL to db_execute_prepared() / db_fetch_*_prepared()
  • XSS: Wrap get_request_var() in HTML contexts with html_escape_request_var()
  • CMD: Verify exec()/shell_exec() args use cacti_escapeshellarg()
  • Path: Add realpath() + prefix validation for include/require with variable paths
  • Deser: Add array('allowed_classes' => false) to unserialize() calls
  • CSRF: Verify forms integrate with Cacti CSRF framework

All recommended changes are PHP 7.0+ compatible.

Related PR: #18

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions