A project should look like it was written by one developer. Consistency and clean style significantly improve readability and maintainability. In Catroweb, the following commands are the standard local checks.
bin/php-cs-fixer fix --dry-run --allow-risky=yes --verbose --format=txtto testbin/php-cs-fixer fix --allow-risky=yes --verbose --format=txtto automatically try to fix the problems
or
yarn test-phpto testyarn fix-phpto automatically try to fix the problems
yarn test-jsto testyarn fix-jsto automatically try to fix the problems
yarn test-cssto testyarn fix-cssto automatically try to fix the problems
yarn testto test allyarn fixto automatically try to fix all the problems
-
All .scss, .js (and image) files should be in the assets folder.
Do not create/move them directly to the public folder. This is handled by the frontend build. -
For more details feel free to look up the config files in the project if necessary.
-
The Continuous Integration system will automatically check your code style on every pull request, but will not fix it and fail on errors. It is advised to run the mentioned commands before pushing.