From 6c71d5be0695d185af889598b90e8f46ff99aa72 Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 10:37:16 -0400 Subject: [PATCH 01/29] replace div with button --- builder-frontend/src/components/Header/Header.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder-frontend/src/components/Header/Header.tsx b/builder-frontend/src/components/Header/Header.tsx index 290e80b0..453f9c3e 100644 --- a/builder-frontend/src/components/Header/Header.tsx +++ b/builder-frontend/src/components/Header/Header.tsx @@ -15,7 +15,7 @@ const HeaderButton = ({ onClick: () => void; }) => { return ( -
{buttonText} -
+ ); }; From 57ad4a5d6b7ea591509b956cc1f26923668f6f3d Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 10:38:21 -0400 Subject: [PATCH 02/29] change div to button --- builder-frontend/src/components/homeScreen/ProjectsList.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder-frontend/src/components/homeScreen/ProjectsList.tsx b/builder-frontend/src/components/homeScreen/ProjectsList.tsx index 7ab13922..f2730b3a 100644 --- a/builder-frontend/src/components/homeScreen/ProjectsList.tsx +++ b/builder-frontend/src/components/homeScreen/ProjectsList.tsx @@ -107,7 +107,7 @@ export default function ProjectsList() { eligibility checks from our library of pre-built eligibility rules. Or build custom checks that meet your specific needs. -
setIsNewScreenerModalVisible(true)} class=" mt-2 px-4 py-2 w-fit cursor-pointer bg-blue-500 @@ -115,7 +115,7 @@ export default function ProjectsList() { font-bold text-sm text-white" > Create new screener -
+ setIsNewScreenerModalVisible(false)} From 81e512c32ab2daa1005ac22c47a8f281d11f01a6 Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 10:44:33 -0400 Subject: [PATCH 03/29] use article for project cards --- builder-frontend/src/components/homeScreen/ProjectsList.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder-frontend/src/components/homeScreen/ProjectsList.tsx b/builder-frontend/src/components/homeScreen/ProjectsList.tsx index f2730b3a..a6552530 100644 --- a/builder-frontend/src/components/homeScreen/ProjectsList.tsx +++ b/builder-frontend/src/components/homeScreen/ProjectsList.tsx @@ -138,7 +138,7 @@ export default function ProjectsList() { }; return ( item && ( -
{item.screenerName}
- + ) ); }} From 514fc56392c7cb4f8b3ae36f63074d85f2fd268c Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 10:46:19 -0400 Subject: [PATCH 04/29] use button instead of div for save button --- .../src/components/project/FormEditorView.tsx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/builder-frontend/src/components/project/FormEditorView.tsx b/builder-frontend/src/components/project/FormEditorView.tsx index c49f78f2..a213c8ef 100644 --- a/builder-frontend/src/components/project/FormEditorView.tsx +++ b/builder-frontend/src/components/project/FormEditorView.tsx @@ -195,28 +195,28 @@ function FormEditorView({ formSchema, setFormSchema }) {
-
Save -
+
-
Saving... -
+
-
Save -
+
From d56b5a7c908ec653b61b584e11b6f82764b88a65 Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 10:47:22 -0400 Subject: [PATCH 05/29] use button instead of div for form output validation --- builder-frontend/src/components/project/FormEditorView.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder-frontend/src/components/project/FormEditorView.tsx b/builder-frontend/src/components/project/FormEditorView.tsx index a213c8ef..be21105a 100644 --- a/builder-frontend/src/components/project/FormEditorView.tsx +++ b/builder-frontend/src/components/project/FormEditorView.tsx @@ -256,9 +256,9 @@ const FormValidationDrawer = ({ my-auto rounded-lg text-lg font-medium transition-all duration-100 " > -
+
+ Date: Mon, 27 Apr 2026 10:48:34 -0400 Subject: [PATCH 06/29] use button instead of div for confirm and cancel buttons in modal --- .../components/shared/ConfirmationModal.tsx | 53 ++++++++----------- 1 file changed, 23 insertions(+), 30 deletions(-) diff --git a/builder-frontend/src/components/shared/ConfirmationModal.tsx b/builder-frontend/src/components/shared/ConfirmationModal.tsx index bcc24a5f..e9831704 100644 --- a/builder-frontend/src/components/shared/ConfirmationModal.tsx +++ b/builder-frontend/src/components/shared/ConfirmationModal.tsx @@ -1,42 +1,35 @@ -const ConfirmationModal = ( - { confirmationTitle, confirmationText, callback, closeModal }: - { - confirmationTitle: string; - confirmationText: string; - callback: () => void; - closeModal: () => void - } -) => { +const ConfirmationModal = ({ + confirmationTitle, + confirmationText, + callback, + closeModal, +}: { + confirmationTitle: string; + confirmationText: string; + callback: () => void; + closeModal: () => void; +}) => { return (
-
- {confirmationTitle} -
-
- {confirmationText} -
+
{confirmationTitle}
+
{confirmationText}
-
+
-
+
+
- ) -} + ); +}; export default ConfirmationModal; From 8cf8406e3cb7ca67caf95fe5fb5a6e83703fbe0a Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 10:49:47 -0400 Subject: [PATCH 07/29] change div to button for add button in configure check modal --- .../configureBenefit/modals/ConfigureCheckModal.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder-frontend/src/components/project/manageBenefits/configureBenefit/modals/ConfigureCheckModal.tsx b/builder-frontend/src/components/project/manageBenefits/configureBenefit/modals/ConfigureCheckModal.tsx index 6cf5be85..1a43069d 100644 --- a/builder-frontend/src/components/project/manageBenefits/configureBenefit/modals/ConfigureCheckModal.tsx +++ b/builder-frontend/src/components/project/manageBenefits/configureBenefit/modals/ConfigureCheckModal.tsx @@ -313,9 +313,9 @@ const ParameterMultiStringInput = ({ placeholder="Type and press Enter to add" class="form-input-custom flex-1" /> -
+
+ ); From ef533a0af930e0bd7f39c4375d70419877766fb4 Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 10:51:14 -0400 Subject: [PATCH 08/29] change div to button for create new check button in checks list --- .../homeScreen/eligibilityCheckList/EligibilityChecksList.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder-frontend/src/components/homeScreen/eligibilityCheckList/EligibilityChecksList.tsx b/builder-frontend/src/components/homeScreen/eligibilityCheckList/EligibilityChecksList.tsx index 57a31ea6..18831027 100644 --- a/builder-frontend/src/components/homeScreen/eligibilityCheckList/EligibilityChecksList.tsx +++ b/builder-frontend/src/components/homeScreen/eligibilityCheckList/EligibilityChecksList.tsx @@ -52,14 +52,14 @@ const EligibilityChecksList = () => { Manage your custom eligibility checks here. Click on a check to view or edit its details. -
setAddingNewCheck(true)} > Create New Check -
+ setAddingNewCheck(false)}> Date: Mon, 27 Apr 2026 10:57:40 -0400 Subject: [PATCH 09/29] use main instead of div for homescreen wrapper --- builder-frontend/src/components/homeScreen/HomeScreen.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder-frontend/src/components/homeScreen/HomeScreen.tsx b/builder-frontend/src/components/homeScreen/HomeScreen.tsx index 0e3fc88d..0de91569 100644 --- a/builder-frontend/src/components/homeScreen/HomeScreen.tsx +++ b/builder-frontend/src/components/homeScreen/HomeScreen.tsx @@ -3,9 +3,9 @@ import { Accessor, createSignal } from "solid-js"; const HomeScreen = () => { return ( -
+
-
+ ); }; export default HomeScreen; From 910e9eb5fe487be940c4331d060effe0682f8336 Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 10:58:00 -0400 Subject: [PATCH 10/29] use fragment instead of div for projects list wrapper --- builder-frontend/src/components/homeScreen/ProjectsList.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder-frontend/src/components/homeScreen/ProjectsList.tsx b/builder-frontend/src/components/homeScreen/ProjectsList.tsx index a6552530..040a1fb1 100644 --- a/builder-frontend/src/components/homeScreen/ProjectsList.tsx +++ b/builder-frontend/src/components/homeScreen/ProjectsList.tsx @@ -90,7 +90,7 @@ export default function ProjectsList() { }; return ( -
+ <> BDT - Projects List
@@ -178,6 +178,6 @@ export default function ProjectsList() {
-
+ ); } From d8cde096c2a4ebd09cd169102436edef4622bfda Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 11:00:24 -0400 Subject: [PATCH 11/29] use main instead of div for screener wrapper --- .../src/components/screener/Screener.tsx | 22 +++++++++++++------ 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/builder-frontend/src/components/screener/Screener.tsx b/builder-frontend/src/components/screener/Screener.tsx index f7f42c9d..08475a83 100644 --- a/builder-frontend/src/components/screener/Screener.tsx +++ b/builder-frontend/src/components/screener/Screener.tsx @@ -5,19 +5,27 @@ import FormRenderer from "./FormRenderer"; import Loading from "@/components/Loading"; import EligibilityResults from "./EligibilityResults"; -import { fetchPublishedScreener, evaluatePublishedScreener } from "@/api/publishedScreener"; +import { + fetchPublishedScreener, + evaluatePublishedScreener, +} from "@/api/publishedScreener"; import type { PublishedScreener, ScreenerResult } from "@/types"; export default function Screener() { const params = useParams(); - const [screener] = createResource(() => fetchPublishedScreener(params.publishedScreenerId)); + const [screener] = createResource(() => + fetchPublishedScreener(params.publishedScreenerId), + ); const [screenerResult, setScreenerResult] = createSignal(); const submitForm = async (data: any) => { try { - let evaluationResult: ScreenerResult = await evaluatePublishedScreener(params.publishedScreenerId, data); + let evaluationResult: ScreenerResult = await evaluatePublishedScreener( + params.publishedScreenerId, + data, + ); setScreenerResult(evaluationResult); } catch (err) { console.log(err); @@ -26,8 +34,8 @@ export default function Screener() { return ( <> -
- {screener.loading && } +
+ {screener.loading && } {screener() && (
@@ -38,12 +46,12 @@ export default function Screener() {
- +
)} -
+ ); } From b91d41b6ae01017e856b0058c828e28006f28342 Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 11:01:34 -0400 Subject: [PATCH 12/29] use section instead of div for form and results sections in screener --- builder-frontend/src/components/screener/Screener.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/builder-frontend/src/components/screener/Screener.tsx b/builder-frontend/src/components/screener/Screener.tsx index 08475a83..6e213748 100644 --- a/builder-frontend/src/components/screener/Screener.tsx +++ b/builder-frontend/src/components/screener/Screener.tsx @@ -38,16 +38,16 @@ export default function Screener() { {screener.loading && } {screener() && (
-
+
-
+ -
+
-
+
)} From 544253deb22a7345049881b04f5274d9f3172b19 Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 11:02:48 -0400 Subject: [PATCH 13/29] use article instead of div for eligibility result cards --- .../screener/EligibilityResults.tsx | 26 +++++++++++++------ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/builder-frontend/src/components/screener/EligibilityResults.tsx b/builder-frontend/src/components/screener/EligibilityResults.tsx index 590748e6..1127e1b9 100644 --- a/builder-frontend/src/components/screener/EligibilityResults.tsx +++ b/builder-frontend/src/components/screener/EligibilityResults.tsx @@ -12,15 +12,19 @@ function formatParameters(params: Record): string { .join(", "); } -export default function EligibilityResults( - { screenerResult }: { screenerResult: Accessor } -) { +export default function EligibilityResults({ + screenerResult, +}: { + screenerResult: Accessor; +}) { console.log(screenerResult()); return (

Eligibility Results

- {([benefitKey, benefitResult]) => } + {([benefitKey, benefitResult]) => ( + + )}
); @@ -28,7 +32,7 @@ export default function EligibilityResults( function BenefitResult({ benefitResult }: { benefitResult: BenefitResult }) { return ( -
+

@@ -69,11 +73,17 @@ function BenefitResult({ benefitResult }: { benefitResult: BenefitResult }) { {check.name} - ({[check.module, check.version].filter(Boolean).join(" v")}) + ( + {[check.module, check.version].filter(Boolean).join(" v")} + )

- 0}> + 0 + } + >
{formatParameters(check.parameters)}
@@ -103,6 +113,6 @@ function BenefitResult({ benefitResult }: { benefitResult: BenefitResult }) {
)} */} - + ); } From 7b50533735100d835b6731a3578b18077b5feca8 Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 11:04:39 -0400 Subject: [PATCH 14/29] use main instead of div for 404 page wrapper --- builder-frontend/src/App.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder-frontend/src/App.tsx b/builder-frontend/src/App.tsx index 1165ff73..433d7d38 100644 --- a/builder-frontend/src/App.tsx +++ b/builder-frontend/src/App.tsx @@ -59,7 +59,7 @@ function App() {
404 - Page Not Found
} + component={() =>
404 - Page Not Found
} /> ); From 9ae161aaeb448deb140d7effc57b48a796195b13 Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 11:08:17 -0400 Subject: [PATCH 15/29] use h2 instead of div for edit screener modal title --- builder-frontend/src/components/homeScreen/EditScreenerForm.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder-frontend/src/components/homeScreen/EditScreenerForm.tsx b/builder-frontend/src/components/homeScreen/EditScreenerForm.tsx index cb9cd056..c904b49a 100644 --- a/builder-frontend/src/components/homeScreen/EditScreenerForm.tsx +++ b/builder-frontend/src/components/homeScreen/EditScreenerForm.tsx @@ -63,7 +63,7 @@ export default function EditScreenerForm(props: Props) { return (
-
Edit screener
+

Edit screener

From c9fd1de882616c9ff95adf9a5d1a1141280afb09 Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 11:08:54 -0400 Subject: [PATCH 16/29] use h2 instead of div for screener deletion confirmation modal title --- .../src/components/homeScreen/DeleteConfirmation.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder-frontend/src/components/homeScreen/DeleteConfirmation.tsx b/builder-frontend/src/components/homeScreen/DeleteConfirmation.tsx index 2d958230..8f94cc62 100644 --- a/builder-frontend/src/components/homeScreen/DeleteConfirmation.tsx +++ b/builder-frontend/src/components/homeScreen/DeleteConfirmation.tsx @@ -10,9 +10,9 @@ interface Props { export default function DeleteConfirmation(props: Props) { return (
-
+

Are you sure you would like to delete {props.screenerName}? -

+
Once deleted, all associated data will be deleted and cant be recovered.
From 6ab79e59f0daf91d3a1b970ac03cefcc694314ed Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 11:09:55 -0400 Subject: [PATCH 17/29] use h2 instead of div for confirmation modal title --- builder-frontend/src/components/shared/ConfirmationModal.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder-frontend/src/components/shared/ConfirmationModal.tsx b/builder-frontend/src/components/shared/ConfirmationModal.tsx index e9831704..845002a5 100644 --- a/builder-frontend/src/components/shared/ConfirmationModal.tsx +++ b/builder-frontend/src/components/shared/ConfirmationModal.tsx @@ -12,7 +12,7 @@ const ConfirmationModal = ({ return (
-
{confirmationTitle}
+

{confirmationTitle}

{confirmationText}
From a7d4d6f9c272fa913e5378c7bbdfd810ea9c29cf Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 11:12:33 -0400 Subject: [PATCH 20/29] use h1 instead of div for sign in page title --- builder-frontend/src/components/auth/AuthForm.jsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/builder-frontend/src/components/auth/AuthForm.jsx b/builder-frontend/src/components/auth/AuthForm.jsx index 0abd1f0c..b70e692d 100644 --- a/builder-frontend/src/components/auth/AuthForm.jsx +++ b/builder-frontend/src/components/auth/AuthForm.jsx @@ -35,9 +35,9 @@ export default function AuthForm() { return (
-
- Benefits Decision Tookit -
+

+ Benefit Decision Tookit +

{location.pathname === "/signup" ? ( ) : ( From 9b5d3938c173523ef1da61297163b6906b6dd51f Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 11:14:08 -0400 Subject: [PATCH 21/29] use p instead of div for deletion modal explanation --- .../src/components/homeScreen/DeleteConfirmation.tsx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/builder-frontend/src/components/homeScreen/DeleteConfirmation.tsx b/builder-frontend/src/components/homeScreen/DeleteConfirmation.tsx index 8f94cc62..54c83efe 100644 --- a/builder-frontend/src/components/homeScreen/DeleteConfirmation.tsx +++ b/builder-frontend/src/components/homeScreen/DeleteConfirmation.tsx @@ -13,9 +13,10 @@ export default function DeleteConfirmation(props: Props) {

Are you sure you would like to delete {props.screenerName}?

-
- Once deleted, all associated data will be deleted and cant be recovered. -
+

+ Once deleted, all associated data will be deleted and can't be + recovered. +

))} -
+ ); -} +}; export default BdtNavbar; From df9e92a0f793cee30bc16625c39dbfa75c5317cb Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 11:21:31 -0400 Subject: [PATCH 25/29] use section instead of div for drawer contents and use h2 instead of div for drawer welcome message --- builder-frontend/src/components/Header/Header.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/builder-frontend/src/components/Header/Header.tsx b/builder-frontend/src/components/Header/Header.tsx index 453f9c3e..f1d3fcc8 100644 --- a/builder-frontend/src/components/Header/Header.tsx +++ b/builder-frontend/src/components/Header/Header.tsx @@ -48,10 +48,10 @@ const HeaderMenu: Component = (props) => { ]; return ( -
-
+
+

Welcome {props.displayName} {props.userEmail} -

+
    @@ -62,7 +62,7 @@ const HeaderMenu: Component = (props) => { )}
-
+ ); }; From d2d5b674a6fd2abab2fe4d7ddb88ec0bf6e2fe83 Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 11:23:09 -0400 Subject: [PATCH 26/29] use ul and li instead of divs for list of errors in error modal --- builder-frontend/src/components/shared/ErrorModal.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/builder-frontend/src/components/shared/ErrorModal.tsx b/builder-frontend/src/components/shared/ErrorModal.tsx index 73a53171..851df253 100644 --- a/builder-frontend/src/components/shared/ErrorModal.tsx +++ b/builder-frontend/src/components/shared/ErrorModal.tsx @@ -14,17 +14,17 @@ const ErrorDisplayModal = ({

{title}

-
+
    {(error, errorIndex) => ( <> -
    +
  • {error} -
  • + )}
    -
+
From 7c823742e28ed3b473091817a808441ed0dcfa17 Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 11:23:56 -0400 Subject: [PATCH 27/29] use button instead of div for sign up button --- builder-frontend/src/components/auth/Login.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder-frontend/src/components/auth/Login.jsx b/builder-frontend/src/components/auth/Login.jsx index f23b3564..0dccf2b5 100644 --- a/builder-frontend/src/components/auth/Login.jsx +++ b/builder-frontend/src/components/auth/Login.jsx @@ -85,12 +85,12 @@ export default function Login({ toggleMode }) { Sign In -
+
+
{error() &&

{error()}

}
From 1300cdd6cdb7ed2c5b9ff9888a328c7a92749dc9 Mon Sep 17 00:00:00 2001 From: Earth Walker Date: Mon, 27 Apr 2026 11:25:18 -0400 Subject: [PATCH 28/29] use span instead of div for nav bar title --- builder-frontend/src/components/shared/BdtNavbar.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder-frontend/src/components/shared/BdtNavbar.tsx b/builder-frontend/src/components/shared/BdtNavbar.tsx index f3fe7e5a..66173bee 100644 --- a/builder-frontend/src/components/shared/BdtNavbar.tsx +++ b/builder-frontend/src/components/shared/BdtNavbar.tsx @@ -18,9 +18,9 @@ const BdtNavbar = ({ navProps }: { navProps: Accessor }) => { return (