a bunch of crit bug fixes

Author: Titanium2099

src/lib/storage.js

@@ -94,6 +94,8 @@ class Storage extends ScratchStorage {
 
         this.projectToken = creds.token;
         this.username = creds.username;
+        // eslint-disable-next-line require-atomic-updates
+        window.CollaborationUsername = creds.username;
         return creds;
     }
     async getProjectToken () {

src/lib/tw-project-meta-fetcher-hoc.jsx

@@ -108,7 +108,6 @@ const TWProjectMetaFetcherHOC = function (WrappedComponent) {
             this.state = {
                 canSave: false,
                 canRemix: false,
-                canUseCloud: false,
                 canEditTitle: false
             };
         }
@@ -168,7 +167,6 @@ const TWProjectMetaFetcherHOC = function (WrappedComponent) {
                             storage.setCloudOTT(data?.cloudDataOTT);
                             storage.setCustomAchievements(data?.customAchievements);
                             window.CollaborationRoom = data?.collaboratorRoom;
-                            window.CollaborationUsername = data?.username;
                             window.collaborationOTT = data?.collaborationOTT;
                         }
                         setIndexable(true);
@@ -199,7 +197,6 @@ const TWProjectMetaFetcherHOC = function (WrappedComponent) {
                     {...props}
                     canSave={this.state.canSave}
                     canRemix={this.state.canRemix}
-                    canUseCloud={this.state.canUseCloud}
                     canEditTitle={this.state.canEditTitle}
                 />
             );

src/lib/vm-manager-hoc.jsx

@@ -38,6 +38,9 @@ const vmManagerHOC = function (WrappedComponent) {
     class VMManager extends React.Component {
         constructor (props) {
             super(props);
+            this.state = {
+                canUseCloud: false
+            };
             bindAll(this, [
                 'loadProject'
             ]);
@@ -92,6 +95,10 @@ const vmManagerHOC = function (WrappedComponent) {
                     const username = storage.username || '';
                     this.props.onSetUsername(username);
 
+                    if (username !== ''){
+                        this.setState({canUseCloud: true});
+                    }
+
                     this.props.vm.loadProject(this.props.projectData, additionalData)
                         .then(() => {
                             this.props.onLoadedProject(this.props.loadingState, this.props.canSave);
@@ -139,6 +146,7 @@ const vmManagerHOC = function (WrappedComponent) {
                 <WrappedComponent
                     isLoading={isLoadingWithIdProp}
                     vm={vm}
+                    canUseCloud={this.state.canUseCloud}
                     {...componentProps}
                 />
             );