From 326c8a5963ae693ce31db875229f8bc79dcb4e7e Mon Sep 17 00:00:00 2001 From: HilolaRustamova Date: Sat, 16 Aug 2025 20:24:56 +0100 Subject: [PATCH 1/3] Fixed the problems --- debugging/book-library/index.html | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..452ccc1f 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,12 +1,9 @@ - - + ModuleDataFlaw.BookLibrary + + @@ -31,7 +28,7 @@

Library

Library /> Library type="submit" value="Submit" class="btn btn-primary" - onclick="submit();" + onclick="submit(event);" />
@@ -81,16 +78,11 @@

Library

- - - - - - - + + From e7f2081bd35837313387fb7ea97ad048d0a69e07 Mon Sep 17 00:00:00 2001 From: HilolaRustamova Date: Sat, 16 Aug 2025 20:25:24 +0100 Subject: [PATCH 2/3] Debugged the code --- debugging/book-library/script.js | 46 +++++++++++++++++--------------- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..b1d31cfa 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,19 +1,17 @@ let myLibrary = []; window.addEventListener("load", function (e) { - populateStorage(); +if (localStorage.getItem("myLibrary")) { + myLibrary = JSON.parse(localStorage.getItem("myLibrary")); + } else { + populateStorage(); + } render(); }); - function populateStorage() { if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( - "The Old Man and the Sea", - "Ernest Hemingway", - "127", - true - ); + let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true); + let book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", "127", true); myLibrary.push(book1); myLibrary.push(book2); render(); @@ -31,36 +29,40 @@ function submit() { if ( title.value == null || title.value == "" || + author.value == null || + author.value == "" || pages.value == null || pages.value == "" ) { alert("Please fill all fields!"); return false; } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); + let book = new Book(title.value, author.value, pages.value, check.checked); + myLibrary.push(book); render(); } } -function Book(title, author, pages, check) { - this.title = title; - this.author = author; - this.pages = pages; - this.check = check; +class Book { + constructor(title, author, pages, check) { + this.title = title; + this.author = author; + this.pages = pages; + this.check = check; + } } function render() { let table = document.getElementById("display"); let rowsNumber = table.rows.length; //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } //insert updated row and cells let length = myLibrary.length; for (let i = 0; i < length; i++) { - let row = table.insertRow(1); + let row = table.insertRow(-1); let titleCell = row.insertCell(0); let authorCell = row.insertCell(1); let pagesCell = row.insertCell(2); @@ -76,7 +78,7 @@ function render() { changeBut.className = "btn btn-success"; wasReadCell.appendChild(changeBut); let readStatus = ""; - if (myLibrary[i].check == false) { + if (myLibrary[i].check == true) { readStatus = "Yes"; } else { readStatus = "No"; @@ -89,15 +91,15 @@ function render() { }); //add delete button to every row and render again - let delButton = document.createElement("button"); + let delBut = document.createElement("button"); delBut.id = i + 5; deleteCell.appendChild(delBut); delBut.className = "btn btn-warning"; delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { + delBut.addEventListener("click", function () { alert(`You've deleted title: ${myLibrary[i].title}`); myLibrary.splice(i, 1); render(); }); } -} +} From 1ff7eb7d38429f1bf63519779041c62e4ad223f0 Mon Sep 17 00:00:00 2001 From: HilolaRustamova Date: Sun, 17 Aug 2025 15:03:36 +0100 Subject: [PATCH 3/3] changes to render, saving, and naming --- debugging/book-library/script.js | 99 ++++++++++++++------------------ 1 file changed, 44 insertions(+), 55 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index b1d31cfa..a9cb7f86 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -9,38 +9,34 @@ if (localStorage.getItem("myLibrary")) { render(); }); function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", "127", true); + if (myLibrary.length === 0) { + let book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true); + let book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true); myLibrary.push(book1); myLibrary.push(book2); - render(); } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const readCheckBox = document.getElementById("check"); -//check the right input from forms and if its ok -> add the new book (object in array) +//check the right input from forms and if its ok -> add the new book //via Book function and start render function function submit() { - if ( - title.value == null || - title.value == "" || - author.value == null || - author.value == "" || - pages.value == null || - pages.value == "" - ) { - alert("Please fill all fields!"); - return false; - } else { - let book = new Book(title.value, author.value, pages.value, check.checked); + const title = titleInput.value.trim(); + const author = authorInput.value.trim(); + const pages = pagesInput.value.trim(); + + if (!title || !author || !pages || isNaN(pages) || pages <=0) { + alert("Please fill all fields correctly!"); + return; + } + let book = new Book(title, author, Number(pages), readCheckBox.checked); myLibrary.push(book); render(); - } + } class Book { @@ -53,53 +49,46 @@ class Book { } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n--) { - table.deleteRow(n); - } + const tableBody = document.querySelector("#display tbody"); + tableBody.innerHTML = ""; + //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(-1); + for (let i = 0; i < myLibrary.length; i++) { + let row = tableBody.insertRow(-1); let titleCell = row.insertCell(0); let authorCell = row.insertCell(1); let pagesCell = row.insertCell(2); let wasReadCell = row.insertCell(3); let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; - //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == true) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; + titleCell.textContent= myLibrary[i].title; + authorCell.textContent = myLibrary[i].author; + pagesCell.textContent = myLibrary[i].pages; + + let toggleBtn = document.createElement("button"); + toggleBtn.className = "btn btn-success"; + toggleBtn.textContent = myLibrary[i].check ? "Yes" : "No"; + wasReadCell.appendChild(toggleBtn); - changeBut.addEventListener("click", function () { + toggleBtn.addEventListener("click", function () { myLibrary[i].check = !myLibrary[i].check; render(); }); //add delete button to every row and render again - let delBut = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("click", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); + let delBtn = document.createElement("button"); + delBtn.className = "btn btn-warning"; + delBtn.textContent = "Delete"; + deleteCell.appendChild(delBtn); + + delBtn.addEventListener("click", function () { + if(confirm(`Are you sure you want to delete " ${myLibrary[i].title}"?`)){ myLibrary.splice(i, 1); render(); + } }); } -} + // Save updated library to localStorage + localStorage.setItem("myLibrary", JSON.stringify(myLibrary)); +} +