From c3b333a118a1c0f720a925d447e881f4371d17c8 Mon Sep 17 00:00:00 2001 From: Khor Biel Date: Sat, 29 Nov 2025 15:45:15 +0000 Subject: [PATCH 1/7] Fixed input types, clean markup, and ensure table renders properly --- debugging/book-library/index.html | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..7888b9b3 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,7 +1,7 @@ - + - + My Book Library Library
Library name="pages" required /> -
From 9b4e4713f6f3c2f9f9047bb2a7ed790498332016 Mon Sep 17 00:00:00 2001 From: Khor Biel Date: Sat, 29 Nov 2025 15:59:20 +0000 Subject: [PATCH 2/7] Resolved multiple logic and syntax errors, repair delete/read buttons, and restore full app functionality --- debugging/book-library/script.js | 159 +++++++++++++++++-------------- 1 file changed, 87 insertions(+), 72 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..6ef4e3f8 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,5 +1,13 @@ let myLibrary = []; +// DOM refs +const title = document.getElementById("title"); +const author = document.getElementById("author"); +const pages = document.getElementById("pages"); +const check = document.getElementById("check"); +const submitBtn = document.getElementById("submitBtn"); +const table = document.getElementById("display"); + window.addEventListener("load", function (e) { populateStorage(); render(); @@ -7,97 +15,104 @@ window.addEventListener("load", function (e) { function populateStorage() { if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( + const book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); + const book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", "127", true ); - myLibrary.push(book1); - myLibrary.push(book2); - render(); + myLibrary.push(book1, book2); } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +// wire submit button +submitBtn.addEventListener("click", addBook); -//check the right input from forms and if its ok -> add the new book (object in array) -//via Book function and start render function -function submit() { - if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { +// validate and add book to library +function addBook() { + // trim to avoid spaces-only input + const t = title.value.trim(); + const a = author.value.trim(); + const p = pages.value.trim(); + + if (!t || !a || !p) { alert("Please fill all fields!"); - return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); - render(); + return; + } + + // pages should be a positive number + if (isNaN(p) || Number(p) <= 0) { + alert("Please enter a valid number of pages."); + return; } + + const book = new Book(t, a, p, check.checked); + myLibrary.push(book); + + // clear inputs and close the collapse (optional) + title.value = ""; + author.value = ""; + pages.value = ""; + check.checked = false; + + render(); } -function Book(title, author, pages, check) { +// Book constructor +function Book(title, author, pages, read) { this.title = title; this.author = author; this.pages = pages; - this.check = check; + // store boolean as 'read' + this.read = !!read; } +// render table rows from myLibrary function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { - table.deleteRow(n); - } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; - - //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; + // clear existing tbody rows + // keep the thead, clear tbody + const tbody = table.querySelector("tbody"); + tbody.innerHTML = ""; + + for (let i = 0; i < myLibrary.length; i++) { + const book = myLibrary[i]; + const row = tbody.insertRow(); + + const titleCell = row.insertCell(0); + const authorCell = row.insertCell(1); + const pagesCell = row.insertCell(2); + const wasReadCell = row.insertCell(3); + const deleteCell = row.insertCell(4); + + titleCell.textContent = book.title; + authorCell.textContent = book.author; + pagesCell.textContent = book.pages; + + // Read toggle button + const changeBut = document.createElement("button"); + changeBut.className = "btn btn-sm btn-outline-success"; + changeBut.textContent = book.read ? "Yes" : "No"; + changeBut.addEventListener("click", (function (index) { + return function () { + myLibrary[index].read = !myLibrary[index].read; + render(); + }; + })(i)); wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; - - changeBut.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; - render(); - }); - - //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; + + // Delete button + const delBut = document.createElement("button"); + delBut.className = "btn btn-sm btn-warning"; + delBut.textContent = "Delete"; + delBut.addEventListener("click", (function (index) { + return function () { + if (confirm(`Delete "${myLibrary[index].title}"?`)) { + myLibrary.splice(index, 1); + render(); + } + }; + })(i)); deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); - myLibrary.splice(i, 1); - render(); - }); } -} +} \ No newline at end of file From d310d246c539e0b5aadcebfbe0b24358e0d76ace Mon Sep 17 00:00:00 2001 From: Khor Biel Date: Sat, 29 Nov 2025 16:01:38 +0000 Subject: [PATCH 3/7] Cleaned up CSS formatting, simplified layout rules, and adjusted spacing for better form readability and alignment --- debugging/book-library/style.css | 2 -- 1 file changed, 2 deletions(-) diff --git a/debugging/book-library/style.css b/debugging/book-library/style.css index 302950cb..2a047c05 100644 --- a/debugging/book-library/style.css +++ b/debugging/book-library/style.css @@ -1,7 +1,5 @@ .form-group { width: 400px; - height: 300px; - align-self: left; padding-left: 20px; } From 5d22b66e1a06ac1a277aa5253133315dbb486e4e Mon Sep 17 00:00:00 2001 From: Khor Biel Date: Mon, 1 Dec 2025 19:43:54 +0000 Subject: [PATCH 4/7] made small changes --- debugging/book-library/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 7888b9b3..49a2bec3 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -91,6 +91,6 @@

Library

- + From 5ac4fe437cf476842ae58ad3c719634b14dac515 Mon Sep 17 00:00:00 2001 From: Khor Biel Date: Wed, 3 Dec 2025 02:05:05 +0000 Subject: [PATCH 5/7] Fixed html --- debugging/book-library/index.html | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 49a2bec3..56dbbb22 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -2,11 +2,8 @@ My Book Library - + + @@ -39,7 +36,7 @@

Library

/> Library - @@ -80,17 +76,7 @@

Library

- - - - - - - - -
- - + From eaf251d690d3ae744bd5ff2bcb5aedf144d001f0 Mon Sep 17 00:00:00 2001 From: Khor Biel Date: Wed, 3 Dec 2025 02:19:25 +0000 Subject: [PATCH 6/7] Updated js --- debugging/book-library/script.js | 34 ++++++++++++++------------------ 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 6ef4e3f8..3e76af42 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,12 +1,12 @@ let myLibrary = []; // DOM refs -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const checkInput = document.getElementById("check"); const submitBtn = document.getElementById("submitBtn"); -const table = document.getElementById("display"); +const tableContent = document.getElementById("display"); window.addEventListener("load", function (e) { populateStorage(); @@ -93,26 +93,22 @@ function render() { const changeBut = document.createElement("button"); changeBut.className = "btn btn-sm btn-outline-success"; changeBut.textContent = book.read ? "Yes" : "No"; - changeBut.addEventListener("click", (function (index) { - return function () { - myLibrary[index].read = !myLibrary[index].read; - render(); - }; - })(i)); + changeBut.addEventListener("click", function() { + myLibrary[i].read = !myLibrary[i].read; + render(); + }); wasReadCell.appendChild(changeBut); // Delete button const delBut = document.createElement("button"); delBut.className = "btn btn-sm btn-warning"; delBut.textContent = "Delete"; - delBut.addEventListener("click", (function (index) { - return function () { - if (confirm(`Delete "${myLibrary[index].title}"?`)) { - myLibrary.splice(index, 1); - render(); - } - }; - })(i)); + delBut.addEventListener("click", function() { + if (confirm(`Delete "${myLibrary[i].title}"?`)) { + myLibrary.splice(i, 1); + render(); + } + }); deleteCell.appendChild(delBut); } } \ No newline at end of file From 5bc0cb7e6c198058e0f8a8f6de43e80965a88003 Mon Sep 17 00:00:00 2001 From: Khor Biel Date: Wed, 3 Dec 2025 02:35:56 +0000 Subject: [PATCH 7/7] Fix HTML errors and update JS per reviewer feedback --- debugging/book-library/index.html | 12 ++++++++ debugging/book-library/script.js | 50 +++++++++++++++---------------- 2 files changed, 36 insertions(+), 26 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 56dbbb22..d438e785 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -4,6 +4,7 @@ My Book Library + @@ -66,6 +67,7 @@

Library

+ @@ -76,7 +78,17 @@

Library

+ + + + + + + + +
+ diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 3e76af42..b19efda9 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,12 +1,12 @@ let myLibrary = []; -// DOM refs +// DOM refs const titleInput = document.getElementById("title"); const authorInput = document.getElementById("author"); const pagesInput = document.getElementById("pages"); const checkInput = document.getElementById("check"); -const submitBtn = document.getElementById("submitBtn"); -const tableContent = document.getElementById("display"); +const submitBtn = document.getElementById("submitBtn"); +const table = document.getElementById("display"); window.addEventListener("load", function (e) { populateStorage(); @@ -15,11 +15,11 @@ window.addEventListener("load", function (e) { function populateStorage() { if (myLibrary.length == 0) { - const book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); + const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true); const book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", - "127", + 127, true ); myLibrary.push(book1, book2); @@ -32,29 +32,30 @@ submitBtn.addEventListener("click", addBook); // validate and add book to library function addBook() { // trim to avoid spaces-only input - const t = title.value.trim(); - const a = author.value.trim(); - const p = pages.value.trim(); + const t = titleInput.value.trim(); + const a = authorInput.value.trim(); + const pRaw = pagesInput.value.trim(); - if (!t || !a || !p) { + if (!t || !a || !pRaw) { alert("Please fill all fields!"); return; } - // pages should be a positive number - if (isNaN(p) || Number(p) <= 0) { - alert("Please enter a valid number of pages."); + // pages should be a positive integer (prevent "weird" page counts) + const pNum = Number(pRaw); + if (!Number.isFinite(pNum) || pNum <= 0 || !Number.isInteger(pNum)) { + alert("Please enter a valid positive whole number of pages."); return; } - const book = new Book(t, a, p, check.checked); + const book = new Book(t, a, pNum, checkInput.checked); myLibrary.push(book); - // clear inputs and close the collapse (optional) - title.value = ""; - author.value = ""; - pages.value = ""; - check.checked = false; + // clear inputs and close the collapse + titleInput.value = ""; + authorInput.value = ""; + pagesInput.value = ""; + checkInput.checked = false; render(); } @@ -64,14 +65,11 @@ function Book(title, author, pages, read) { this.title = title; this.author = author; this.pages = pages; - // store boolean as 'read' this.read = !!read; } // render table rows from myLibrary function render() { - // clear existing tbody rows - // keep the thead, clear tbody const tbody = table.querySelector("tbody"); tbody.innerHTML = ""; @@ -89,21 +87,21 @@ function render() { authorCell.textContent = book.author; pagesCell.textContent = book.pages; - // Read toggle button + // Read toggle button const changeBut = document.createElement("button"); changeBut.className = "btn btn-sm btn-outline-success"; changeBut.textContent = book.read ? "Yes" : "No"; - changeBut.addEventListener("click", function() { + changeBut.addEventListener("click", function() { myLibrary[i].read = !myLibrary[i].read; render(); }); wasReadCell.appendChild(changeBut); - // Delete button + // Delete button const delBut = document.createElement("button"); delBut.className = "btn btn-sm btn-warning"; delBut.textContent = "Delete"; - delBut.addEventListener("click", function() { + delBut.addEventListener("click", function() { if (confirm(`Delete "${myLibrary[i].title}"?`)) { myLibrary.splice(i, 1); render(); @@ -111,4 +109,4 @@ function render() { }); deleteCell.appendChild(delBut); } -} \ No newline at end of file +}