From a237c622b6dbbf66644d1f94273bbe036747a0b5 Mon Sep 17 00:00:00 2001 From: Daniel Aderibigbe Date: Sat, 4 Apr 2026 22:23:38 +0100 Subject: [PATCH 1/3] book libary completed --- debugging/book-library/script.js | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..4c4f7d14 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,6 +1,6 @@ let myLibrary = []; -window.addEventListener("load", function (e) { +window.addEventListener("load", function () { populateStorage(); render(); }); @@ -29,16 +29,16 @@ const check = document.getElementById("check"); //via Book function and start render function function submit() { if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" + title.value === "" || + author.value === "" || + pages.value === "" || + !check.checked ) { alert("Please fill all fields!"); return false; } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); + let book = new Book(title.value, author.value, pages.value, check.checked); + myLibrary.push(book); render(); } } @@ -54,7 +54,7 @@ function render() { let table = document.getElementById("display"); let rowsNumber = table.rows.length; //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } //insert updated row and cells @@ -90,11 +90,11 @@ function render() { //add delete button to every row and render again let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { + delButton.id = i + 5; + deleteCell.appendChild(delButton); + delButton.className = "btn btn-warning"; + delButton.innerHTML = "Delete"; + delButton.addEventListener("click", function () { alert(`You've deleted title: ${myLibrary[i].title}`); myLibrary.splice(i, 1); render(); From 89a480d13210571bfafbc2cd88d4b2c27a972c83 Mon Sep 17 00:00:00 2001 From: Daniel Aderibigbe Date: Sun, 5 Apr 2026 09:44:38 +0100 Subject: [PATCH 2/3] updated changes based on general feedback --- debugging/book-library/index.html | 44 ++++----- debugging/book-library/script.js | 151 +++++++++++++++++------------- 2 files changed, 100 insertions(+), 95 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..23e12f32 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,20 +1,20 @@ - - + + - - - - - + + + + Library App - + + + + + + @@ -30,21 +30,9 @@

Library

- + - + Library type="submit" value="Submit" class="btn btn-primary" - onclick="submit();" + onclick="submit()" />
@@ -91,6 +79,6 @@

Library

- + diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 4c4f7d14..7692e9f6 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -2,102 +2,119 @@ let myLibrary = []; window.addEventListener("load", function () { populateStorage(); - render(); }); function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( + if (myLibrary.length === 0) { + const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true); + const book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", - "127", + 127, true ); - myLibrary.push(book1); - myLibrary.push(book2); + + myLibrary.push(book1, book2); render(); } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const readCheckbox = document.getElementById("check"); -//check the right input from forms and if its ok -> add the new book (object in array) -//via Book function and start render function function submit() { + const titleValue = titleInput.value.trim(); + const authorValue = authorInput.value.trim(); + const pagesValue = Number(pagesInput.value); + if ( - title.value === "" || - author.value === "" || - pages.value === "" || - !check.checked + titleValue === "" || + authorValue === "" || + !pagesValue || + pagesValue <= 0 ) { - alert("Please fill all fields!"); - return false; - } else { - let book = new Book(title.value, author.value, pages.value, check.checked); - myLibrary.push(book); - render(); + alert("Please enter valid input!"); + return; } + + const book = new Book( + titleValue, + authorValue, + pagesValue, + readCheckbox.checked + ); + + myLibrary.push(book); + render(); + + titleInput.value = ""; + authorInput.value = ""; + pagesInput.value = ""; + readCheckbox.checked = false; } -function Book(title, author, pages, check) { +function Book(title, author, pages, isRead) { this.title = title; this.author = author; this.pages = pages; - this.check = check; + this.isRead = isRead; } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n--) { - table.deleteRow(n); - } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; - - //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; - - changeBut.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; + const table = document.getElementById("display"); + + table.innerHTML = ` + + + Title + Author + Number of Pages + Read + + + + `; + + for (let i = 0; i < myLibrary.length; i++) { + const book = myLibrary[i]; + + const row = table.insertRow(); + + const titleCell = row.insertCell(0); + const authorCell = row.insertCell(1); + const pagesCell = row.insertCell(2); + const readCell = row.insertCell(3); + const deleteCell = row.insertCell(4); + + titleCell.textContent = book.title; + authorCell.textContent = book.author; + pagesCell.textContent = book.pages; + + const toggleReadBtn = document.createElement("button"); + toggleReadBtn.className = "btn btn-success"; + toggleReadBtn.textContent = book.isRead ? "Yes" : "No"; + + toggleReadBtn.addEventListener("click", function () { + book.isRead = !book.isRead; render(); }); - //add delete button to every row and render again - let delButton = document.createElement("button"); - delButton.id = i + 5; - deleteCell.appendChild(delButton); - delButton.className = "btn btn-warning"; - delButton.innerHTML = "Delete"; - delButton.addEventListener("click", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); + readCell.appendChild(toggleReadBtn); + + const deleteBtn = document.createElement("button"); + deleteBtn.className = "btn btn-warning"; + deleteBtn.textContent = "Delete"; + + deleteBtn.addEventListener("click", function () { myLibrary.splice(i, 1); render(); + alert(`Deleted: ${book.title}`); }); + + deleteCell.appendChild(deleteBtn); } } + +window.submit = submit; From c222a65438094adc8147f9d592cbb1b105fbaeed Mon Sep 17 00:00:00 2001 From: Daniel Aderibigbe Date: Mon, 6 Apr 2026 11:01:48 +0100 Subject: [PATCH 3/3] fixed the errors based on reviewers comment --- debugging/book-library/script.js | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 7692e9f6..69ba64b2 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -32,7 +32,7 @@ function submit() { if ( titleValue === "" || authorValue === "" || - !pagesValue || + !Number.isInteger(pagesValue) || pagesValue <= 0 ) { alert("Please enter valid input!"); @@ -64,23 +64,14 @@ function Book(title, author, pages, isRead) { function render() { const table = document.getElementById("display"); + const tbody = table.querySelector("tbody"); - table.innerHTML = ` - - - Title - Author - Number of Pages - Read - - - - `; + tbody.innerHTML = ""; for (let i = 0; i < myLibrary.length; i++) { const book = myLibrary[i]; - const row = table.insertRow(); + const row = tbody.insertRow(); const titleCell = row.insertCell(0); const authorCell = row.insertCell(1); @@ -92,6 +83,7 @@ function render() { authorCell.textContent = book.author; pagesCell.textContent = book.pages; + // toggle read button const toggleReadBtn = document.createElement("button"); toggleReadBtn.className = "btn btn-success"; toggleReadBtn.textContent = book.isRead ? "Yes" : "No"; @@ -103,6 +95,7 @@ function render() { readCell.appendChild(toggleReadBtn); + // delete button const deleteBtn = document.createElement("button"); deleteBtn.className = "btn btn-warning"; deleteBtn.textContent = "Delete";