From 7cc289a9ee4118f3cf68097a70c632c9d2d7ae44 Mon Sep 17 00:00:00 2001 From: pathywang Date: Mon, 30 Mar 2026 22:51:24 +0100 Subject: [PATCH 1/7] correction comparison --- debugging/book-library/script.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..77766ef7 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,6 +1,6 @@ let myLibrary = []; -window.addEventListener("load", function (e) { +window.addEventListener("load", function () { populateStorage(); render(); }); @@ -29,9 +29,8 @@ const check = document.getElementById("check"); //via Book function and start render function function submit() { if ( - title.value == null || - title.value == "" || - pages.value == null || + title.value ==="" || + title.value ==="" || pages.value == "" ) { alert("Please fill all fields!"); From af21b0b7369008931cb3790e949df999b5667302 Mon Sep 17 00:00:00 2001 From: pathywang Date: Mon, 30 Mar 2026 22:55:31 +0100 Subject: [PATCH 2/7] correction declare variable name --- debugging/book-library/script.js | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 77766ef7..f8f491ac 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -6,7 +6,7 @@ window.addEventListener("load", function () { }); function populateStorage() { - if (myLibrary.length == 0) { + if (myLibrary.length === 0) { let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); let book2 = new Book( "The Old Man and the Sea", @@ -29,18 +29,20 @@ const check = document.getElementById("check"); //via Book function and start render function function submit() { if ( - title.value ==="" || - title.value ==="" || - pages.value == "" + title.value === "" || + author.value === "" || + pages.value === "" ) { alert("Please fill all fields!"); return false; - } else { + } + let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); + myLibrary.push(book); + render(); } -} + function Book(title, author, pages, check) { this.title = title; From 1412d9435ab2aa434fde8296ff6bee29a06d5217 Mon Sep 17 00:00:00 2001 From: pathywang Date: Mon, 30 Mar 2026 23:03:32 +0100 Subject: [PATCH 3/7] correction --- debugging/book-library/script.js | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index f8f491ac..cf6aba29 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -53,20 +53,21 @@ function Book(title, author, pages, check) { function render() { let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { - table.deleteRow(n); + + //delete old rows except the header + while (table.rows.length > 1) { + table.deleteRow(1); } //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); + for (let i = 0; i < myLibrary.length; i++) { + let row = table.insertRow(-1); + let titleCell = row.insertCell(0); let authorCell = row.insertCell(1); let pagesCell = row.insertCell(2); let wasReadCell = row.insertCell(3); let deleteCell = row.insertCell(4); + titleCell.innerHTML = myLibrary[i].title; authorCell.innerHTML = myLibrary[i].author; pagesCell.innerHTML = myLibrary[i].pages; From 8dc124724df07cdef1fac1da61b955b7e5ae3112 Mon Sep 17 00:00:00 2001 From: pathywang Date: Mon, 30 Mar 2026 23:06:55 +0100 Subject: [PATCH 4/7] correction --- debugging/book-library/script.js | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index cf6aba29..7dd19839 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -67,16 +67,26 @@ function render() { let pagesCell = row.insertCell(2); let wasReadCell = row.insertCell(3); let deleteCell = row.insertCell(4); - + titleCell.innerHTML = myLibrary[i].title; authorCell.innerHTML = myLibrary[i].author; pagesCell.innerHTML = myLibrary[i].pages; //add and wait for action for read/unread button let changeBut = document.createElement("button"); - changeBut.id = i; changeBut.className = "btn btn-success"; + + // true means read + changeBut.innerText = myLibrary[i].check ? "Yes" : "No"; + + changeBut.addEventListener("click", function () { + myLibrary[i].check = !myLibrary[i].check; + render(); + }); + wasReadCell.appendChild(changeBut); + + let readStatus = ""; if (myLibrary[i].check == false) { readStatus = "Yes"; From e7e1959be41739cd98f0a41d208c12529cf44488 Mon Sep 17 00:00:00 2001 From: pathywang Date: Mon, 30 Mar 2026 23:09:48 +0100 Subject: [PATCH 5/7] correction --- debugging/book-library/script.js | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 7dd19839..637a3665 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -86,30 +86,18 @@ function render() { wasReadCell.appendChild(changeBut); - - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; - - changeBut.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; - render(); - }); //add delete button to every row and render again let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { + delButton.className = "btn btn-warning"; + delButton.innerHTML = "Delete"; + + delButton.addEventListener("click", function () { alert(`You've deleted title: ${myLibrary[i].title}`); myLibrary.splice(i, 1); render(); }); + + deleteCell.appendChild(delButton); } -} +} \ No newline at end of file From 61b3f2d20175664e29c1c3f6a268752daec4bdc0 Mon Sep 17 00:00:00 2001 From: pathywang Date: Wed, 8 Apr 2026 16:15:09 +0100 Subject: [PATCH 6/7] correction --- debugging/book-library/index.html | 75 ++++++++++++++----------------- 1 file changed, 34 insertions(+), 41 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..9a605564 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,20 +1,20 @@ - + - - + + + + Library + + - + > + @@ -27,50 +27,51 @@

Library

Add new book -
-
+
+
- + > + + - + > + + -
+ + +
- +
@@ -80,17 +81,9 @@

Library

- - - - - - - - - +
Title
- + - + \ No newline at end of file From 4df75d169e174cc6c2aead733c9dde22bc0fc16b Mon Sep 17 00:00:00 2001 From: pathywang Date: Wed, 8 Apr 2026 16:27:13 +0100 Subject: [PATCH 7/7] correct with feedback.md --- debugging/book-library/script.js | 148 ++++++++++++++++--------------- 1 file changed, 78 insertions(+), 70 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 637a3665..428ae5b6 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,103 +1,111 @@ -let myLibrary = []; +const myLibrary = []; -window.addEventListener("load", function () { - populateStorage(); +window.addEventListener("load", () => { + populateLibrary(); render(); }); -function populateStorage() { - if (myLibrary.length === 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( - "The Old Man and the Sea", - "Ernest Hemingway", - "127", - true - ); - myLibrary.push(book1); - myLibrary.push(book2); - render(); +function populateLibrary() { + if (myLibrary.length !== 0) { + return; } + + myLibrary.push( + new Book("Robinson Crusoe", "Daniel Defoe", 252, true), + new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true) + ); } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const readCheckbox = document.getElementById("check"); +const tableBody = document.querySelector("#display tbody"); -//check the right input from forms and if its ok -> add the new book (object in array) -//via Book function and start render function function submit() { - if ( - title.value === "" || - author.value === "" || - pages.value === "" - ) { - alert("Please fill all fields!"); - return false; - } - - let book = new Book(title.value, title.value, pages.value, check.checked); - myLibrary.push(book); - - render(); + // .value is always a string, never null + const title = titleInput.value.trim(); + const author = authorInput.value.trim(); + const pages = Number(pagesInput.value); + + // Reject empty strings, whitespace-only strings, invalid page counts + if (title === "" || author === "") { + alert("Title and author cannot be empty."); + return; + } + + if (!Number.isInteger(pages) || pages <= 0) { + alert("Page count must be a positive whole number."); + return; } + myLibrary.push( + new Book(title, author, pages, readCheckbox.checked) + ); -function Book(title, author, pages, check) { + render(); +} + +function Book(title, author, pages, hasRead) { this.title = title; this.author = author; this.pages = pages; - this.check = check; + this.hasRead = hasRead; } function render() { - let table = document.getElementById("display"); + // Clear all existing rows in one operation + tableBody.textContent = ""; - //delete old rows except the header - while (table.rows.length > 1) { - table.deleteRow(1); - } - //insert updated row and cells - for (let i = 0; i < myLibrary.length; i++) { - let row = table.insertRow(-1); + myLibrary.forEach((book, index) => { + const row = document.createElement("tr"); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); + const titleCell = document.createElement("td"); + titleCell.textContent = book.title; - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + const authorCell = document.createElement("td"); + authorCell.textContent = book.author; - //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.className = "btn btn-success"; + const pagesCell = document.createElement("td"); + pagesCell.textContent = book.pages; - // true means read - changeBut.innerText = myLibrary[i].check ? "Yes" : "No"; + const readCell = document.createElement("td"); + const toggleReadButton = document.createElement("button"); + toggleReadButton.className = "btn btn-success"; + toggleReadButton.textContent = book.hasRead ? "Yes" : "No"; - changeBut.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; + toggleReadButton.addEventListener("click", () => { + book.hasRead = !book.hasRead; render(); }); - wasReadCell.appendChild(changeBut); + readCell.appendChild(toggleReadButton); + const deleteCell = document.createElement("td"); + const deleteButton = document.createElement("button"); + deleteButton.className = "btn btn-warning"; + deleteButton.textContent = "Delete"; - //add delete button to every row and render again - let delButton = document.createElement("button"); - delButton.className = "btn btn-warning"; - delButton.innerHTML = "Delete"; + deleteButton.addEventListener("click", () => { + const deletedTitle = book.title; - delButton.addEventListener("click", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); - myLibrary.splice(i, 1); + myLibrary.splice(index, 1); render(); + + alert(`Deleted: ${deletedTitle}`); }); - deleteCell.appendChild(delButton); - } -} \ No newline at end of file + deleteCell.appendChild(deleteButton); + + row.append( + titleCell, + authorCell, + pagesCell, + readCell, + deleteCell + ); + + tableBody.appendChild(row); + }); +} +