From 152abe7c8ac5341a345cf6ab14d24468592d4083 Mon Sep 17 00:00:00 2001 From: Liban Jama Date: Fri, 13 Mar 2026 17:57:40 +0000 Subject: [PATCH 01/13] completed median sprint 1 --- Sprint-1/fix/median.js | 36 +++++++++++++++++++++++++++++++++--- Sprint-1/fix/median.test.js | 22 +++++++++++++++++----- 2 files changed, 50 insertions(+), 8 deletions(-) diff --git a/Sprint-1/fix/median.js b/Sprint-1/fix/median.js index b22590bc6..c24a48fef 100644 --- a/Sprint-1/fix/median.js +++ b/Sprint-1/fix/median.js @@ -6,9 +6,39 @@ // or 'list' has mixed values (the function is expected to sort only numbers). function calculateMedian(list) { - const middleIndex = Math.floor(list.length / 2); - const median = list.splice(middleIndex, 1)[0]; - return median; + // if list is not an array return null. + if (!Array.isArray(list)) { + return null; + } + + // create a variable called numbers and store an empty array. + let numbers = []; + + // loop over each item in list. + for (const item of list) { + // if item is a number, push it into the numbers array. + if (typeof item === "number") { + numbers.push(item); + } + } + + // if numbers array is empty return null. + if (numbers.length === 0) { + return null; + } + + // sort the numbers in the number array in ascending order. + numbers.sort((a, b) => a - b); + + // find the middle index and store it in a variable. + const middleIndex = Math.floor(numbers.length / 2); + + // if its an even array there are two middle indexes, so add them together and divide by two. + if (numbers.length % 2 === 0) { + return (numbers[middleIndex] + numbers[middleIndex - 1]) / 2; + } + // for odd arrays return middle index. + return numbers[middleIndex]; } module.exports = calculateMedian; diff --git a/Sprint-1/fix/median.test.js b/Sprint-1/fix/median.test.js index 21da654d7..c262c3776 100644 --- a/Sprint-1/fix/median.test.js +++ b/Sprint-1/fix/median.test.js @@ -13,7 +13,8 @@ describe("calculateMedian", () => { { input: [1, 2, 3, 4], expected: 2.5 }, { input: [1, 2, 3, 4, 5, 6], expected: 3.5 }, ].forEach(({ input, expected }) => - it(`returns the median for [${input}]`, () => expect(calculateMedian(input)).toEqual(expected)) + it(`returns the median for [${input}]`, () => + expect(calculateMedian(input)).toEqual(expected)) ); [ @@ -24,7 +25,8 @@ describe("calculateMedian", () => { { input: [110, 20, 0], expected: 20 }, { input: [6, -2, 2, 12, 14], expected: 6 }, ].forEach(({ input, expected }) => - it(`returns the correct median for unsorted array [${input}]`, () => expect(calculateMedian(input)).toEqual(expected)) + it(`returns the correct median for unsorted array [${input}]`, () => + expect(calculateMedian(input)).toEqual(expected)) ); it("doesn't modify the input array [3, 1, 2]", () => { @@ -33,8 +35,17 @@ describe("calculateMedian", () => { expect(list).toEqual([3, 1, 2]); }); - [ 'not an array', 123, null, undefined, {}, [], ["apple", null, undefined] ].forEach(val => - it(`returns null for non-numeric array (${val})`, () => expect(calculateMedian(val)).toBe(null)) + [ + "not an array", + 123, + null, + undefined, + {}, + [], + ["apple", null, undefined], + ].forEach((val) => + it(`returns null for non-numeric array (${val})`, () => + expect(calculateMedian(val)).toBe(null)) ); [ @@ -45,6 +56,7 @@ describe("calculateMedian", () => { { input: [3, "apple", 1, null, 2, undefined, 4], expected: 2.5 }, { input: ["banana", 5, 3, "apple", 1, 4, 2], expected: 3 }, ].forEach(({ input, expected }) => - it(`filters out non-numeric values and calculates the median for [${input}]`, () => expect(calculateMedian(input)).toEqual(expected)) + it(`filters out non-numeric values and calculates the median for [${input}]`, () => + expect(calculateMedian(input)).toEqual(expected)) ); }); From 7bc29b05de29534c962c5af566f7c90e0b5d2015 Mon Sep 17 00:00:00 2001 From: Liban Jama Date: Mon, 16 Mar 2026 13:00:28 +0000 Subject: [PATCH 02/13] completed implement --- Sprint-1/implement/dedupe.js | 13 ++++++++++++- Sprint-1/implement/dedupe.test.js | 4 +++- Sprint-1/implement/max.js | 16 +++++++++++++++- Sprint-1/implement/max.test.js | 28 +++++++++++++++++++++++++++- Sprint-1/implement/sum.js | 9 +++++++++ Sprint-1/implement/sum.test.js | 24 +++++++++++++++++++++++- 6 files changed, 89 insertions(+), 5 deletions(-) diff --git a/Sprint-1/implement/dedupe.js b/Sprint-1/implement/dedupe.js index 781e8718a..f10b813d2 100644 --- a/Sprint-1/implement/dedupe.js +++ b/Sprint-1/implement/dedupe.js @@ -1 +1,12 @@ -function dedupe() {} +function dedupe(elements) { + const result = []; + for (let i = 0; i < elements.length; i++) { + if (!result.includes(elements[i])) { + result.push(elements[i]); + } + } + + return result; +} + +module.exports = dedupe; diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index 23e0f8638..f655bfdc7 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -16,7 +16,9 @@ E.g. dedupe([1, 2, 1]) target output: [1, 2] // Given an empty array // When passed to the dedupe function // Then it should return an empty array -test.todo("given an empty array, it returns an empty array"); +test("given an empty array, it returns an empty array", () => { + expect(dedupe([])).toEqual([]); +}); // Given an array with no duplicates // When passed to the dedupe function diff --git a/Sprint-1/implement/max.js b/Sprint-1/implement/max.js index 6dd76378e..09c343f8a 100644 --- a/Sprint-1/implement/max.js +++ b/Sprint-1/implement/max.js @@ -1,4 +1,18 @@ function findMax(elements) { -} + const numbersOnly = elements.filter((e) => typeof e === "number"); + + if (numbersOnly.length === 0) { + return -Infinity; + } + + let max = numbersOnly[0]; + for (let i = 1; i < numbersOnly.length; i++) { + if (numbersOnly[i] > max) { + max = numbersOnly[i]; + } + } + + return max; +} module.exports = findMax; diff --git a/Sprint-1/implement/max.test.js b/Sprint-1/implement/max.test.js index 82f18fd88..498fd0e40 100644 --- a/Sprint-1/implement/max.test.js +++ b/Sprint-1/implement/max.test.js @@ -16,28 +16,54 @@ const findMax = require("./max.js"); // When passed to the max function // Then it should return -Infinity // Delete this test.todo and replace it with a test. -test.todo("given an empty array, returns -Infinity"); +test("given an empty array, returns -Infinity", () => { + expect(findMax([])).toBe(-Infinity); +}); // Given an array with one number // When passed to the max function // Then it should return that number +test("given an array with one number, returns that number", () => { + expect(findMax([7])).toBe(7); +}); + // Given an array with both positive and negative numbers // When passed to the max function // Then it should return the largest number overall +test("given positive and negative numbers, returns the largest number", () => { + expect(findMax([-3, 7, -2, 5])).toBe(7); +}); + // Given an array with just negative numbers // When passed to the max function // Then it should return the closest one to zero +test("given an array with only negative numbers, returns the closest to zero", () => { + expect(findMax([-10, -3, -7])).toBe(-3); +}); + // Given an array with decimal numbers // When passed to the max function // Then it should return the largest decimal number +test("given an array with decimal numbers, returns the clargest decimal number", () => { + expect(findMax([2.7, 6.9, 10.1])).toBe(10.1); +}); + // Given an array with non-number values // When passed to the max function // Then it should return the max and ignore non-numeric values +test("given an array with non-number values, returns the max and ignore non-numeric values", () => { + expect(findMax([3, "dogs", 1, "cat", null])).toBe(3); +}); + // Given an array with only non-number values // When passed to the max function // Then it should return the least surprising value given how it behaves for all other inputs + +test("given an array with only non-number values, returns -Infinity", () => { + expect(findMax(["a", null, true, undefined])).toBe(-Infinity); +}); diff --git a/Sprint-1/implement/sum.js b/Sprint-1/implement/sum.js index 9062aafe3..65ee1f272 100644 --- a/Sprint-1/implement/sum.js +++ b/Sprint-1/implement/sum.js @@ -1,4 +1,13 @@ function sum(elements) { + let total = 0; + + for (let i = 0; i < elements.length; i++) { + if (typeof elements[i] === "number") { + total += elements[i]; + } + } + + return total; } module.exports = sum; diff --git a/Sprint-1/implement/sum.test.js b/Sprint-1/implement/sum.test.js index dd0a090ca..226acf8fa 100644 --- a/Sprint-1/implement/sum.test.js +++ b/Sprint-1/implement/sum.test.js @@ -13,24 +13,46 @@ const sum = require("./sum.js"); // Given an empty array // When passed to the sum function // Then it should return 0 -test.todo("given an empty array, returns 0") +test("given an empty array, returns 0", () => { + expect(sum([])).toBe(0); +}); // Given an array with just one number // When passed to the sum function // Then it should return that number +test("given an array with one number, returns that number", () => { + expect(sum([42])).toBe(42); +}); + // Given an array containing negative numbers // When passed to the sum function // Then it should still return the correct total sum +test("given an array containing negative numbers", () => { + expect(sum([-5, -6, -1])).toBe(-12); +}); + // Given an array with decimal/float numbers // When passed to the sum function // Then it should return the correct total sum +test("given an array with decimal/float numbers, returns the correct total sum", () => { + expect(sum([2.75, -0.3, 0.0002])).toBeCloseTo(2.4502); +}); + // Given an array containing non-number values // When passed to the sum function // Then it should ignore the non-numerical values and return the sum of the numerical elements +test("given an array containing non-number values, ignore the non-numerical values and return the sum of the numerical elements", () => { + expect(sum(["hello", 6, true, 14])).toBe(20); +}); + // Given an array with only non-number values // When passed to the sum function // Then it should return the least surprising value given how it behaves for all other inputs + +test("given an array with only non-number values, returns 0", () => { + expect(sum(["hello", undefined, "today", true])).toBe(0); +}); From 9f5cc0a4505e229074a2d0ed4f3b53fc8d25c20c Mon Sep 17 00:00:00 2001 From: Liban Jama Date: Mon, 16 Mar 2026 13:20:31 +0000 Subject: [PATCH 03/13] Completed includes.js --- Sprint-1/refactor/includes.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Sprint-1/refactor/includes.js b/Sprint-1/refactor/includes.js index 29dad81f0..8c9ae2e66 100644 --- a/Sprint-1/refactor/includes.js +++ b/Sprint-1/refactor/includes.js @@ -1,8 +1,7 @@ // Refactor the implementation of includes to use a for...of loop function includes(list, target) { - for (let index = 0; index < list.length; index++) { - const element = list[index]; + for (const element of list) { if (element === target) { return true; } From dca5a952de200f596f56d40e7a2d6aec315481ae Mon Sep 17 00:00:00 2001 From: Liban Jama Date: Fri, 27 Mar 2026 19:19:02 +0000 Subject: [PATCH 04/13] used .filter and isFinite --- Sprint-1/fix/median.js | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/Sprint-1/fix/median.js b/Sprint-1/fix/median.js index c24a48fef..dbd87e607 100644 --- a/Sprint-1/fix/median.js +++ b/Sprint-1/fix/median.js @@ -11,16 +11,10 @@ function calculateMedian(list) { return null; } - // create a variable called numbers and store an empty array. - let numbers = []; - - // loop over each item in list. - for (const item of list) { - // if item is a number, push it into the numbers array. - if (typeof item === "number") { - numbers.push(item); - } - } + // filter the list to include only valid numbers (excludes Infinity, -Infinity, and NaN) + const numbers = list.filter( + (item) => typeof item === "number" && Number.isFinite(item) + ); // if numbers array is empty return null. if (numbers.length === 0) { From a4668aa4ed4b03d2a8deb524e1b9c3c53ad4669e Mon Sep 17 00:00:00 2001 From: Liban Jama Date: Fri, 27 Mar 2026 19:45:01 +0000 Subject: [PATCH 05/13] added isFinite check to sum.js --- Sprint-1/implement/sum.js | 3 +-- Sprint-1/implement/sum.test.js | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Sprint-1/implement/sum.js b/Sprint-1/implement/sum.js index 65ee1f272..206f57da2 100644 --- a/Sprint-1/implement/sum.js +++ b/Sprint-1/implement/sum.js @@ -2,11 +2,10 @@ function sum(elements) { let total = 0; for (let i = 0; i < elements.length; i++) { - if (typeof elements[i] === "number") { + if (typeof elements[i] === "number" && Number.isFinite(elements[i])) { total += elements[i]; } } - return total; } diff --git a/Sprint-1/implement/sum.test.js b/Sprint-1/implement/sum.test.js index 226acf8fa..078978add 100644 --- a/Sprint-1/implement/sum.test.js +++ b/Sprint-1/implement/sum.test.js @@ -56,3 +56,10 @@ test("given an array containing non-number values, ignore the non-numerical valu test("given an array with only non-number values, returns 0", () => { expect(sum(["hello", undefined, "today", true])).toBe(0); }); + +// Given an array including NaN +// When passed to the sum function +// Then it should ignore the NaN value +test("given an array that include NaN returns correct answer", () => { + expect(sum([7, 14, NaN])).toBe(21); +}); From 560de0034d53a0b8b1c900171811bd96b6209704 Mon Sep 17 00:00:00 2001 From: Liban Jama Date: Fri, 27 Mar 2026 20:04:40 +0000 Subject: [PATCH 06/13] Added isFinite to max.js --- Sprint-1/implement/max.js | 4 +++- Sprint-1/implement/max.test.js | 7 +++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/Sprint-1/implement/max.js b/Sprint-1/implement/max.js index 09c343f8a..e65aa5bc0 100644 --- a/Sprint-1/implement/max.js +++ b/Sprint-1/implement/max.js @@ -1,5 +1,7 @@ function findMax(elements) { - const numbersOnly = elements.filter((e) => typeof e === "number"); + const numbersOnly = elements.filter( + (e) => typeof e === "number" && Number.isFinite(e) + ); if (numbersOnly.length === 0) { return -Infinity; diff --git a/Sprint-1/implement/max.test.js b/Sprint-1/implement/max.test.js index 498fd0e40..7b3d7cee8 100644 --- a/Sprint-1/implement/max.test.js +++ b/Sprint-1/implement/max.test.js @@ -67,3 +67,10 @@ test("given an array with non-number values, returns the max and ignore non-nume test("given an array with only non-number values, returns -Infinity", () => { expect(findMax(["a", null, true, undefined])).toBe(-Infinity); }); + +// Given an array with Nan +// When passed to the max function +// Then it should return the correct total +test("given an array including Nan return correct total", () => { + expect(findMax([11, NaN, 5])).toBe(11); +}); From e6c96f735af255e9dd309ce578f1399d7912fe36 Mon Sep 17 00:00:00 2001 From: Liban Jama Date: Fri, 27 Mar 2026 20:13:19 +0000 Subject: [PATCH 07/13] Added tests --- Sprint-1/implement/dedupe.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index f655bfdc7..561041564 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -23,7 +23,13 @@ test("given an empty array, it returns an empty array", () => { // Given an array with no duplicates // When passed to the dedupe function // Then it should return a copy of the original array +test("given an array with no duplicates, it should return a copy of the original array", () => { + expect(dedupe(["a", "b", "c"])).toEqual(["a", "b", "c"]); +}); // Given an array with strings or numbers // When passed to the dedupe function // Then it should remove the duplicate values, preserving the first occurence of each element +test("given an array with strings, it should remove the duplicate values, preserving the first occurence of each element", () => { + expect(dedupe(["a", "a", "a", "b", "b", "c"])).toEqual(["a", "b", "c"]); +}); From 7d83b62c25d5691e62cf8ddc97be228aef81baf7 Mon Sep 17 00:00:00 2001 From: Liban Jama Date: Fri, 27 Mar 2026 20:24:26 +0000 Subject: [PATCH 08/13] Added test for numeric string --- Sprint-1/implement/max.test.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Sprint-1/implement/max.test.js b/Sprint-1/implement/max.test.js index 7b3d7cee8..9d1fae44d 100644 --- a/Sprint-1/implement/max.test.js +++ b/Sprint-1/implement/max.test.js @@ -74,3 +74,10 @@ test("given an array with only non-number values, returns -Infinity", () => { test("given an array including Nan return correct total", () => { expect(findMax([11, NaN, 5])).toBe(11); }); + +// Given an array with numeric string value +// When passed to the max function +// Then it should ignore the numeric string and return correct total +test("given an array with numeric string value, it should ignore the numeric string and return correct total", () => { + expect(findMax([8, "14", 2])).toBe(8); +}); From 32ffac4ebd4fe754b0e31b1ee4c9c2762d6ce18c Mon Sep 17 00:00:00 2001 From: Liban Jama Date: Sat, 28 Mar 2026 09:00:25 +0000 Subject: [PATCH 09/13] updated test --- Sprint-1/implement/dedupe.test.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index 561041564..b1c1c702d 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -24,7 +24,11 @@ test("given an empty array, it returns an empty array", () => { // When passed to the dedupe function // Then it should return a copy of the original array test("given an array with no duplicates, it should return a copy of the original array", () => { - expect(dedupe(["a", "b", "c"])).toEqual(["a", "b", "c"]); + const input = ["a", "b", "c"]; + const result = dedupe(input); + + expect(result).toEqual(input); + expect(result).not.toBe(input); }); // Given an array with strings or numbers From cbfd6c4cea529c9efc03e711bb58e5445b7f1f19 Mon Sep 17 00:00:00 2001 From: Liban Jama Date: Sat, 28 Mar 2026 09:10:57 +0000 Subject: [PATCH 10/13] updated test description --- Sprint-1/implement/max.test.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Sprint-1/implement/max.test.js b/Sprint-1/implement/max.test.js index 9d1fae44d..05d135a65 100644 --- a/Sprint-1/implement/max.test.js +++ b/Sprint-1/implement/max.test.js @@ -70,14 +70,14 @@ test("given an array with only non-number values, returns -Infinity", () => { // Given an array with Nan // When passed to the max function -// Then it should return the correct total -test("given an array including Nan return correct total", () => { +// Then it should return the correct maximum value +test("given an array including Nan return correct maximum value", () => { expect(findMax([11, NaN, 5])).toBe(11); }); // Given an array with numeric string value // When passed to the max function -// Then it should ignore the numeric string and return correct total -test("given an array with numeric string value, it should ignore the numeric string and return correct total", () => { +// Then it should ignore the numeric string and return correct maximum value +test("given an array with numeric string value, it should ignore the numeric string and return correct maximum value", () => { expect(findMax([8, "14", 2])).toBe(8); }); From 51192fce966f6d4fa63d3a2a2e66906333806046 Mon Sep 17 00:00:00 2001 From: Liban Jama Date: Sat, 28 Mar 2026 09:23:10 +0000 Subject: [PATCH 11/13] updated test --- Sprint-1/implement/dedupe.test.js | 1 + 1 file changed, 1 insertion(+) diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index b1c1c702d..37dafc899 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -27,6 +27,7 @@ test("given an array with no duplicates, it should return a copy of the original const input = ["a", "b", "c"]; const result = dedupe(input); + expect(result).toHaveLength(input.length); expect(result).toEqual(input); expect(result).not.toBe(input); }); From aa9ddca9595317119249b60ff9640a2340c24066 Mon Sep 17 00:00:00 2001 From: Liban Jama Date: Sat, 28 Mar 2026 14:58:31 +0000 Subject: [PATCH 12/13] added test --- Sprint-1/implement/dedupe.test.js | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index 37dafc899..370f95726 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -32,6 +32,18 @@ test("given an array with no duplicates, it should return a copy of the original expect(result).not.toBe(input); }); +// Given an array of strings +// When passed to the dedupe function +// Then it should not modify the original array +test("given an array with strings, it should not modify the original array", () => { + const input = ["a", "b", "c"]; + const original = ["a", "b", "c"]; + + dedupe(input); + + expect(input).toEqual(original); +}); + // Given an array with strings or numbers // When passed to the dedupe function // Then it should remove the duplicate values, preserving the first occurence of each element From 44c82b2a6af3fa9bafa0b6a596e5783c9a92c384 Mon Sep 17 00:00:00 2001 From: Liban Jama Date: Sat, 28 Mar 2026 15:37:35 +0000 Subject: [PATCH 13/13] combined tests --- Sprint-1/implement/dedupe.test.js | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index 370f95726..8a1a8c871 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -32,21 +32,15 @@ test("given an array with no duplicates, it should return a copy of the original expect(result).not.toBe(input); }); -// Given an array of strings +// Given an array with strings // When passed to the dedupe function -// Then it should not modify the original array -test("given an array with strings, it should not modify the original array", () => { - const input = ["a", "b", "c"]; - const original = ["a", "b", "c"]; +// Then it should remove duplicates and not modify the original array +test("given an array with strings, it should remove duplicates and preserve the original array", () => { + const input = ["a", "a", "a", "b", "b", "c"]; + const original = [...input]; - dedupe(input); + const result = dedupe(input); + expect(result).toEqual(["a", "b", "c"]); expect(input).toEqual(original); }); - -// Given an array with strings or numbers -// When passed to the dedupe function -// Then it should remove the duplicate values, preserving the first occurence of each element -test("given an array with strings, it should remove the duplicate values, preserving the first occurence of each element", () => { - expect(dedupe(["a", "a", "a", "b", "b", "c"])).toEqual(["a", "b", "c"]); -});