From c4b663d872ba5b7f815e70c1adfe499d1b2a1ded Mon Sep 17 00:00:00 2001 From: Richard Frimpong Date: Fri, 13 Mar 2026 20:27:59 +0000 Subject: [PATCH 1/6] Fix median implementation in sprint 1 fix project --- Sprint-1/fix/median.js | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/Sprint-1/fix/median.js b/Sprint-1/fix/median.js index b22590bc6..abb7fd2e9 100644 --- a/Sprint-1/fix/median.js +++ b/Sprint-1/fix/median.js @@ -6,9 +6,33 @@ // or 'list' has mixed values (the function is expected to sort only numbers). function calculateMedian(list) { - const middleIndex = Math.floor(list.length / 2); - const median = list.splice(middleIndex, 1)[0]; - return median; + // Return null immediately if the input is not an array + if (!Array.isArray(list)) { + return null; + } + + // Keep only real numeric values + const numbersOnly = list.filter( + (item) => typeof item === "number" && !Number.isNaN(item) + ); + + // Return null if the array contains no numbers + if (numbersOnly.length === 0) { + return null; + } + + // Create a sorted copy so the original input is not changed + const sortedNumbers = [...numbersOnly].sort((a, b) => a - b); + + const middleIndex = Math.floor(sortedNumbers.length / 2); + + // For an even-length array, median is the average of the two middle values + if (sortedNumbers.length % 2 === 0) { + return (sortedNumbers[middleIndex - 1] + sortedNumbers[middleIndex]) / 2; + } + + // For an odd-length array, median is the middle value + return sortedNumbers[middleIndex]; } module.exports = calculateMedian; From 4ee9bf8efd19993b53f06617761a81af933febf6 Mon Sep 17 00:00:00 2001 From: Richard Frimpong Date: Fri, 13 Mar 2026 21:22:28 +0000 Subject: [PATCH 2/6] Implement sprint 1 array exercises --- Sprint-1/implement/dedupe.js | 18 +++++++++++++++++- Sprint-1/implement/dedupe.test.js | 20 ++++++++++++++++++-- Sprint-1/implement/max.js | 15 +++++++++++++++ Sprint-1/implement/max.test.js | 23 +++++++++++++++++++++-- Sprint-1/implement/sum.js | 13 +++++++++++++ Sprint-1/implement/sum.test.js | 19 ++++++++++++++++++- 6 files changed, 102 insertions(+), 6 deletions(-) diff --git a/Sprint-1/implement/dedupe.js b/Sprint-1/implement/dedupe.js index 781e8718a..f8494b4a5 100644 --- a/Sprint-1/implement/dedupe.js +++ b/Sprint-1/implement/dedupe.js @@ -1 +1,17 @@ -function dedupe() {} +// Return a new array with duplicate values removed. +// Keep the first occurrence of each value. + +function dedupe(elements) { + const uniqueElements = []; + + for (const element of elements) { + // Add the element only if it is not already in the result array + if (!uniqueElements.includes(element)) { + uniqueElements.push(element); + } + } + + return uniqueElements; +} + +module.exports = dedupe; diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index 23e0f8638..0360f8e81 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -2,7 +2,7 @@ const dedupe = require("./dedupe.js"); /* Dedupe Array -📖 Dedupe means **deduplicate** +📖 Dedupe means deduplicate In this kata, you will need to deduplicate the elements of an array @@ -16,12 +16,28 @@ E.g. dedupe([1, 2, 1]) target output: [1, 2] // Given an empty array // When passed to the dedupe function // Then it should return an empty array -test.todo("given an empty array, it returns an empty array"); +test("given an empty array, it returns an empty array", () => { + expect(dedupe([])).toEqual([]); +}); // Given an array with no duplicates // When passed to the dedupe function // Then it should return a copy of the original array +test("given an array with no duplicates, it returns the same values", () => { + expect(dedupe([1, 2, 3])).toEqual([1, 2, 3]); +}); // Given an array with strings or numbers // When passed to the dedupe function // Then it should remove the duplicate values, preserving the first occurence of each element +test("given an array with duplicate strings, removes duplicates and preserves first occurrence", () => { + expect(dedupe(["a", "a", "a", "b", "b", "c"])).toEqual(["a", "b", "c"]); +}); + +test("given an array with duplicate numbers, removes duplicates and preserves first occurrence", () => { + expect(dedupe([5, 1, 1, 2, 3, 2, 5, 8])).toEqual([5, 1, 2, 3, 8]); +}); + +test("given a mixed duplicate order, removes duplicates and preserves first occurrence", () => { + expect(dedupe([1, 2, 1])).toEqual([1, 2]); +}); diff --git a/Sprint-1/implement/max.js b/Sprint-1/implement/max.js index 6dd76378e..df7d3f86b 100644 --- a/Sprint-1/implement/max.js +++ b/Sprint-1/implement/max.js @@ -1,4 +1,19 @@ +// Find the largest numerical value in an array. +// Non-number values should be ignored. + function findMax(elements) { + let maxValue = -Infinity; + + for (const element of elements) { + // Only compare values that are real numbers + if (typeof element === "number" && !Number.isNaN(element)) { + if (element > maxValue) { + maxValue = element; + } + } + } + + return maxValue; } module.exports = findMax; diff --git a/Sprint-1/implement/max.test.js b/Sprint-1/implement/max.test.js index 82f18fd88..95f92f165 100644 --- a/Sprint-1/implement/max.test.js +++ b/Sprint-1/implement/max.test.js @@ -15,29 +15,48 @@ const findMax = require("./max.js"); // Given an empty array // When passed to the max function // Then it should return -Infinity -// Delete this test.todo and replace it with a test. -test.todo("given an empty array, returns -Infinity"); +test("given an empty array, returns -Infinity", () => { + expect(findMax([])).toBe(-Infinity); +}); // Given an array with one number // When passed to the max function // Then it should return that number +test("given an array with one number, returns that number", () => { + expect(findMax([42])).toBe(42); +}); // Given an array with both positive and negative numbers // When passed to the max function // Then it should return the largest number overall +test("given an array with positive and negative numbers, returns the largest number", () => { + expect(findMax([-10, 3, 25, -1])).toBe(25); +}); // Given an array with just negative numbers // When passed to the max function // Then it should return the closest one to zero +test("given an array with only negative numbers, returns the largest one", () => { + expect(findMax([-9, -2, -15, -4])).toBe(-2); +}); // Given an array with decimal numbers // When passed to the max function // Then it should return the largest decimal number +test("given an array with decimal numbers, returns the largest decimal", () => { + expect(findMax([1.2, 3.8, 2.4])).toBe(3.8); +}); // Given an array with non-number values // When passed to the max function // Then it should return the max and ignore non-numeric values +test("given an array with non-number values, ignores them and returns the max", () => { + expect(findMax(["hey", 10, "hi", 60, 10])).toBe(60); +}); // Given an array with only non-number values // When passed to the max function // Then it should return the least surprising value given how it behaves for all other inputs +test("given an array with only non-number values, returns -Infinity", () => { + expect(findMax(["apple", null, undefined, "banana"])).toBe(-Infinity); +}); diff --git a/Sprint-1/implement/sum.js b/Sprint-1/implement/sum.js index 9062aafe3..1a0c9ddb3 100644 --- a/Sprint-1/implement/sum.js +++ b/Sprint-1/implement/sum.js @@ -1,4 +1,17 @@ +// Sum the numerical values in an array. +// Non-number values should be ignored. + function sum(elements) { + let total = 0; + + for (const element of elements) { + // Only add values that are real numbers + if (typeof element === "number" && !Number.isNaN(element)) { + total += element; + } + } + + return total; } module.exports = sum; diff --git a/Sprint-1/implement/sum.test.js b/Sprint-1/implement/sum.test.js index dd0a090ca..67e440741 100644 --- a/Sprint-1/implement/sum.test.js +++ b/Sprint-1/implement/sum.test.js @@ -13,24 +13,41 @@ const sum = require("./sum.js"); // Given an empty array // When passed to the sum function // Then it should return 0 -test.todo("given an empty array, returns 0") +test("given an empty array, returns 0", () => { + expect(sum([])).toBe(0); +}); // Given an array with just one number // When passed to the sum function // Then it should return that number +test("given an array with one number, returns that number", () => { + expect(sum([7])).toBe(7); +}); // Given an array containing negative numbers // When passed to the sum function // Then it should still return the correct total sum +test("given an array with negative numbers, returns the correct sum", () => { + expect(sum([-5, 10, -2])).toBe(3); +}); // Given an array with decimal/float numbers // When passed to the sum function // Then it should return the correct total sum +test("given an array with decimal numbers, returns the correct sum", () => { + expect(sum([1.5, 2.5, 3])).toBe(7); +}); // Given an array containing non-number values // When passed to the sum function // Then it should ignore the non-numerical values and return the sum of the numerical elements +test("given an array with non-number values, ignores them and sums only numbers", () => { + expect(sum(["hey", 10, "hi", 60, 10])).toBe(80); +}); // Given an array with only non-number values // When passed to the sum function // Then it should return the least surprising value given how it behaves for all other inputs +test("given an array with only non-number values, returns 0", () => { + expect(sum(["apple", null, undefined, "banana"])).toBe(0); +}); From 1b6cc9b1f4c6bf23abe8aa1d9307f6de9e697a2f Mon Sep 17 00:00:00 2001 From: Richard Frimpong Date: Fri, 13 Mar 2026 21:34:50 +0000 Subject: [PATCH 3/6] Refactor includes implementation to use for...of loop --- Sprint-1/refactor/includes.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Sprint-1/refactor/includes.js b/Sprint-1/refactor/includes.js index 29dad81f0..145603948 100644 --- a/Sprint-1/refactor/includes.js +++ b/Sprint-1/refactor/includes.js @@ -1,12 +1,15 @@ // Refactor the implementation of includes to use a for...of loop function includes(list, target) { - for (let index = 0; index < list.length; index++) { - const element = list[index]; + // Loop through each element in the list using a for...of loop + for (const element of list) { + // If the current element matches the target, return true if (element === target) { return true; } } + + // If the loop finishes without finding the target, return false return false; } From 2993b07048f401c8f5024f3040892c7fb69296f3 Mon Sep 17 00:00:00 2001 From: Richard Frimpong Date: Thu, 19 Mar 2026 01:49:14 +0000 Subject: [PATCH 4/6] Address mentor feedback for sprint 1 data groups --- Sprint-1/fix/median.js | 19 +++++++++++++++++++ Sprint-1/implement/dedupe.test.js | 13 +++++++++++++ Sprint-1/implement/max.js | 5 +++++ Sprint-1/implement/max.test.js | 4 ++++ Sprint-1/implement/sum.js | 4 ++++ Sprint-1/implement/sum.test.js | 4 ++++ 6 files changed, 49 insertions(+) diff --git a/Sprint-1/fix/median.js b/Sprint-1/fix/median.js index abb7fd2e9..11f4ef59f 100644 --- a/Sprint-1/fix/median.js +++ b/Sprint-1/fix/median.js @@ -11,27 +11,46 @@ function calculateMedian(list) { return null; } +<<<<<<< HEAD // Keep only real numeric values const numbersOnly = list.filter( (item) => typeof item === "number" && !Number.isNaN(item) ); // Return null if the array contains no numbers +======= + // filter() returns a new array, so this does not modify the original input + const numbersOnly = list.filter((item) => Number.isFinite(item)); + + // Return null if there are no numeric values +>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) if (numbersOnly.length === 0) { return null; } +<<<<<<< HEAD // Create a sorted copy so the original input is not changed const sortedNumbers = [...numbersOnly].sort((a, b) => a - b); const middleIndex = Math.floor(sortedNumbers.length / 2); // For an even-length array, median is the average of the two middle values +======= + // Safe to sort directly because numbersOnly is already a new array + const sortedNumbers = numbersOnly.sort((a, b) => a - b); + const middleIndex = Math.floor(sortedNumbers.length / 2); + + // Even number of values: return the average of the two middle values +>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) if (sortedNumbers.length % 2 === 0) { return (sortedNumbers[middleIndex - 1] + sortedNumbers[middleIndex]) / 2; } +<<<<<<< HEAD // For an odd-length array, median is the middle value +======= + // Odd number of values: return the middle value +>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) return sortedNumbers[middleIndex]; } diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index 0360f8e81..a1cc9b404 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -2,7 +2,11 @@ const dedupe = require("./dedupe.js"); /* Dedupe Array +<<<<<<< HEAD 📖 Dedupe means deduplicate +======= + Dedupe means deduplicate +>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) In this kata, you will need to deduplicate the elements of an array @@ -23,8 +27,17 @@ test("given an empty array, it returns an empty array", () => { // Given an array with no duplicates // When passed to the dedupe function // Then it should return a copy of the original array +<<<<<<< HEAD test("given an array with no duplicates, it returns the same values", () => { expect(dedupe([1, 2, 3])).toEqual([1, 2, 3]); +======= +test("given an array with no duplicates, it returns a copy of the original array", () => { + const input = [1, 2, 3]; + const result = dedupe(input); + + expect(result).toEqual(input); + expect(result).not.toBe(input); +>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) }); // Given an array with strings or numbers diff --git a/Sprint-1/implement/max.js b/Sprint-1/implement/max.js index df7d3f86b..3e0d7fdc5 100644 --- a/Sprint-1/implement/max.js +++ b/Sprint-1/implement/max.js @@ -5,11 +5,16 @@ function findMax(elements) { let maxValue = -Infinity; for (const element of elements) { +<<<<<<< HEAD // Only compare values that are real numbers if (typeof element === "number" && !Number.isNaN(element)) { if (element > maxValue) { maxValue = element; } +======= + if (Number.isFinite(element) && element > maxValue) { + maxValue = element; +>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) } } diff --git a/Sprint-1/implement/max.test.js b/Sprint-1/implement/max.test.js index 95f92f165..0b586673f 100644 --- a/Sprint-1/implement/max.test.js +++ b/Sprint-1/implement/max.test.js @@ -51,7 +51,11 @@ test("given an array with decimal numbers, returns the largest decimal", () => { // When passed to the max function // Then it should return the max and ignore non-numeric values test("given an array with non-number values, ignores them and returns the max", () => { +<<<<<<< HEAD expect(findMax(["hey", 10, "hi", 60, 10])).toBe(60); +======= + expect(findMax(["hey", 10, "300", "hi", 60, 10])).toBe(60); +>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) }); // Given an array with only non-number values diff --git a/Sprint-1/implement/sum.js b/Sprint-1/implement/sum.js index 1a0c9ddb3..806e3fbe3 100644 --- a/Sprint-1/implement/sum.js +++ b/Sprint-1/implement/sum.js @@ -5,8 +5,12 @@ function sum(elements) { let total = 0; for (const element of elements) { +<<<<<<< HEAD // Only add values that are real numbers if (typeof element === "number" && !Number.isNaN(element)) { +======= + if (Number.isFinite(element)) { +>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) total += element; } } diff --git a/Sprint-1/implement/sum.test.js b/Sprint-1/implement/sum.test.js index 67e440741..f87cbf953 100644 --- a/Sprint-1/implement/sum.test.js +++ b/Sprint-1/implement/sum.test.js @@ -35,7 +35,11 @@ test("given an array with negative numbers, returns the correct sum", () => { // When passed to the sum function // Then it should return the correct total sum test("given an array with decimal numbers, returns the correct sum", () => { +<<<<<<< HEAD expect(sum([1.5, 2.5, 3])).toBe(7); +======= + expect(sum([1.2, 0.6, 0.005])).toBeCloseTo(1.805, 10); +>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) }); // Given an array containing non-number values From 8bd7f4ed9d37c85648fa172d9d4dfb7d8e3edad2 Mon Sep 17 00:00:00 2001 From: Richard Frimpong Date: Fri, 20 Mar 2026 02:25:19 +0000 Subject: [PATCH 5/6] Resolve sprint 1 merge conflicts and apply mentor feedback --- Sprint-1/fix/median.js | 22 ---------------------- Sprint-1/implement/dedupe.test.js | 9 --------- Sprint-1/implement/max.js | 10 +--------- Sprint-1/implement/max.test.js | 4 ---- Sprint-1/implement/sum.js | 5 ----- Sprint-1/implement/sum.test.js | 4 ---- 6 files changed, 1 insertion(+), 53 deletions(-) diff --git a/Sprint-1/fix/median.js b/Sprint-1/fix/median.js index 11f4ef59f..01b74c403 100644 --- a/Sprint-1/fix/median.js +++ b/Sprint-1/fix/median.js @@ -11,46 +11,24 @@ function calculateMedian(list) { return null; } -<<<<<<< HEAD - // Keep only real numeric values - const numbersOnly = list.filter( - (item) => typeof item === "number" && !Number.isNaN(item) - ); - - // Return null if the array contains no numbers -======= // filter() returns a new array, so this does not modify the original input const numbersOnly = list.filter((item) => Number.isFinite(item)); // Return null if there are no numeric values ->>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) if (numbersOnly.length === 0) { return null; } -<<<<<<< HEAD - // Create a sorted copy so the original input is not changed - const sortedNumbers = [...numbersOnly].sort((a, b) => a - b); - - const middleIndex = Math.floor(sortedNumbers.length / 2); - - // For an even-length array, median is the average of the two middle values -======= // Safe to sort directly because numbersOnly is already a new array const sortedNumbers = numbersOnly.sort((a, b) => a - b); const middleIndex = Math.floor(sortedNumbers.length / 2); // Even number of values: return the average of the two middle values ->>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) if (sortedNumbers.length % 2 === 0) { return (sortedNumbers[middleIndex - 1] + sortedNumbers[middleIndex]) / 2; } -<<<<<<< HEAD - // For an odd-length array, median is the middle value -======= // Odd number of values: return the middle value ->>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) return sortedNumbers[middleIndex]; } diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index a1cc9b404..1bcda7a54 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -2,11 +2,7 @@ const dedupe = require("./dedupe.js"); /* Dedupe Array -<<<<<<< HEAD 📖 Dedupe means deduplicate -======= - Dedupe means deduplicate ->>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) In this kata, you will need to deduplicate the elements of an array @@ -27,17 +23,12 @@ test("given an empty array, it returns an empty array", () => { // Given an array with no duplicates // When passed to the dedupe function // Then it should return a copy of the original array -<<<<<<< HEAD -test("given an array with no duplicates, it returns the same values", () => { - expect(dedupe([1, 2, 3])).toEqual([1, 2, 3]); -======= test("given an array with no duplicates, it returns a copy of the original array", () => { const input = [1, 2, 3]; const result = dedupe(input); expect(result).toEqual(input); expect(result).not.toBe(input); ->>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) }); // Given an array with strings or numbers diff --git a/Sprint-1/implement/max.js b/Sprint-1/implement/max.js index 3e0d7fdc5..dc71d3af4 100644 --- a/Sprint-1/implement/max.js +++ b/Sprint-1/implement/max.js @@ -5,20 +5,12 @@ function findMax(elements) { let maxValue = -Infinity; for (const element of elements) { -<<<<<<< HEAD - // Only compare values that are real numbers - if (typeof element === "number" && !Number.isNaN(element)) { - if (element > maxValue) { - maxValue = element; - } -======= if (Number.isFinite(element) && element > maxValue) { maxValue = element; ->>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) } } return maxValue; } -module.exports = findMax; +module.exports = findMax; \ No newline at end of file diff --git a/Sprint-1/implement/max.test.js b/Sprint-1/implement/max.test.js index 0b586673f..ebb57b922 100644 --- a/Sprint-1/implement/max.test.js +++ b/Sprint-1/implement/max.test.js @@ -51,11 +51,7 @@ test("given an array with decimal numbers, returns the largest decimal", () => { // When passed to the max function // Then it should return the max and ignore non-numeric values test("given an array with non-number values, ignores them and returns the max", () => { -<<<<<<< HEAD - expect(findMax(["hey", 10, "hi", 60, 10])).toBe(60); -======= expect(findMax(["hey", 10, "300", "hi", 60, 10])).toBe(60); ->>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) }); // Given an array with only non-number values diff --git a/Sprint-1/implement/sum.js b/Sprint-1/implement/sum.js index 806e3fbe3..59f5ecc83 100644 --- a/Sprint-1/implement/sum.js +++ b/Sprint-1/implement/sum.js @@ -5,12 +5,7 @@ function sum(elements) { let total = 0; for (const element of elements) { -<<<<<<< HEAD - // Only add values that are real numbers - if (typeof element === "number" && !Number.isNaN(element)) { -======= if (Number.isFinite(element)) { ->>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) total += element; } } diff --git a/Sprint-1/implement/sum.test.js b/Sprint-1/implement/sum.test.js index f87cbf953..0698757ef 100644 --- a/Sprint-1/implement/sum.test.js +++ b/Sprint-1/implement/sum.test.js @@ -35,11 +35,7 @@ test("given an array with negative numbers, returns the correct sum", () => { // When passed to the sum function // Then it should return the correct total sum test("given an array with decimal numbers, returns the correct sum", () => { -<<<<<<< HEAD - expect(sum([1.5, 2.5, 3])).toBe(7); -======= expect(sum([1.2, 0.6, 0.005])).toBeCloseTo(1.805, 10); ->>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups) }); // Given an array containing non-number values From bbecf91fa9f124db791ad736e63191dd1f70feda Mon Sep 17 00:00:00 2001 From: Richard Frimpong Date: Fri, 20 Mar 2026 11:56:39 +0000 Subject: [PATCH 6/6] Improve dedupe test to ensure input is not mutated --- Sprint-1/implement/dedupe.test.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index 1bcda7a54..4674094bd 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -25,10 +25,13 @@ test("given an empty array, it returns an empty array", () => { // Then it should return a copy of the original array test("given an array with no duplicates, it returns a copy of the original array", () => { const input = [1, 2, 3]; + const expected = [1, 2, 3]; + const result = dedupe(input); - expect(result).toEqual(input); + expect(result).toEqual(expected); expect(result).not.toBe(input); + expect(input).toEqual([1, 2, 3]); }); // Given an array with strings or numbers