I added changes to the implemented functions

Author: Mona-Eltantawy

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -16,21 +16,18 @@
 
 function getAngleType(angle) {
   if (angle > 0 && angle < 90) {
-    return 'Acute angle';
+    return "Acute angle";
+  } else if (angle === 90) {
+    return "Right angle";
+  } else if (angle > 90 && angle < 180) {
+    return "Obtuse angle";
+  } else if (angle === 180) {
+    return "Stright angle";
+  } else if (angle > 180 && angle < 360) {
+    return "Reflex angle";
+  } else {
+    return "Invalid angle";
   }
-  else if (angle===90) {
-    return 'Right angle';
-  }
-  else if ( angle > 90 && angle < 180){
-    return 'Obtuse angle';
-  }
-  else if( angle === 180) {
-    return 'Stright angle';
-  }
-  else if (angle > 180 && angle < 360) {
-    return 'Reflex angle';
-  }
-  else {return 'Invalid angle';}
 
   // TODO: Implement this function
 }
@@ -52,31 +49,31 @@ function assertEquals(actualOutput, targetOutput) {
 // Example: Identify Right Angles
 // const right = getAngleType(90);
 // assertEquals(right, "Right angle");
-assertEquals (getAngleType(90), "Right angle");
+assertEquals(getAngleType(90), "Right angle");
 
 // const acute = getAngleType(45);
 // assertEquals(acute, "Acute angle");
-assertEquals (getAngleType(45),"Acute angle");
+assertEquals(getAngleType(45), "Acute angle");
 
 // const obtuse = getAngleType(120);
 // assertEquals(obtuse, "Obtuse angle");
-assertEquals (getAngleType(120),"Obtuse angle");
+assertEquals(getAngleType(120), "Obtuse angle");
 
 // const stright = getAngleType(180);
 // assertEquals(stright, "Stright angle");
-assertEquals (getAngleType(180),"Stright angle");
+assertEquals(getAngleType(180), "Stright angle");
 // const reflex = getAngleType(270);
 // assertEquals(reflex, "Reflex angle");
-assertEquals (getAngleType(270),"Reflex angle");
+assertEquals(getAngleType(270), "Reflex angle");
 
 // const invalid = getAngleType(360);
 // assertEquals(invalid, "Invalid angle");
-assertEquals (getAngleType(360),"Invalid angle");
+assertEquals(getAngleType(360), "Invalid angle");
 //Boundary cases
 //  const invalid = getAngleType(0);
 // assertEquals(invalid, "Invalid angle");
-assertEquals (getAngleType(0),"Invalid angle");
-//Outside range 
+assertEquals(getAngleType(0), "Invalid angle");
+//Outside range
 // const invalid = getAngleType(-10 , 400);
 // assertEquals(invalid, "Invalid angle");
-assertEquals (getAngleType(-10 , 400),"Invalid angle");
+assertEquals(getAngleType(-10, 400), "Invalid angle");

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,14 +11,13 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-  if( numerator <  denominator) {
-    return true;
-  }
-  else {return false; }
+  if (denominator === 0) return false;
 
-  // TODO: Implement this function
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 
+// TODO: Implement this function
+
 // The line below allows us to load the isProperFraction function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
 module.exports = isProperFraction;
@@ -37,17 +36,19 @@ function assertEquals(actualOutput, targetOutput) {
 // Example: 1/2 is a proper fraction
 assertEquals(isProperFraction(1, 2), true);
 // inproper fraction:
-assertEquals (isProperFraction(5, 3), false );
+assertEquals(isProperFraction(5, 3), false);
 
 // equal numbers
-assertEquals (isProperFraction(4, 4), false );
+assertEquals(isProperFraction(4, 4), false);
 
 // negative numbers
-assertEquals (isProperFraction(-2, 4), true );
-assertEquals (isProperFraction(5, -4), false );
-assertEquals (isProperFraction (-3,-5), false);
+assertEquals(isProperFraction(-2, 4), true);
+assertEquals(isProperFraction(5, -4), false);
+assertEquals(isProperFraction(-3, -5), false);
+assertEquals(isProperFraction(-1, 2), true);
+assertEquals(isProperFraction(-1, 2), true);
 
 // special case
-assertEquals(isProperFraction(1,0) , false);
+assertEquals(isProperFraction(1, 0), false);
 
-assertEquals (isProperFraction (0,5), true);
+assertEquals(isProperFraction(0, 5), true);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -37,15 +37,14 @@ function getCardValue(card) {
     return 10;
   }
 
-  if (rank >= "2" && rank <= "10") {
+  if (Number(rank) >= 2 && Number(rank) <= 10) {
     return Number(rank);
   }
 
   throw new Error("Invalid card");
 }
 
-  // TODO: Implement this function
-
+// TODO: Implement this function
 
 // The line below allows us to load the getCardValue function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
@@ -81,7 +80,6 @@ try {
   console.error("Error was not thrown for invalid card");
 } catch (e) {}
 
-
 // What other invalid card cases can you think of?
 
 const invalidCards = ["invalid", "1♠", "B♣", "10?", "Z♠"];
@@ -92,4 +90,4 @@ for (const card of invalidCards) {
   } catch (e) {
     // Expected error, do nothing
   }
-}
+}