Address review nits: docstring, dead prop, stale docs, import order

- Update switchFreebuffModel docstring to match the silent auto-revert
  the tick loop actually does (not the prompt-to-end-first flow it used
  to describe).
- Remove the unused `disabled` prop on FreebuffModelSelector; the only
  caller never set it, so the component's internal `pending` state is
  the only disable path.
- Refresh docs/freebuff-waiting-room.md for per-model queues: mermaid,
  schema (with the `model` column from migration 0044), admission loop
  (per-model advisory locks, getFleetHealth), tunables, POST semantics,
  model_locked response shape, and the CLI / multi-pod sections.
- Group endAndRejoinFreebuffSession with the other ../hooks/* imports
  in command-registry.ts.

Author: jahooma

cli/src/commands/command-registry.ts

@@ -3,14 +3,14 @@ import { CLAUDE_OAUTH_ENABLED } from '@codebuff/common/constants/claude-oauth'
 import { safeOpen } from '../utils/open-url'
 
 import { handleAdsEnable, handleAdsDisable } from './ads'
-import { buildInterviewPrompt, buildPlanPrompt, buildReviewPromptFromArgs } from './prompt-builders'
-import { endAndRejoinFreebuffSession } from '../hooks/use-freebuff-session'
-import { useThemeStore } from '../hooks/use-theme'
 import { handleHelpCommand } from './help'
 import { handleImageCommand } from './image'
 import { handleInitializationFlowLocally } from './init'
+import { buildInterviewPrompt, buildPlanPrompt, buildReviewPromptFromArgs } from './prompt-builders'
 import { runBashCommand } from './router'
 import { handleUsageCommand } from './usage'
+import { endAndRejoinFreebuffSession } from '../hooks/use-freebuff-session'
+import { useThemeStore } from '../hooks/use-theme'
 import { WEBSITE_URL } from '../login/constants'
 import { useChatStore } from '../state/chat-store'
 import { useFeedbackStore } from '../state/feedback-store'

cli/src/components/freebuff-model-selector.tsx

@@ -11,42 +11,33 @@ import { useTheme } from '../hooks/use-theme'
 
 import type { KeyEvent } from '@opentui/core'
 
-interface FreebuffModelSelectorProps {
-  /** Disables interaction while a switch / refresh is mid-flight so the user
-   *  can't queue up a second switch and double-bounce themselves to the back
-   *  of yet another queue. */
-  disabled?: boolean
-}
-
 /**
  * Lets the user pick which model's queue they're in. Tapping (or pressing the
  * row's number key) on a different model triggers a re-POST: the server moves
  * them to the back of the new model's queue.
  */
-export const FreebuffModelSelector: React.FC<FreebuffModelSelectorProps> = ({
-  disabled = false,
-}) => {
+export const FreebuffModelSelector: React.FC = () => {
   const theme = useTheme()
   const selectedModel = useFreebuffModelStore((s) => s.selectedModel)
   const [pending, setPending] = useState<string | null>(null)
   const [hoveredId, setHoveredId] = useState<string | null>(null)
 
   const pick = useCallback(
     (modelId: string) => {
-      if (disabled || pending) return
+      if (pending) return
       if (modelId === selectedModel) return
       setPending(modelId)
       switchFreebuffModel(modelId).finally(() => setPending(null))
     },
-    [disabled, pending, selectedModel],
+    [pending, selectedModel],
   )
 
   // Number-key shortcuts (1-9) so keyboard-only users can switch without
   // hunting for a clickable region.
   useKeyboard(
     useCallback(
       (key: KeyEvent) => {
-        if (disabled || pending) return
+        if (pending) return
         const name = key.name ?? ''
         if (!/^[1-9]$/.test(name)) return
         const digit = Number(name)
@@ -57,7 +48,7 @@ export const FreebuffModelSelector: React.FC<FreebuffModelSelectorProps> = ({
           pick(target.id)
         }
       },
-      [disabled, pending, pick, selectedModel],
+      [pending, pick, selectedModel],
     ),
   )
 
@@ -79,7 +70,7 @@ export const FreebuffModelSelector: React.FC<FreebuffModelSelectorProps> = ({
         const indicator = isSelected ? '●' : '○'
         const indicatorColor = isSelected ? theme.primary : theme.muted
         const labelColor = isSelected ? theme.foreground : theme.muted
-        const interactable = !disabled && !pending && !isSelected
+        const interactable = !pending && !isSelected
         return (
           <Button
             key={model.id}

cli/src/hooks/use-freebuff-session.ts

@@ -170,8 +170,10 @@ export async function refreshFreebuffSession(opts: { resetChat?: boolean } = {})
 /**
  * User picked a different model in the waiting room. Persist the choice and
  * re-POST so the server moves them to the back of the new model's queue. If
- * the user has an active session bound to a different model, the server
- * responds with `model_locked` and the UI prompts them to end first.
+ * the server has already admitted them on a different model, it responds
+ * with `model_locked`; the tick loop silently reverts the local selection to
+ * the locked model so the active session stays intact. Users who really want
+ * to switch can /end-session deliberately.
  */
 export async function switchFreebuffModel(model: string): Promise<void> {
   if (!IS_FREEBUFF) return