Merge pull request #82 from CommitField/feat/#20

Feat/#20

Author: skyeong42

build.gradle.kts

@@ -47,6 +47,9 @@ dependencies {
 
 	//redis
 	implementation("org.springframework.boot:spring-boot-starter-data-redis")
+	implementation ("org.redisson:redisson-spring-boot-starter:3.42.0") // redis message broker(lock)
+	implementation ("org.springframework.session:spring-session-data-redis")
+
 
 	// Security
 	implementation("org.springframework.boot:spring-boot-starter-security")

src/main/java/cmf/commitField/domain/chat/chatRoom/repository/ChatRoomRepository.java

@@ -1,14 +1,10 @@
 package cmf.commitField.domain.chat.chatRoom.repository;
 
 import cmf.commitField.domain.chat.chatRoom.entity.ChatRoom;
-import jakarta.persistence.LockModeType;
-import jakarta.persistence.QueryHint;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.data.jpa.repository.JpaRepository;
-import org.springframework.data.jpa.repository.Lock;
 import org.springframework.data.jpa.repository.Query;
-import org.springframework.data.jpa.repository.QueryHints;
 import org.springframework.data.repository.query.Param;
 import org.springframework.stereotype.Repository;
 
@@ -17,8 +13,8 @@
 @Repository
 public interface ChatRoomRepository extends JpaRepository<ChatRoom, Long> {
 
-    @Lock(LockModeType.PESSIMISTIC_WRITE)
-    @QueryHints({@QueryHint(name = "javax.persistence.lock.timeout", value ="1000")})
+//    @Lock(LockModeType.PESSIMISTIC_WRITE)
+//    @QueryHints({@QueryHint(name = "javax.persistence.lock.timeout", value ="1000")})
     Optional<ChatRoom> findById(Long aLong);
 
     Optional<ChatRoom> findChatRoomById(Long id);

src/main/java/cmf/commitField/domain/chat/chatRoom/service/ChatRoomServiceImpl.java

@@ -12,24 +12,33 @@
 import cmf.commitField.global.error.ErrorCode;
 import cmf.commitField.global.exception.CustomException;
 import lombok.RequiredArgsConstructor;
+import org.redisson.api.RLock;
+import org.redisson.api.RedissonClient;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Isolation;
 import org.springframework.transaction.annotation.Transactional;
 
 import java.time.LocalDateTime;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Objects;
+import java.util.concurrent.TimeUnit;
 
 @Service
 @RequiredArgsConstructor
 public class ChatRoomServiceImpl implements ChatRoomService {
 
     private final ChatRoomRepository chatRoomRepository;
+
+    private final ChatMessageRepository chatMessageRepository;
+
     private final UserRepository userRepository;
+
     private final UserChatRoomRepository userChatRoomRepository;
-    private final ChatMessageRepository chatMessageRepository;
+
+    private final RedissonClient redissonClient;
 
     @Override
     @Transactional
@@ -61,38 +70,6 @@ public void createRoom(ChatRoomRequest chatRoomRequest, Long userId) {
         userChatRoomRepository.save(userChatRoom);
     }
 
-    @Override
-    @Transactional
-    public void joinRoom(Long roomId, Long userId) {
-        // 유저 조회
-        User findUser = userRepository.findById(userId)
-                .orElseThrow(() -> new CustomException(ErrorCode.NOT_FOUND_USER));
-
-        // room 조회
-        ChatRoom chatRoom = chatRoomRepository.findById(roomId)
-                .orElseThrow(() -> new CustomException(ErrorCode.NOT_FOUND_ROOM));
-
-        // 현재 인원 수 조회
-        Long currentUserCount = userChatRoomRepository.countByChatRoomId(roomId);
-        // 채팅방이 꽉 찼을 경우 예외 처리
-        if (currentUserCount >= chatRoom.getUserCountMax()) {
-            throw new CustomException(ErrorCode.ROOM_USER_FULL);
-        }
-
-        // 이미 참여한 방인지 확인
-        if (userChatRoomRepository.existsByChatRoomIdAndUserId(roomId, userId)) {
-            throw new CustomException(ErrorCode.ALREADY_JOIN_ROOM);
-        }
-
-
-        // user_chatroom 관계 생성
-        UserChatRoom userChatRoom = UserChatRoom.builder()
-                .user(findUser)
-                .chatRoom(chatRoom)
-                .build();
-        userChatRoomRepository.save(userChatRoom);
-    }
-
     // 방 조회 DTO 변환 메서드 추출
     private static List<ChatRoomDto> getChatRoomDtos(Page<ChatRoom> all) {
         List<ChatRoomDto> chatRoomList = new ArrayList<>();
@@ -110,6 +87,7 @@ private static List<ChatRoomDto> getChatRoomDtos(Page<ChatRoom> all) {
         return chatRoomList;
     }
 
+
     // 채팅방 전체 조회
     @Override
     @Transactional(readOnly = true)
@@ -135,12 +113,57 @@ public List<ChatRoomDto> getUserByRoomPartList(Long userId, Pageable pageable) {
         return getChatRoomDtos(allByUserIdAndUserChatRooms);
     }
 
+    @Override
+    @Transactional(isolation = Isolation.READ_UNCOMMITTED)
+    public void joinRoom(Long roomId, Long userId) {
+        RLock lock = redissonClient.getLock("joinRoomLock:" + roomId);
+        try {
+            boolean available = lock.tryLock(1, TimeUnit.SECONDS);
+
+            if (!available) {
+                throw new CustomException(ErrorCode.FAILED_GET_LOCK);
+            }
+            // 유저 조회
+            User findUser = getUser(userId);
+
+            // room 조회
+            ChatRoom chatRoom = chatRoomRepository.findById(roomId) // lock (기존)
+                    .orElseThrow(() -> new CustomException(ErrorCode.NOT_FOUND_ROOM));
+
+            // user_chatroom 현재 인원 카운트 (비즈니스 로직)
+            Long currentUserCount = userChatRoomRepository.countNonLockByChatRoomId(roomId); // lock (기존)
+
+            List<Long> userChatRoomByChatRoomId = userChatRoomRepository
+                    .findUserChatRoomByChatRoom_Id(roomId);
+
+            if (userChatRoomByChatRoomId.contains(userId)) {
+                throw new CustomException(ErrorCode.ALREADY_JOIN_ROOM);
+            }
+
+            // chatroom 입장
+            if (currentUserCount >= chatRoom.getUserCountMax()) {
+                throw new CustomException(ErrorCode.ROOM_USER_FULL);
+            }
+
+            UserChatRoom userChatRoom = UserChatRoom.builder()
+                    .user(findUser)
+                    .chatRoom(chatRoom)
+                    .build();
+            userChatRoomRepository.save(userChatRoom);
+            // 비즈니스 로직 끝
+        } catch (InterruptedException e) {
+            throw new CustomException(ErrorCode.FAILED_GET_LOCK);
+        } finally {
+            lock.unlock();
+        }
+
+
+    }
+
     @Override
     @Transactional
     public void outRoom(Long userId, Long roomId) {
-        ChatRoom room = chatRoomRepository
-                .findChatRoomById(roomId)
-                .orElseThrow(() -> new CustomException(ErrorCode.NO_ROOM_FOUND));
+        ChatRoom room = getChatRoom(roomId);
         // 방장이 아니라면
         if (!Objects.equals(room.getRoomCreator(), userId)) {
             userChatRoomRepository.deleteUserChatRoomByChatRoom_IdAndUserId(roomId, userId);
@@ -153,13 +176,10 @@ public void outRoom(Long userId, Long roomId) {
 
     }
 
-
     @Override
     @Transactional
     public void deleteRoom(Long userId, Long roomId) {
-        ChatRoom room = chatRoomRepository
-                .findChatRoomById(roomId)
-                .orElseThrow(() -> new CustomException(ErrorCode.NO_ROOM));
+        ChatRoom room = getChatRoom(roomId);
         //방장이 아닐 경우, 삭제 불가
         if (!Objects.equals(room.getRoomCreator(), userId)) {
             throw new CustomException(ErrorCode.NOT_ROOM_CREATOR);
@@ -169,8 +189,19 @@ public void deleteRoom(Long userId, Long roomId) {
         userChatRoomRepository.deleteUserChatRoomByChatRoom_Id(roomId);
         chatRoomRepository.deleteById(roomId);
 
-}
+    }
+
+    private User getUser(Long userId) {
+        return userRepository.findById(userId)
+                .orElseThrow(() -> new CustomException(ErrorCode.NOT_FOUND_USER));
+    }
 
 
+    private ChatRoom getChatRoom(Long roomId) {
+        return chatRoomRepository
+                .findChatRoomById(roomId)
+                .orElseThrow(() -> new CustomException(ErrorCode.NONE_ROOM));
+
+    }
 
 }

src/main/java/cmf/commitField/domain/chat/userChatRoom/repository/UserChatRoomRepository.java

@@ -1,12 +1,8 @@
 package cmf.commitField.domain.chat.userChatRoom.repository;
 
 import cmf.commitField.domain.chat.userChatRoom.entity.UserChatRoom;
-import jakarta.persistence.LockModeType;
-import jakarta.persistence.QueryHint;
 import org.springframework.data.jpa.repository.JpaRepository;
-import org.springframework.data.jpa.repository.Lock;
 import org.springframework.data.jpa.repository.Query;
-import org.springframework.data.jpa.repository.QueryHints;
 import org.springframework.data.repository.query.Param;
 import org.springframework.stereotype.Repository;
 
@@ -15,8 +11,8 @@
 @Repository
 public interface UserChatRoomRepository extends JpaRepository<UserChatRoom, Long> {
 
-    @Lock(LockModeType.PESSIMISTIC_WRITE)
-    @QueryHints({@QueryHint(name = "javax.persistence.lock.timeout", value = "1000")})
+//    @Lock(LockModeType.PESSIMISTIC_WRITE)
+//    @QueryHints({@QueryHint(name = "javax.persistence.lock.timeout", value = "1000")})
     Long countByChatRoomId(Long roomId); // 비관적 락
 
 //    @Query("select count(*) from UserChatRoom u where u.chatRoom.id = ?1 ")
@@ -32,7 +28,8 @@ public interface UserChatRoomRepository extends JpaRepository<UserChatRoom, Long
     boolean existsByChatRoomIdAndUserId(Long roomId, Long userId);
     // 특정 방에 참여한 모든 UserChatRoom 관계 조회
     List<UserChatRoom> findByChatRoom_Id(Long chatRoomId);
-
+    @Query("select u.user.id from UserChatRoom u where u.chatRoom.id = ?1")
+    List<Long> findUserChatRoomByChatRoom_Id(Long chatRoomId);
 
 
 }

src/main/java/cmf/commitField/global/config/RedisConfig.java

@@ -7,6 +7,7 @@
 import org.springframework.data.redis.connection.RedisStandaloneConfiguration;
 import org.springframework.data.redis.connection.lettuce.LettuceConnectionFactory;
 import org.springframework.data.redis.core.RedisTemplate;
+import org.springframework.data.redis.core.StringRedisTemplate;
 import org.springframework.data.redis.serializer.GenericJackson2JsonRedisSerializer;
 import org.springframework.data.redis.serializer.StringRedisSerializer;
 
@@ -34,7 +35,7 @@ public RedisConnectionFactory redisConnectionFactory() {
         configuration.setHostName(host);
         configuration.setPort(port);
         return new LettuceConnectionFactory(configuration);
-
+    }
     @Bean
     public StringRedisTemplate stringRedisTemplate(RedisConnectionFactory redisConnectionFactory) {
         StringRedisTemplate template = new StringRedisTemplate();

src/main/java/cmf/commitField/global/error/ErrorCode.java

@@ -51,7 +51,10 @@ public enum ErrorCode {
 
     //chatMessage
     EMPTY_MESSAGE(HttpStatus.BAD_REQUEST, "채팅 메시지는 공백으로 보낼 수 없습니다."),
-    CHAT_NOT_FOUND(HttpStatus.NOT_FOUND, "해당 채팅방의 메시지들을 찾지 못했습니다.");
+    CHAT_NOT_FOUND(HttpStatus.NOT_FOUND, "해당 채팅방의 메시지들을 찾지 못했습니다."),
+
+    // Lock
+    FAILED_GET_LOCK(HttpStatus.LOCKED, "락을 획득하지 못했습니다.");
 
     private final HttpStatus httpStatus;
     private final String message;

src/main/resources/application.yml

@@ -18,7 +18,7 @@ spring:
   jpa:
     open-in-view: false
     hibernate:
-      ddl-auto: create
+      ddl-auto: update
     properties:
       hibernate:
         default_batch_fetch_size: 100