Skip to content

Chapter 14.1: Review a PR with Inline Comments (ssawczyn) #2280

@accesswatch

Description

@accesswatch

Warning

This issue is part of the GIT Going with GitHub course.
Do not start this challenge until the course officially begins.

Chapter 14: Accessible Code Review Challenge

Student: @ssawczyn
Estimated Time: 20-30 minutes
Skill Level: advanced


Challenge Overview

Check out or view an assigned practice PR, read the diff, and post constructive feedback on 2-3 specific lines.

All challenges in this chapter are linked to the Challenge Hub for full context and instructions.


Your Challenge: Review a PR with Inline Comments

Check out or view an assigned practice PR, read the diff, and post constructive feedback on 2-3 specific lines.


How to Submit

Step 1: Claim This Issue

Reply with a comment: I'm working on this!

Step 2: Complete the Challenge

Follow the detailed steps in the Challenge Hub.

  1. Find an open PR to review (check the PR list or ask facilitator for assignment)
  2. Open the Files Changed tab
  3. Read through the diff
  4. Post 2-3 inline comments on specific lines with constructive feedback
  5. Focus on: heading structure, link text, missing steps, or typos
  6. Post a completion comment on this issue:
Chapter 14.1 complete:
- Found a PR to review: yes/no
- Read the diff: yes/no
- Posted inline comments (count):
- Link to my review: [paste URL]

Step 3: Post Your Evidence

When complete, post a comment on this issue with your evidence (see format below).

Step 4: Close This Issue

After facilitator confirms, close this issue.


Expected Outcomes

  • You can navigate PR diffs with a screen reader
  • You can post inline comments on specific lines
  • You can write constructive feedback that helps the author improve

If You Get Stuck

  1. If Files Changed tab will not open, reload the PR page and retry
  2. If inline comment button is hard to find, use the file tree to jump between files
  3. If unsure what to comment on, focus on clarity: heading structure, link text, missing steps, or typos
  4. If submitting the review fails, check that you are not in draft mode and have write access
  5. Ask facilitator to help navigate one diff and model one constructive comment

Learning Moment

Constructive review is a gift. Specific, kind feedback helps authors improve and builds trust in the community.

Next Step: Check out Challenge Hub for the next challenge or chapter!

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions