From 74f688562cc1ef9871d521885ca474eb5cae04e3 Mon Sep 17 00:00:00 2001 From: WilcoLouwerse Date: Thu, 26 Mar 2026 20:09:47 +0100 Subject: [PATCH 1/5] feat: add stable33 CI support, EUPL license, and app-config.json docs --- .github/workflows/code-quality.yml | 2 +- appinfo/info.xml | 4 ++-- openspec/README.md | 9 +++++++++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml index e60acc1..19daf46 100644 --- a/.github/workflows/code-quality.yml +++ b/.github/workflows/code-quality.yml @@ -14,7 +14,7 @@ jobs: app-name: app-template php-version: "8.3" php-test-versions: '["8.3", "8.4"]' - nextcloud-test-refs: '["stable31", "stable32"]' + nextcloud-test-refs: '["stable31", "stable32", "stable33"]' enable-psalm: true enable-phpstan: true enable-phpmetrics: true diff --git a/appinfo/info.xml b/appinfo/info.xml index 23c0833..63c6eae 100644 --- a/appinfo/info.xml +++ b/appinfo/info.xml @@ -35,7 +35,7 @@ Vrij en open source onder de EUPL-1.2-licentie. **Ondersteuning:** Voor ondersteuning, neem contact op via support@conduction.nl. ]]> 0.1.0 - agpl + eupl Conduction AppTemplate @@ -52,7 +52,7 @@ Vrij en open source onder de EUPL-1.2-licentie. https://raw.githubusercontent.com/ConductionNL/nextcloud-app-template/main/img/app-store.svg - + diff --git a/openspec/README.md b/openspec/README.md index f29d7a5..9bed16a 100644 --- a/openspec/README.md +++ b/openspec/README.md @@ -14,6 +14,15 @@ This folder contains feature specifications, architectural decisions, and implem > If `app-config.json` has `"requiresOpenRegister": true`, install [OpenRegister](https://github.com/ConductionNL/openregister) before enabling this app. Set to `false` if your app does not use OpenRegister. +## app-config.json — Key Fields + +| Field | Default | Notes | +|-------|---------|-------| +| `cicd.enableNewman` | `false` | Enable only when a Postman collection exists in the repo. Newman runs API test collections in CI — enabling it without a collection breaks every pipeline run. **To enable:** add a Postman collection to `tests/`, set `enableNewman: true`, and run `/opsx:app-apply`. | +| `cicd.phpVersions` | `["8.3", "8.4"]` | PHP versions to test against. Update when Nextcloud drops support for older PHP versions. | +| `cicd.nextcloudRefs` | `["stable31", ...]` | Nextcloud branches to test against. Add new stable refs as Nextcloud releases them. | +| `dependencies.requiresOpenRegister` | `true` | Controls whether the app shows an OpenRegister gate in `src/App.vue` and adds OpenRegister to CI `additional-apps`. | + ## Artifact Progression Each change in `changes/` moves through these artifacts: From db70594d0594c9585e1c48d73d7c18919bd482c9 Mon Sep 17 00:00:00 2001 From: WilcoLouwerse Date: Thu, 2 Apr 2026 14:46:22 +0200 Subject: [PATCH 2/5] chore: add conduction schema symlink to openspec --- openspec/schemas/conduction | 1 + 1 file changed, 1 insertion(+) create mode 120000 openspec/schemas/conduction diff --git a/openspec/schemas/conduction b/openspec/schemas/conduction new file mode 120000 index 0000000..80cef47 --- /dev/null +++ b/openspec/schemas/conduction @@ -0,0 +1 @@ +../../../.claude/openspec/schemas/conduction \ No newline at end of file From e266d0af84daff0f21deed812e2ee156e308e519 Mon Sep 17 00:00:00 2001 From: WilcoLouwerse Date: Thu, 2 Apr 2026 16:10:54 +0200 Subject: [PATCH 3/5] fix: rename branch-protection workflow job ID for consistency --- .github/workflows/branch-protection.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/branch-protection.yml b/.github/workflows/branch-protection.yml index 67cdd60..41d64c3 100644 --- a/.github/workflows/branch-protection.yml +++ b/.github/workflows/branch-protection.yml @@ -5,6 +5,6 @@ on: branches: [main, beta] jobs: - protect: + branch-protection: uses: ConductionNL/.github/.github/workflows/branch-protection.yml@main - secrets: inherit + secrets: inherit \ No newline at end of file From af185bdd48e5fbd16adb47d151d9f2febfdc9a81 Mon Sep 17 00:00:00 2001 From: WilcoLouwerse Date: Thu, 2 Apr 2026 16:52:33 +0200 Subject: [PATCH 4/5] chore: trigger PR re-evaluation From f631f58e141a5cf7ed0f3de0d69594731c193e0b Mon Sep 17 00:00:00 2001 From: WilcoLouwerse Date: Thu, 2 Apr 2026 16:57:15 +0200 Subject: [PATCH 5/5] fix: rename branch-protection job ID to match org ruleset --- .github/workflows/branch-protection.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/branch-protection.yml b/.github/workflows/branch-protection.yml index 41d64c3..e9b2d3a 100644 --- a/.github/workflows/branch-protection.yml +++ b/.github/workflows/branch-protection.yml @@ -5,6 +5,6 @@ on: branches: [main, beta] jobs: - branch-protection: + check: uses: ConductionNL/.github/.github/workflows/branch-protection.yml@main secrets: inherit \ No newline at end of file