Skip to content

Set logUnauthorized: false in crumb plugin configuration#1197

Closed
davidjamesstone wants to merge 1 commit into
mainfrom
feature/DF-1075-do-not-log-unauthorized-crumb
Closed

Set logUnauthorized: false in crumb plugin configuration#1197
davidjamesstone wants to merge 1 commit into
mainfrom
feature/DF-1075-do-not-log-unauthorized-crumb

Conversation

@davidjamesstone
Copy link
Copy Markdown
Contributor

@davidjamesstone davidjamesstone commented May 14, 2026

https://eaflood.atlassian.net/browse/DF-1075

#974 introduced forwardLogs to make sure internal/plugin logging using standard hapi request.log & server.log were forwarded to pino/opensearch.

This allowed us to confirm the 403's are being issued by crumb when there's a CSRF token mismatch.
Now we know this is the correct behaviour, we can turn off crumb logUnauthorized so we don't log twice. We'll still get the 403 logged once via errorPages.ts

@sonarqubecloud
Copy link
Copy Markdown

@davidjamesstone
Copy link
Copy Markdown
Contributor Author

I did that PR prior to us finding out about:

  • the 403's that are issued when ?force
  • the 403's that CDP/WAF were issuing prior to this morning's fix

I'm going to keep the crumb logs in for now, with the expectation that they should tail off.

@alexluckett
Copy link
Copy Markdown
Contributor

I did that PR prior to us finding out about:

* the 403's that are issued when ?force

* the 403's that CDP/WAF were issuing prior to this morning's fix

I'm going to keep the crumb logs in for now, with the expectation that they should tail off.

ah gotcha, i forgot. looks like your new version of engine is pulled into this repo, so I assume we can close this PR now @davidjamesstone ?

@davidjamesstone
Copy link
Copy Markdown
Contributor Author

I did that PR prior to us finding out about:

* the 403's that are issued when ?force

* the 403's that CDP/WAF were issuing prior to this morning's fix

I'm going to keep the crumb logs in for now, with the expectation that they should tail off.

ah gotcha, i forgot. looks like your new version of engine is pulled into this repo, so I assume we can close this PR now @davidjamesstone ?

Closed. We can re-open if/when we're happy they've tailed off. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants