From 788883f0449814e933eb47be8d2f8c2937fa09cc Mon Sep 17 00:00:00 2001 From: Claude Code Date: Mon, 1 Dec 2025 13:26:58 -0600 Subject: [PATCH] Merge bitcoin/bitcoin#25963: CBlockLocator: performance-move-const-arg Clang tidy fixup 6b24dfe24d2ed50ea0b06ce1919db3dc0e871a03 CBlockLocator: performance-move-const-arg Clang tidy fixups (Jon Atack) Pull request description: Fix Clang-tidy CI errors on master. See https://cirrus-ci.com/task/4806752200818688?logs=ci#L4696 for an example. ACKs for top commit: MarcoFalke: review ACK 6b24dfe24d2ed50ea0b06ce1919db3dc0e871a03 vasild: ACK 6b24dfe24d2ed50ea0b06ce1919db3dc0e871a03 Tree-SHA512: 7a67acf7b42da07b63fbb392236e9a7be8cf35c36e37ca980c4467fe8295c2eda8aef10f41a1e3036cd9ebece47fa957fc3256033f853bd6a97ce2ca42799a0a --- src/chain.cpp | 2 +- src/primitives/block.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/chain.cpp b/src/chain.cpp index 765c4d55a6ba..1b313317ca34 100644 --- a/src/chain.cpp +++ b/src/chain.cpp @@ -54,7 +54,7 @@ CBlockLocator CChain::GetLocator(const CBlockIndex *pindex) const { nStep *= 2; } - return CBlockLocator(vHave); + return CBlockLocator(std::move(vHave)); } const CBlockIndex *CChain::FindFork(const CBlockIndex *pindex) const { diff --git a/src/primitives/block.h b/src/primitives/block.h index f33e44ad3904..bdeff68d9444 100644 --- a/src/primitives/block.h +++ b/src/primitives/block.h @@ -242,7 +242,7 @@ struct CBlockLocator CBlockLocator() {} - explicit CBlockLocator(const std::vector& vHaveIn) : vHave(vHaveIn) {} + explicit CBlockLocator(std::vector&& have) : vHave(std::move(have)) {} SERIALIZE_METHODS(CBlockLocator, obj) {