Skip to content

Commit 5f44d26

Browse files
committed
Apply review suggestions
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
1 parent d200781 commit 5f44d26

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

datadog-live-debugger-ffi/src/data.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ impl Drop for LogProbe<'_> {
115115
}
116116

117117
#[no_mangle]
118-
pub extern "C" fn drop_log_probe_capture_expressions(_: LogProbe) {}
118+
pub extern "C" fn ddog_drop_log_probe_capture_expressions(_: LogProbe) {}
119119

120120
#[repr(C)]
121121
pub struct Tag<'a> {
@@ -168,7 +168,7 @@ impl<'a> From<&'a datadog_live_debugger::SpanDecorationProbe> for SpanDecoration
168168
}
169169

170170
#[no_mangle]
171-
extern "C" fn drop_span_decoration_probe(_: SpanDecorationProbe) {}
171+
extern "C" fn ddog_drop_span_decoration_probe(_: SpanDecorationProbe) {}
172172

173173
impl Drop for SpanDecorationProbe<'_> {
174174
fn drop(&mut self) {

datadog-live-debugger-ffi/src/send_data.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,9 +160,8 @@ pub extern "C" fn ddog_create_exception_snapshot<'a>(
160160
#[no_mangle]
161161
pub extern "C" fn ddog_vec_last_debugger_payload<'a>(
162162
buffer: &'a mut Vec<DebuggerPayload<'a>>,
163-
) -> *mut DebuggerPayload<'a> {
164-
#[allow(clippy::unwrap_used)]
165-
buffer.last_mut().unwrap()
163+
) -> Option<&'a mut DebuggerPayload<'a>> {
164+
buffer.last_mut()
166165
}
167166

168167
#[no_mangle]

0 commit comments

Comments
 (0)