-
Notifications
You must be signed in to change notification settings - Fork 11
BlueAPI Config Mount Easily Overwriteable #1451
Description
The BlueAPI helm deployment requires a configuration file mounted at /config/config.yaml in order to run. This is badly implemented, being easily overwritten when other other custom volumes are mounted.
Current Implementation
The config volume is defined in statefulset.yaml here, while the volume mount is defined in .Values.volumeMounts here and propagated into the StatefulSet here.
This functions, but can be broken by anyone defining their own .Values.volumeMounts in a custom values file, which would remove the config mount. This has caused issues for a support engineer on I19.
I think the intention behind this was to allow mounting user-written config files at /config/config.yaml. However, configuration can already be customised through user-written Values.yaml files, and I prefer this method.
Acceptance Criteria
- The configuration file mounted at
/config/config.yamlis not overridden when custom values are set in.Values.volumeMounts