Breakage with upcoming dplyr 1.1.0

[DavisVaughan]

Hi there, we are working on revdeps for dplyr 1.1.0 and your package came up.

I think you are passing arguments through the join functions (like left_join()) that don't actually exist for our data frame methods (like .progress and overwrite). We have started checking that the ... are actually empty in these methods, as this helps users avoid accidental typos.

Can you please take a look? We plan to submit dplyr 1.1.0 on January 27th.

I took a quick look but it looks complicated enough that you will probably need to have a hand in the changes.

Here is a reprex. You can reproduce if you install the dev version of dplyr with pak::pak("tidyverse/dplyr")

library(disk.frame)

a = data.frame(a = 1:100, b = 1:100)
b = data.frame(a = 51:150, b = 1:100)

as.disk.frame(a, file.path(tempdir(), "tmp_a_sj.df"), nchunks = 4, overwrite = TRUE)
#> path: "/var/folders/41/qx_9ygp112nfysdfgxcssgwc0000gn/T//RtmpFCqGc9/tmp_a_sj.df"
#> nchunks: 4
#> nrow (at source): 100
#> ncol (at source): 2
as.disk.frame(b, file.path(tempdir(), "tmp_b_sj.df"), nchunks = 5, overwrite = TRUE)
#> path: "/var/folders/41/qx_9ygp112nfysdfgxcssgwc0000gn/T//RtmpFCqGc9/tmp_b_sj.df"
#> nchunks: 5
#> nrow (at source): 100
#> ncol (at source): 2

a = disk.frame(file.path(tempdir(), "tmp_a_sj.df"))
b = disk.frame(file.path(tempdir(), "tmp_b_sj.df"))
bc = collect(b)

abc = semi_join(a, bc, by = "a") %>% collect
#> Error in `semi_join()` at disk.frame/R/semi_join.r:21:6:
#> ! `...` must be empty.
#> ✖ Problematic arguments:
#> • ..1 = dataframe
#> • .progress = .progress
#> ℹ Did you forget to name an argument?

[xiaodaigh]

Thanks! Will take a look

[xiaodaigh]

tests are probably broken by this. Need to look at this now

[xiaodaigh]

fixed all issues and passing tests offline. submited to cran