sql-kysely: kysely plugins not honored when using effect/sql client backend

[jvliwanag]

What version of Effect is running?

@effect/sql-kysely 0.33.1

What steps can reproduce the bug?

Create a kysely using @effect/sql-kysely/Pg.

import * as PgKysely from "@effect/sql-kysely/Pg"
import { CamelCasePlugin } from "kysely"

PgKysely.make<Schema.DB>({
  plugins: [new CamelCasePlugin()],
})

What is the expected behavior?

Query variables and results are transformed to camel case.

What do you see instead?

No transformation happens.

Additional information

Workaround is to use native kysely instead:

import * as SqlKysely from "@effect/sql-kysely/Kysely";

SqlKysely.make<Schema.DB>({
      dialect: new PostgresDialect({
        pool: new Pool(),
      }),
      plugins: [new CamelCasePlugin()],
    })

If it seems plugins can't be supported, should we just blacklist plugins as well from the make options as we do so for dialect?

[Powell-v2]

@jvliwanag which kysely version is involved here?

[jvliwanag]

I'm on kysely 0.28.2

[Powell-v2]

I dug into related code and it doesn't seem like plugins are supported when using sql-kysely/Pg since it's powered by effect/sql backend, so not entirely sure if bug label is appropriate here? What's your primary use case for this plugin? Perhaps transform* options would be good enough.

[jvliwanag]

Best case of course is we find a way to support. But if not, we should also exclude the “plugins” key type wise as we do so for “dialect”.

[Powell-v2]

Yeah supporting the plugins would be great I suppose. Any ideas how the implementation might look like?

[corelix]

We hit the same behavior on a newer stack as well:

• @effect/sql-kysely 0.47.0
• @effect/sql-pg 0.52.1
• kysely 0.28.14
• effect 3.21.0

Setup is @effect/sql-kysely/Pg with plugins: [new CamelCasePlugin()].

Query-side transform seems to work, but result rows still come back in snake_case unless we also pass transformResultNames: toCamelCase to @effect/sql-pg/PgClient.

Concrete runtime symptom on our side:

• a returningAll() / selectAll() row from Postgres contained agent_id
• app code expected agentId
• module tests passed because test runtime used PgClient.layerFromPool({ transformResultNames: toCamelCase })
• app runtime failed until we added the same transformResultNames option there too

So from the outside this still looks like Kysely result plugins are bypassed on the effect/sql execution path, while pg-level transform* options are the only reliable workaround right now.