Revert commit: 314a726 (#18)

YaroslavLitvinov · Denys Tsomenko · commit 54780e8fb3ca · 2025-04-28T15:57:38.000+03:00
* Revert "return Int64 instead of UInt64 when returning count (#17)" This reverts commit 314a726. * revert changes as of a bad approach use
diff --git a/datafusion/core/tests/user_defined/insert_operation.rs b/datafusion/core/tests/user_defined/insert_operation.rs
@@ -184,7 +184,7 @@ impl ExecutionPlan for TestInsertExec {
 fn make_count_schema() -> SchemaRef {
     Arc::new(Schema::new(vec![Field::new(
         "count",
-        DataType::Int64, // should return signed int for snowflake
+        DataType::UInt64,
         false,
     )]))
 }
diff --git a/datafusion/expr/src/logical_plan/dml.rs b/datafusion/expr/src/logical_plan/dml.rs
@@ -236,8 +236,7 @@ impl Display for InsertOp {
 
 fn make_count_schema() -> DFSchemaRef {
     Arc::new(
-        // should return signed int for snowflake
-        Schema::new(vec![Field::new("count", DataType::Int64, false)])
+        Schema::new(vec![Field::new("count", DataType::UInt64, false)])
             .try_into()
             .unwrap(),
     )

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ impl ExecutionPlan for TestInsertExec {`
`184`	`184`	`fn make_count_schema() -> SchemaRef {`
`185`	`185`	`Arc::new(Schema::new(vec![Field::new(`
`186`	`186`	`"count",`
`187`		`- DataType::Int64, // should return signed int for snowflake`
	`187`	`+ DataType::UInt64,`
`188`	`188`	`false,`
`189`	`189`	`)]))`
`190`	`190`	`}`
Original file line number	Diff line number	Diff line change
`@@ -236,8 +236,7 @@ impl Display for InsertOp {`
`236`	`236`
`237`	`237`	`fn make_count_schema() -> DFSchemaRef {`
`238`	`238`	`Arc::new(`
`239`		`- // should return signed int for snowflake`
`240`		`- Schema::new(vec![Field::new("count", DataType::Int64, false)])`
	`239`	`+ Schema::new(vec![Field::new("count", DataType::UInt64, false)])`
`241`	`240`	`.try_into()`
`242`	`241`	`.unwrap(),`
`243`	`242`	`)`