Also fix max_stack_size

LadyCailin · LadyCailin · commit f12d3ef5dcdb · 2026-03-14T01:19:56.000+01:00
diff --git a/src/main/java/com/laytonsmith/core/functions/Minecraft.java b/src/main/java/com/laytonsmith/core/functions/Minecraft.java
@@ -398,8 +398,8 @@ public ParseTree optimizeDynamic(Target t, Environment env,
 			if(children.size() < 1) {
 				return null;
 			}
-			if(children.get(0).getData().isInstanceOf(CString.TYPE, null, env) && children.get(0).getData().val().contains(":")
-					|| ArgumentValidation.isNumber(children.get(0).getData())) {
+			if(children.get(0).isConst() && (children.get(0).getData().isInstanceOf(CString.TYPE, null, env) && children.get(0).getData().val().contains(":")
+					|| ArgumentValidation.isNumber(children.get(0).getData()))) {
 				env.getEnv(CompilerEnvironment.class).addCompilerWarning(fileOptions,
 						new CompilerWarning("Numeric ids are deprecated in " + getName(), t, null));
 			}

Original file line number	Diff line number	Diff line change
`@@ -398,8 +398,8 @@ public ParseTree optimizeDynamic(Target t, Environment env,`
`398`	`398`	`if(children.size() < 1) {`
`399`	`399`	`return null;`
`400`	`400`	`}`
`401`		`- if(children.get(0).getData().isInstanceOf(CString.TYPE, null, env) && children.get(0).getData().val().contains(":")`
`402`		`- \|\| ArgumentValidation.isNumber(children.get(0).getData())) {`
	`401`	`+ if(children.get(0).isConst() && (children.get(0).getData().isInstanceOf(CString.TYPE, null, env) && children.get(0).getData().val().contains(":")`
	`402`	`+ \|\| ArgumentValidation.isNumber(children.get(0).getData()))) {`
`403`	`403`	`env.getEnv(CompilerEnvironment.class).addCompilerWarning(fileOptions,`
`404`	`404`	`new CompilerWarning("Numeric ids are deprecated in " + getName(), t, null));`
`405`	`405`	`}`