fix: address PR review comments from olivia-banks

- Use Pyodide-recommended stlite detection (sys.platform/sys.modules)
- Remove duplicate running_in_stlite() definition (F811)
- Escape HTML labels with html.escape() in parameter_ui.py
- Fix Makefile: UV ?= for env override, smelected typo, inline mkdir
- Remove -> None from build_index.py main()
- Fix AGENTS.md function contract for render_parameters_with_indent
- Fix Excel reset callback to use consistent model_key

Agent-Logs-Url: https://github.com/EpiForeSITE/epiworldPythonStreamlit/sessions/60bec289-6a09-4711-a403-13e7f0eb4742

Co-authored-by: gvegayon <893619+gvegayon@users.noreply.github.com>

Author: Copilot

AGENTS.md

@@ -108,7 +108,7 @@ tests.
 - `load_model_from_file(filepath: str) -> object`
 - `load_model_params(model_file_path: str, uploaded_excel=None) -> dict`
 - `flatten_dict(d, level=0)`
-- `render_parameters_with_indent(param_dict, params, label_overrides) -> None`
+- `render_parameters_with_indent(param_dict, params, model_id) -> None`
 - `reset_parameters_to_defaults(param_dict, params, model_id) -> None`
 - `render_sections(sections) -> None`
 

Makefile

@@ -1,4 +1,4 @@
-UV := uv
+UV ?= uv
 
 STLITE_VER ?= 0.86.0
 PORT ?= 8000
@@ -33,7 +33,8 @@ install: ## Install Python dependencies with uv
 .PHONY: build-html
 build-html: $(INDEX_HTML) ## Generate build/index.html (stlite WASM entry point)
 
-$(INDEX_HTML): $(STLITE_INPUTS) | $(BUILD_DIR)
+$(INDEX_HTML): $(STLITE_INPUTS)
+	@mkdir -p $(BUILD_DIR)
 	@echo "Generating $(INDEX_HTML) (stlite v$(STLITE_VER))"
 	$(UV) run python scripts/build_index.py \
 	--app $(APP_PY) \
@@ -42,14 +43,11 @@ $(INDEX_HTML): $(STLITE_INPUTS) | $(BUILD_DIR)
 	--js $(STLITE_JS) \
 	--title "EpiCON Cost Calculator"
 	@echo "Copying static assets into $(BUILD_DIR)/"
-	@for dir in utils config styles models smelected examples; do \
+	@for dir in utils config styles models selected examples; do \
 	if [ -d "$$dir" ]; then cp -r "$$dir" "$(BUILD_DIR)/$$dir"; fi; \
 	done
 	@echo "Build artefacts written to $(BUILD_DIR)/"
 
-$(BUILD_DIR):
-	mkdir -p $@
-
 .PHONY: dev
 dev: ## Run normal Streamlit locally
 	$(UV) run streamlit run $(APP_PY)

app.py

@@ -1,4 +1,5 @@
 import os
+import sys
 import yaml
 import streamlit as st
 import inspect
@@ -46,7 +47,7 @@ def normalize_yaml_defaults(raw_yaml: object) -> dict:
 
 def running_in_stlite() -> bool:
     """Return True when the app is running inside stlite/Pyodide."""
-    return os.path.abspath(__file__).startswith("/home/pyodide/")
+    return sys.platform == "emscripten" or "pyodide" in sys.modules
 
 
 def coerce_like_default(value: object, default: object) -> object:
@@ -167,7 +168,7 @@ def normalize_stlite_params(params: dict, defaults: dict) -> dict:
 
         def handle_reset_excel() -> None:
             """Reset Excel parameters and output labels to defaults."""
-            reset_parameters_to_defaults(editable_defaults, params, uploaded_excel_model.name)
+            reset_parameters_to_defaults(editable_defaults, params, model_key)
             if current_headers:
                 for col_letter, default_text in current_headers.items():
                     st.session_state[f"label_override_{col_letter}"] = default_text
@@ -342,7 +343,3 @@ def handle_reset_python() -> None:
 
             sections = model_module.build_sections(results)
             render_sections(sections)
-
-def running_in_stlite() -> bool:
-    """Return True when the app is running inside stlite/Pyodide."""
-    return os.path.abspath(__file__).startswith("/home/pyodide/")

scripts/build_index.py

@@ -113,7 +113,7 @@ def build_html(
 """
 
 
-def main() -> None:
+def main():
     """Generate the stlite index.html file."""
     args = parse_args()
 

utils/parameter_ui.py

@@ -1,3 +1,5 @@
+import html
+
 import streamlit as st
 
 
@@ -24,10 +26,11 @@ def render_parameters_with_indent(
         clean_label = label.lstrip("\t")
 
         if value is None:
+            safe_label = html.escape(clean_label)
             st.sidebar.markdown(
                 (
                     f"<div style='margin-left:{indent_level * 1.5}em; "
-                    f"font-weight:600;'>{clean_label}</div>"
+                    f"font-weight:600;'>{safe_label}</div>"
                 ),
                 unsafe_allow_html=True,
             )