From 9514716f7feb13db2c1ee1402e8e589a1111e324 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 9 Mar 2026 12:02:08 +0000 Subject: [PATCH 1/2] Initial plan From fadd94978e0f886a88852e432524079fb883241f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 9 Mar 2026 12:08:23 +0000 Subject: [PATCH 2/2] refactor: replace magic numbers with named constants in format_relative_time Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com> --- src/main_app/version.rs | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/main_app/version.rs b/src/main_app/version.rs index 45fa0c5b..12ba05a6 100644 --- a/src/main_app/version.rs +++ b/src/main_app/version.rs @@ -76,16 +76,20 @@ pub fn handle_version(noterminal: bool) -> Result<(), Box Ok(()) } +const SECS_PER_MIN: i64 = 60; +const SECS_PER_HOUR: i64 = 3_600; +const SECS_PER_DAY: i64 = 86_400; + /// Format a duration in seconds as a human-readable relative time string. fn format_relative_time(diff_seconds: i64) -> String { - if diff_seconds < 60 { + if diff_seconds < SECS_PER_MIN { format!("({} seconds ago)", diff_seconds) - } else if diff_seconds < 3600 { - format!("({} minutes ago)", diff_seconds / 60) - } else if diff_seconds < 86400 { - format!("({} hours ago)", diff_seconds / 3600) + } else if diff_seconds < SECS_PER_HOUR { + format!("({} minutes ago)", diff_seconds / SECS_PER_MIN) + } else if diff_seconds < SECS_PER_DAY { + format!("({} hours ago)", diff_seconds / SECS_PER_HOUR) } else { - format!("({} days ago)", diff_seconds / 86400) + format!("({} days ago)", diff_seconds / SECS_PER_DAY) } }