fix: single ']' character output when no data matches the query (#9)

* fix: single ']' character output when no data matches the query

Author: bzarboni1

cmd/list/orgs/orgs.go

@@ -8,6 +8,7 @@ import (
 	"fmt"
 	"gh_foundations/internal/pkg/functions"
 	"os"
+	"strings"
 
 	"github.com/spf13/cobra"
 )
@@ -24,7 +25,7 @@ var OrgsCmd = &cobra.Command{
 		return nil
 	},
 	Run: func(cmd *cobra.Command, args []string) {
-		
+
 		orgsDir := args[0]
 
 		orgs, err := functions.FindManagedOrgs(orgsDir)
@@ -33,16 +34,11 @@ var OrgsCmd = &cobra.Command{
 			os.Exit(1)
 		}
 
-		var orgOut string
-		orgOut = ""
-		for _, org := range orgs {
-			if orgOut != "" {
-				orgOut = fmt.Sprintf("%s, '%s'", orgOut, org)
-			} else {
-				orgOut = fmt.Sprintf("['%s'", org)
-			}
+		var orgOut string = "[]"
+
+		if len(orgs) > 0 {
+			orgOut = fmt.Sprintf("['%s']", strings.Join(orgs, "', '"))
 		}
-		orgOut = fmt.Sprintf("%s]", orgOut)
 
 		fmt.Println(orgOut)
 

cmd/list/repos/repos.go

@@ -10,6 +10,7 @@ import (
 	"gh_foundations/internal/pkg/types/status"
 	"log"
 	"os"
+	"strings"
 
 	"github.com/spf13/cobra"
 )
@@ -36,21 +37,19 @@ var ReposCmd = &cobra.Command{
 		if err != nil {
 			log.Fatalf("Error in findManagedRepos: %s", err)
 		}
-		
+
+		repoList := flattenRepos(orgSet)
+
 		if ghas {
 			orgSet = orgSet.WithGHASEnabled()
-			log.Printf("Found %d repositories with GHAS enabled\n", len(flattenRepos(orgSet)))
+			repoList = flattenRepos(orgSet)
+			log.Printf("Found %d repositories with GHAS enabled\n", len(repoList))
 		}
-		var repos string
-		repos = ""
-		for _, repo := range flattenRepos(orgSet) {
-			if repos != "" {
-				repos = fmt.Sprintf("%s, '%s'", repos, repo)
-			} else {
-				repos = fmt.Sprintf("['%s'", repo)
-			}
+
+		repos := "[]"
+		if len(repoList) > 0 {
+			repos = fmt.Sprintf("['%s']", strings.Join(repoList, "', '"))
 		}
-		repos = fmt.Sprintf("%s]", repos)
 
 		fmt.Println(repos)
 	},
@@ -80,4 +79,4 @@ func flattenRepos(org status.OrgSet) []string {
 		}
 	}
 	return repoNames
-}
+}