Resolve VCSWP-20046 (Java SDK: Add readOnly flags and private setters to the cspId, brandId, and universalEin properties in SMSTenDLCBrand Model) (#45)

* Edit some setters in SMSTenDLCBrand file and SMSTenDLCPartnerCampaignBrand file

* Edit tests to ensure correct items are being tested

* Add new changelog entry

* Undo openapi changes

Author: amahadaya

.openapi-generator/FILES

@@ -306,5 +306,5 @@ src/main/java/com/github/freeclimbapi/auth/ApiKeyAuth.java
 src/main/java/com/github/freeclimbapi/auth/Authentication.java
 src/main/java/com/github/freeclimbapi/auth/HttpBasicAuth.java
 src/main/java/com/github/freeclimbapi/auth/HttpBearerAuth.java
-src/test/java/com/github/freeclimbapi/AddToConferenceAllOfTest.java
-src/test/java/com/github/freeclimbapi/AddToConferenceTest.java
+src/test/java/com/github/freeclimbapi/SMSTenDLCBrandTest.java
+src/test/java/com/github/freeclimbapi/SMSTenDLCPartnerCampaignBrandTest.java

CHANGELOG.md

@@ -9,6 +9,14 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 None
 
+<a name="5.4.3"></a>
+
+## [5.4.3] 2023-08-28
+
+### Changed
+
+- Changed setters from public to private for specific read-only variables
+
 <a name="5.4.2"></a>
 
 ## [5.4.2] 2023-07-26

README.md

@@ -40,7 +40,7 @@ Add this dependency to your project's POM:
 <dependency>
   <groupId>com.github.freeclimbapi</groupId>
   <artifactId>freeclimb-java-client</artifactId>
-  <version>5.4.2</version>
+  <version>5.4.3</version>
   <scope>compile</scope>
 </dependency>
 ```
@@ -56,7 +56,7 @@ Add this dependency to your project's build file:
   }
 
   dependencies {
-     implementation "com.github.freeclimbapi:freeclimb-java-client:5.4.2"
+     implementation "com.github.freeclimbapi:freeclimb-java-client:5.4.3"
      implementation("com.squareup.okhttp3:okhttp:4.9.3")
      implementation("com.squareup.okhttp3:logging-interceptor:4.9.3")
   }
@@ -72,7 +72,7 @@ mvn clean package
 
 Then manually install the following JARs:
 
-* `target/freeclimb-java-client-5.4.2.jar`
+* `target/freeclimb-java-client-5.4.3.jar`
 * `target/lib/*.jar`
 
 ## Getting Started

build.gradle

@@ -4,7 +4,7 @@ apply plugin: 'java'
 apply plugin: 'com.diffplug.spotless'
 
 group = 'com.github.freeclimbapi'
-version = '5.4.2'
+version = '5.4.3'
 
 buildscript {
     repositories {

build.sbt

@@ -2,7 +2,7 @@ lazy val root = (project in file(".")).
   settings(
     organization := "com.github.freeclimbapi",
     name := "freeclimb-java-client",
-    version := "5.4.2",
+    version := "5.4.3",
     scalaVersion := "2.11.4",
     scalacOptions ++= Seq("-feature"),
     javacOptions in compile ++= Seq("-Xlint:deprecation"),

pom.xml

@@ -5,7 +5,7 @@
     <artifactId>freeclimb-java-client</artifactId>
     <packaging>jar</packaging>
     <name>freeclimb-java-client</name>
-    <version>5.4.2</version>
+    <version>5.4.3</version>
     <url>https://github.com/freeclimbapi/java-sdk</url>
     <description>FreeClimb Java Client</description>
     <scm>

src/main/java/com/github/freeclimbapi/ApiClient.java

@@ -131,7 +131,7 @@ private void init() {
         json = new JSON();
 
         // Set default User-Agent.
-        setUserAgent("OpenAPI-Generator/5.4.2/java");
+        setUserAgent("OpenAPI-Generator/5.4.3/java");
 
         authentications = new HashMap<String, Authentication>();
     }

src/main/java/com/github/freeclimbapi/models/SMSTenDLCBrand.java

@@ -543,7 +543,7 @@ public String getCspId() {
     return cspId;
   }
 
-  public void setCspId(String cspId) {
+  private void setCspId(String cspId) {
     this.cspId = cspId;
   }
 
@@ -559,7 +559,7 @@ public String getBrandId() {
     return brandId;
   }
 
-  public void setBrandId(String brandId) {
+  private void setBrandId(String brandId) {
     this.brandId = brandId;
   }
 
@@ -1038,7 +1038,7 @@ public String getUniversalEin() {
     return universalEin;
   }
 
-  public void setUniversalEin(String universalEin) {
+  private void setUniversalEin(String universalEin) {
     this.universalEin = universalEin;
   }
 

src/main/java/com/github/freeclimbapi/models/SMSTenDLCPartnerCampaignBrand.java

@@ -131,7 +131,7 @@ public String getBrandId() {
     return brandId;
   }
 
-  public void setBrandId(String brandId) {
+  private void setBrandId(String brandId) {
     this.brandId = brandId;
   }