Added rector

Author: GrahamCampbell

.gitattributes

@@ -14,3 +14,4 @@
 /psalm.xml export-ignore
 /CHANGELOG.md export-ignore
 /README.md export-ignore
+/rector.yml export-ignore

.github/workflows/static.yml

@@ -68,3 +68,42 @@ jobs:
 
       - name: Execute Psalm
         run: vendor/bin/psalm --no-progress --output-format=github
+
+  rector:
+    name: Rector
+    runs-on: ubuntu-20.04
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 7.4
+          tools: composer:v2, cs2pr
+          coverage: none
+
+      - name: Install Dependencies
+        uses: nick-invision/retry@v1
+        with:
+          timeout_minutes: 5
+          max_attempts: 5
+          command: composer update --no-interaction --no-progress
+
+      - name: Install PHPUnit
+        uses: nick-invision/retry@v1
+        with:
+          timeout_minutes: 5
+          max_attempts: 5
+          command: composer bin phpunit update --no-interaction --no-progress
+
+      - name: Install Rector
+        uses: nick-invision/retry@v1
+        with:
+          timeout_minutes: 5
+          max_attempts: 5
+          command: composer bin rector update --no-interaction --no-progress
+
+      - name: Execute Rector
+        run: vendor/bin/rector process --dry-run --output-format=checkstyle | cs2pr

Makefile

@@ -20,7 +20,13 @@ psalm-baseline:
 psalm-show-info:
 	@docker run -it -w /data -v ${PWD}:/data:delegated --entrypoint vendor/bin/psalm --rm registry.gitlab.com/grahamcampbell/php:7.4-cli --show-info=true
 
-test: phpunit phpstan-analyze psalm-analyze
+rector-dry-run:
+	@docker run -it -w /data -v ${PWD}:/data:delegated --entrypoint vendor/bin/rector --rm registry.gitlab.com/grahamcampbell/php:7.4-cli process --dry-run
+
+rector-fix:
+	@docker run -it -w /data -v ${PWD}:/data:delegated --entrypoint vendor/bin/rector --rm registry.gitlab.com/grahamcampbell/php:7.4-cli process
+
+test: phpunit phpstan-analyze psalm-analyze rector-dry-run
 
 clean:
 	@rm -rf .phpunit.result.cache composer.lock vendor vendor-bin/*/composer.lock vendor-bin/*/vendor

rector.yml

@@ -0,0 +1,27 @@
+parameters:
+    autoload_paths:
+        - 'vendor/autoload.php'
+        - 'vendor-bin/phpunit/vendor/autoload.php'
+    auto_import_names: true
+    import_short_classes: false
+    import_doc_blocks: false
+    php_version_features: '5.6'
+    paths:
+        - 'lib'
+        - 'test'
+    sets:
+        - 'code-quality'
+        - 'dead-code'
+        - 'php52'
+        - 'php53'
+        - 'php54'
+        - 'php55'
+        - 'php56'
+        - 'phpunit40'
+        - 'phpunit50'
+
+services:
+    Rector\SOLID\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector: ~
+    Rector\SOLID\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector: ~
+    Rector\SOLID\Rector\If_\ChangeNestedIfsToEarlyReturnRector: ~
+    Rector\SOLID\Rector\If_\RemoveAlwaysElseRector: ~

vendor-bin/rector/composer.json

@@ -0,0 +1,8 @@
+{
+    "require": {
+        "rector/rector": "~0.7.48"
+    },
+    "config": {
+        "preferred-install": "dist"
+    }
+}