Applied fixes from reactor

Author: GrahamCampbell

lib/Gitlab/Api/Groups.php

@@ -422,7 +422,7 @@ private function getGroupSearchResolver()
         $resolver->setDefined('skip_groups')
             ->setAllowedTypes('skip_groups', 'array')
             ->setAllowedValues('skip_groups', function (array $value) {
-                return count($value) == count(array_filter($value, 'is_int'));
+                return count($value) === count(array_filter($value, 'is_int'));
             })
         ;
         $resolver->setDefined('all_available')

lib/Gitlab/Api/GroupsMilestones.php

@@ -25,7 +25,7 @@ public function all($group_id, array $parameters = [])
         $resolver->setDefined('iids')
             ->setAllowedTypes('iids', 'array')
             ->setAllowedValues('iids', function (array $value) {
-                return count($value) == count(array_filter($value, 'is_int'));
+                return count($value) === count(array_filter($value, 'is_int'));
             })
         ;
         $resolver->setDefined('state')

lib/Gitlab/Api/Issues.php

@@ -515,7 +515,7 @@ protected function createOptionsResolver()
         $resolver->setDefined('iids')
             ->setAllowedTypes('iids', 'array')
             ->setAllowedValues('iids', function (array $value) {
-                return count($value) == count(array_filter($value, 'is_int'));
+                return count($value) === count(array_filter($value, 'is_int'));
             })
         ;
         $resolver->setDefined('scope')

lib/Gitlab/Api/MergeRequests.php

@@ -48,7 +48,7 @@ public function all($project_id = null, array $parameters = [])
         $resolver->setDefined('iids')
             ->setAllowedTypes('iids', 'array')
             ->setAllowedValues('iids', function (array $value) {
-                return count($value) == count(array_filter($value, 'is_int'));
+                return count($value) === count(array_filter($value, 'is_int'));
             })
         ;
         $resolver->setDefined('state')

lib/Gitlab/Api/Milestones.php

@@ -25,7 +25,7 @@ public function all($project_id, array $parameters = [])
         $resolver->setDefined('iids')
             ->setAllowedTypes('iids', 'array')
             ->setAllowedValues('iids', function (array $value) {
-                return count($value) == count(array_filter($value, 'is_int'));
+                return count($value) === count(array_filter($value, 'is_int'));
             })
         ;
         $resolver->setDefined('state')

lib/Gitlab/Api/Projects.php

@@ -103,7 +103,7 @@ public function show($project_id, array $parameters = [])
     {
         $resolver = $this->createOptionsResolver();
         $booleanNormalizer = function (Options $resolver, $value) {
-            return $value ? true : false;
+            return (bool) $value;
         };
         $resolver->setDefined('statistics')
             ->setAllowedTypes('statistics', 'bool')

lib/Gitlab/Client.php

@@ -2,6 +2,31 @@
 
 namespace Gitlab;
 
+use Gitlab\Api\DeployKeys;
+use Gitlab\Api\Deployments;
+use Gitlab\Api\Environments;
+use Gitlab\Api\Groups;
+use Gitlab\Api\GroupsBoards;
+use Gitlab\Api\GroupsMilestones;
+use Gitlab\Api\IssueBoards;
+use Gitlab\Api\IssueLinks;
+use Gitlab\Api\Issues;
+use Gitlab\Api\IssuesStatistics;
+use Gitlab\Api\Jobs;
+use Gitlab\Api\Keys;
+use Gitlab\Api\MergeRequests;
+use Gitlab\Api\Milestones;
+use Gitlab\Api\ProjectNamespaces;
+use Gitlab\Api\Projects;
+use Gitlab\Api\Repositories;
+use Gitlab\Api\RepositoryFiles;
+use Gitlab\Api\Schedules;
+use Gitlab\Api\Snippets;
+use Gitlab\Api\SystemHooks;
+use Gitlab\Api\Users;
+use Gitlab\Api\Tags;
+use Gitlab\Api\Version;
+use Gitlab\Api\Wiki;
 use Gitlab\Api\AbstractApi;
 use Gitlab\Exception\InvalidArgumentException;
 use Gitlab\HttpClient\Builder;
@@ -155,199 +180,199 @@ public static function createWithHttpClient(HttpClient $httpClient)
      */
     public function deployKeys()
     {
-        return new Api\DeployKeys($this);
+        return new DeployKeys($this);
     }
 
     /**
      * @return Api\Deployments
      */
     public function deployments()
     {
-        return new Api\Deployments($this);
+        return new Deployments($this);
     }
 
     /**
      * @return Api\Environments
      */
     public function environments()
     {
-        return new Api\Environments($this);
+        return new Environments($this);
     }
 
     /**
      * @return Api\Groups
      */
     public function groups()
     {
-        return new Api\Groups($this);
+        return new Groups($this);
     }
 
     /**
      * @return Api\GroupsBoards
      */
     public function groupsBoards()
     {
-        return new Api\GroupsBoards($this);
+        return new GroupsBoards($this);
     }
 
     /**
      * @return Api\GroupsMilestones
      */
     public function groupsMilestones()
     {
-        return new Api\GroupsMilestones($this);
+        return new GroupsMilestones($this);
     }
 
     /**
      * @return Api\IssueBoards
      */
     public function issueBoards()
     {
-        return new Api\IssueBoards($this);
+        return new IssueBoards($this);
     }
 
     /**
      * @return Api\IssueLinks
      */
     public function issueLinks()
     {
-        return new Api\IssueLinks($this);
+        return new IssueLinks($this);
     }
 
     /**
      * @return Api\Issues
      */
     public function issues()
     {
-        return new Api\Issues($this);
+        return new Issues($this);
     }
 
     /**
      * @return Api\IssuesStatistics
      */
     public function issuesStatistics()
     {
-        return new Api\IssuesStatistics($this);
+        return new IssuesStatistics($this);
     }
 
     /**
      * @return Api\Jobs
      */
     public function jobs()
     {
-        return new Api\Jobs($this);
+        return new Jobs($this);
     }
 
     /**
      * @return Api\Keys
      */
     public function keys()
     {
-        return new Api\Keys($this);
+        return new Keys($this);
     }
 
     /**
      * @return Api\MergeRequests
      */
     public function mergeRequests()
     {
-        return new Api\MergeRequests($this);
+        return new MergeRequests($this);
     }
 
     /**
      * @return Api\Milestones
      */
     public function milestones()
     {
-        return new Api\Milestones($this);
+        return new Milestones($this);
     }
 
     /**
      * @return Api\ProjectNamespaces
      */
     public function namespaces()
     {
-        return new Api\ProjectNamespaces($this);
+        return new ProjectNamespaces($this);
     }
 
     /**
      * @return Api\Projects
      */
     public function projects()
     {
-        return new Api\Projects($this);
+        return new Projects($this);
     }
 
     /**
      * @return Api\Repositories
      */
     public function repositories()
     {
-        return new Api\Repositories($this);
+        return new Repositories($this);
     }
 
     /**
      * @return Api\RepositoryFiles
      */
     public function repositoryFiles()
     {
-        return new Api\RepositoryFiles($this);
+        return new RepositoryFiles($this);
     }
 
     /**
      * @return Api\Schedules
      */
     public function schedules()
     {
-        return new Api\Schedules($this);
+        return new Schedules($this);
     }
 
     /**
      * @return Api\Snippets
      */
     public function snippets()
     {
-        return new Api\Snippets($this);
+        return new Snippets($this);
     }
 
     /**
      * @return Api\SystemHooks
      */
     public function systemHooks()
     {
-        return new Api\SystemHooks($this);
+        return new SystemHooks($this);
     }
 
     /**
      * @return Api\Users
      */
     public function users()
     {
-        return new Api\Users($this);
+        return new Users($this);
     }
 
     /**
      * @return Api\Tags
      */
     public function tags()
     {
-        return new Api\Tags($this);
+        return new Tags($this);
     }
 
     /**
      * @return Api\Version
      */
     public function version()
     {
-        return new Api\Version($this);
+        return new Version($this);
     }
 
     /**
      * @return Api\Wiki
      */
     public function wiki()
     {
-        return new Api\Wiki($this);
+        return new Wiki($this);
     }
 
     /**

lib/Gitlab/HttpClient/Plugin/ApiVersion.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\HttpClient\Plugin;
 
+use Http\Client\Common\Plugin\VersionBridgePlugin;
 use Http\Client\Common\Plugin;
 use Http\Promise\Promise;
 use Psr\Http\Message\RequestInterface;
@@ -18,7 +19,7 @@
  */
 class ApiVersion implements Plugin
 {
-    use Plugin\VersionBridgePlugin;
+    use VersionBridgePlugin;
 
     /**
      * @var bool

lib/Gitlab/HttpClient/Plugin/Authentication.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\HttpClient\Plugin;
 
+use Http\Client\Common\Plugin\VersionBridgePlugin;
 use Gitlab\Client;
 use Http\Client\Common\Plugin;
 use Http\Promise\Promise;
@@ -19,7 +20,7 @@
  */
 class Authentication implements Plugin
 {
-    use Plugin\VersionBridgePlugin;
+    use VersionBridgePlugin;
 
     /**
      * @var string

lib/Gitlab/HttpClient/Plugin/GitlabExceptionThrower.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\HttpClient\Plugin;
 
+use Http\Client\Common\Plugin\VersionBridgePlugin;
 use Gitlab\Exception\ApiLimitExceededException;
 use Gitlab\Exception\ErrorException;
 use Gitlab\Exception\RuntimeException;
@@ -24,7 +25,7 @@
  */
 class GitlabExceptionThrower implements Plugin
 {
-    use Plugin\VersionBridgePlugin;
+    use VersionBridgePlugin;
 
     /**
      * Handle the request and return the response coming from the next callable.